From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web09.485.1605160579763645521 for ; Wed, 11 Nov 2020 21:56:37 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: zhichao.gao@intel.com) IronPort-SDR: neSUamRXPjzFsHSiilSiX/x426YSDajxrmT9AepSGesgVc8RE2D0mLprQVd0ux1gBlZTR3oadw fvzBa/DhL10Q== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="254971299" X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="254971299" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 21:56:36 -0800 IronPort-SDR: zM4kOtoKrfVB5vfEXXKLo8jGnU+f6hu8fHexZOgBbf9tfom961jcQ2KMfOuG2cYwPOXUtiWRpW GG9UK7DrmMQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="366490846" Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga007.jf.intel.com with ESMTP; 11 Nov 2020 21:56:32 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [PATCH V4 12/13] NetworkPkg/Defines: Make iSCSI disable as default Date: Thu, 12 Nov 2020 13:55:57 +0800 Message-Id: <20201112055558.2348-13-zhichao.gao@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20201112055558.2348-1-zhichao.gao@intel.com> References: <20201112055558.2348-1-zhichao.gao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 iSCSI is using the deprecated function MD5. It is better to make the default setting secure. If the platforms want to use the iSCSI, they should enable it in the platforms' dsc file and be aware they are using an function with weak cryptography. Enable iSCSI in NetworkPkg.dsc for build. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Leif Lindholm Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Cc: Kelly Steele Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao --- NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- NetworkPkg/NetworkPkg.dsc | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/NetworkPkg/NetworkDefines.dsc.inc b/NetworkPkg/NetworkDefines.dsc.inc index a442d1b157..18921d81f6 100644 --- a/NetworkPkg/NetworkDefines.dsc.inc +++ b/NetworkPkg/NetworkDefines.dsc.inc @@ -17,7 +17,7 @@ # DEFINE NETWORK_TLS_ENABLE = TRUE # DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE # DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE -# DEFINE NETWORK_ISCSI_ENABLE = TRUE +# DEFINE NETWORK_ISCSI_ENABLE = FALSE # DEFINE NETWORK_VLAN_ENABLE = TRUE # # Copyright (c) 2019, Intel Corporation. All rights reserved.
@@ -101,7 +101,7 @@ # Both OpensslLib.inf and OpensslLibCrypto.inf library instance can be used # since libssl is not required for iSCSI. # - DEFINE NETWORK_ISCSI_ENABLE = TRUE + DEFINE NETWORK_ISCSI_ENABLE = FALSE !endif !if $(NETWORK_ENABLE) == TRUE diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index 716d04fdad..e508995e3a 100644 --- a/NetworkPkg/NetworkPkg.dsc +++ b/NetworkPkg/NetworkPkg.dsc @@ -2,7 +2,7 @@ # UEFI 2.4 Network Module Package for All Architectures # # (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
-# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.
# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -18,6 +18,8 @@ BUILD_TARGETS = DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER = DEFAULT + DEFINE NETWORK_ISCSI_ENABLE = TRUE + [LibraryClasses] DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf BaseLib|MdePkg/Library/BaseLib/BaseLib.inf -- 2.21.0.windows.1