From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.10061.1605628979552828804 for ; Tue, 17 Nov 2020 08:03:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=rsYNH3ph; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id j7so23698616wrp.3 for ; Tue, 17 Nov 2020 08:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1EJvqw2RJYBP6JwC8VmxCRCUGqq/xdaVKp0xLBbeoHY=; b=rsYNH3phkoQ2jlvfVxWSwwsb6CjhiCgMdQrVgN3wfwURpDN+k+jXwaxjGv9GqBhb/K H+G8Gmx1vyMJREp6hkeGT8021hZveXlkz5vt6/178IC3WFRmtLIrHEcYlde8nR92+rrt B4cBqVDvQFDRGj3L7/C7woqslAb2Xu9W1uxvsyR94vuixfZ71dBY2MNzjMcOTWuCcvMB 2oMrcaVoVxcdWtPwzCQHdPfRwsYSw6KW5u9HTu8TJfa4QXPJzhBTL04Bg6G4jL8SfpCl X5LqQmtZEu/FGQTuWDjv4o/vbs7drBFXFtbIaP6cSyJ8nGvh8NBgkdMydjcjgF1oKNP5 jUFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1EJvqw2RJYBP6JwC8VmxCRCUGqq/xdaVKp0xLBbeoHY=; b=hYlK0172PzCBd7H/x2ZJmp9GZIMaIZ5ZBPEATnap91WGV62TMHJkcTJvflKyOIGth3 FVyehJ8K5lwEhUBWHD+REySzag9xQx4JSU6LWCyKiVlM1dHwl4cAvOYb1ySBpwl+v6DN axOCYAfsBQfbVF8vunI4W/Lf+L1ynXNYHxjhgwGcudv392A/w8P4lPn9JjA48FOtQRtP gbGpNRKthHzL36xF53G6IpeRkGKRgiWgGCe05DBPM2lvpoteGdmQV4cHHEr8yhY/nkq7 FKcBJuD4rOjoFazgg5AV4Og5JZd4oxWCh8M+Nj+dbINuBN86ThQNfca8KOiOJoZ5hZDE fnXg== X-Gm-Message-State: AOAM533KzjuCCXU+hMOGnJxsXs1j2rkwEb0r2Xwvl/uZmRqj2ApRkXBs bH1Lz2ID9A0vJDm2I7nUb5OrTQ== X-Google-Smtp-Source: ABdhPJxfHU3ADMTg++Xm/uXn3XhRO9JzyUZt9mYtx45tY1DnBGXYd8wuru+1aH1BTSaJNCxDn9cBZQ== X-Received: by 2002:a5d:4001:: with SMTP id n1mr223548wrp.176.1605628978184; Tue, 17 Nov 2020 08:02:58 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id n123sm4157945wmn.38.2020.11.17.08.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 08:02:57 -0800 (PST) Date: Tue, 17 Nov 2020 16:02:55 +0000 From: "Leif Lindholm" To: Andrei Warkentin Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com, pete@akeo.ie, philmd@redhat.com Subject: Re: [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Message-ID: <20201117160255.GG1664@vanye> References: <20201115102527.2993-1-andrey.warkentin@gmail.com> MIME-Version: 1.0 In-Reply-To: <20201115102527.2993-1-andrey.warkentin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andrei, On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote: > Like the Pi 4B, the 3GB/4GB choices apply to it as well. > > Signed-off-by: Andrei Warkentin Patch looks straghtforward enough, but ideally I'd like someone to chime in with tested-by. That hasn't happened so far - are these documented anywhere I could easily sanity check myself? / Leif > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 5302ccd8..ade91c9f 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName ( > return "Raspberry Pi Compute Module 3+"; > case 0x11: > return "Raspberry Pi 4 Model B"; > + case 0x13: > + return "Raspberry Pi 400"; > + case 0x14: > + return "Raspberry Pi Compute Module 4"; > default: > return "Unknown Raspberry Pi Model"; > } > @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily ( > *ModelFamily = 3; > break; > case 0x11: // Raspberry Pi 4 Model B > + case 0x13: // Raspberry Pi 400 > + case 0x14: // Raspberry Pi Computer Module 4 > *ModelFamily = 4; > break; > default: > -- > 2.20.1 >