From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.21270.1605849805563488207 for ; Thu, 19 Nov 2020 21:23:27 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: heng.luo@intel.com) IronPort-SDR: hdVWyAHCEaGNN925fdSXECRXM/W/siZqNsRBghsqeZgxFOCuOaHvKQimepEU2kiw4GteWB5H+N fGbCX1XGqAZQ== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="170636483" X-IronPort-AV: E=Sophos;i="5.78,355,1599548400"; d="scan'208";a="170636483" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 21:23:24 -0800 IronPort-SDR: 2vfYvDyIQC56imSEp4CAIo5uieVv+IOIdh1nsTTIIFl7QT63ZfH6dly8Yj+1JR0V08mBlBy6Yb LLE9VKkUpZ2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,355,1599548400"; d="scan'208";a="545306395" Received: from hengluo-dev.ccr.corp.intel.com ([10.239.153.154]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2020 21:23:23 -0800 From: "Heng Luo" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [PATCH] UpXtreme: Enable USB DCI debug Date: Fri, 20 Nov 2020 13:23:15 +0800 Message-Id: <20201120052316.3707-1-heng.luo@intel.com> X-Mailer: git-send-email 2.24.0.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 Allow to debug BIOS via DCI cable. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Heng Luo --- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPchPolicyUpdatePreMem.c | 1 - Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConf= igLib/PeiCpuPolicyBoardConfig.c | 5 +++++ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConf= igLib/PeiPchPolicyBoardConfigPreMem.c | 7 +++++++ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConf= igLib/PeiPolicyBoardConfigLib.inf | 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBo= ardConfigLib/PeiPchPolicyBoardConfigPreMem.c | 6 ++++++ Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBo= ardConfigLib/PeiPolicyBoardConfigLib.inf | 1 + 6 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPchPolicyUpdatePreMem.c b/Platform/Intel/WhiskeylakeOpenBoard= Pkg/Policy/Library/PeiPolicyUpdateLib/PeiPchPolicyUpdatePreMem.c index 2d48b09175..ac5b583f89 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c @@ -83,7 +83,6 @@ UpdatePeiPchPolicyPreMem ( Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, &gIshPreMemConfigGui= d, (VOID *) &IshPreMemConfig);=0D ASSERT_EFI_ERROR (Status);=0D =0D - DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2;=0D PchTraceHubPreMemConfig->MemReg0Size =3D 3;=0D PchTraceHubPreMemConfig->MemReg1Size =3D 3;=0D //=0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPol= icyBoardConfigLib/PeiCpuPolicyBoardConfig.c b/Platform/Intel/WhiskeylakeOpe= nBoardPkg/UpXtreme/Library/PeiPolicyBoardConfigLib/PeiCpuPolicyBoardConfig.c index d1d1920823..d4c5136c0a 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiCpuPolicyBoardConfig.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiCpuPolicyBoardConfig.c @@ -44,6 +44,11 @@ UpdatePeiCpuPolicyBoardConfig ( Status =3D GetConfigBlock ((VOID *) SiPolicyPpi, &gCpuConfigGuid, (VOID = *) &CpuConfig);=0D ASSERT_EFI_ERROR (Status);=0D =0D + //=0D + //Enable processor debug features=0D + //=0D + CpuConfig->DebugInterfaceEnable =3D 1;=0D +=0D return Status;=0D }=0D =0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPol= icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c b/Platform/Intel/Whiskeyl= akeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConfigLib/PeiPchPolicyBoardC= onfigPreMem.c index 01bb75525b..c79718f4ee 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPchPolicyBoardConfigPreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPchPolicyBoardConfigPreMem.c @@ -25,12 +25,19 @@ UpdatePeiPchPolicyBoardConfigPreMem ( {=0D EFI_STATUS Status;=0D PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig;=0D + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig;=0D =0D DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre Mem\n"));= =0D =0D Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gPchGeneralPreMe= mConfigGuid, (VOID *) &PchGeneralPreMemConfig);=0D ASSERT_EFI_ERROR (Status);=0D =0D + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gDciPreMemConfig= Guid, (VOID *) &DciPreMemConfig);=0D + ASSERT_EFI_ERROR (Status);=0D +=0D + DciPreMemConfig->PlatformDebugConsent =3D 3;=0D + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 1;=0D +=0D return Status;=0D }=0D =0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPol= icyBoardConfigLib/PeiPolicyBoardConfigLib.inf b/Platform/Intel/WhiskeylakeO= penBoardPkg/UpXtreme/Library/PeiPolicyBoardConfigLib/PeiPolicyBoardConfigLi= b.inf index aaf0abbf04..affb322c59 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPolicyBoardConfigLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPolicyBoardConfigLib.inf @@ -54,6 +54,7 @@ gPchGeneralConfigGuid ## CONSUMES=0D gEfiTpmDeviceInstanceTpm20DtpmGuid=0D gEfiTpmDeviceInstanceTpm12Guid=0D + gDciPreMemConfigGuid=0D =0D [Ppis]=0D gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES=0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library= /PeiPolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c b/Platform/Intel/W= hiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBoardConfigLib/PeiP= chPolicyBoardConfigPreMem.c index 00cf73dfd9..5d75bc5e1c 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c @@ -25,12 +25,18 @@ UpdatePeiPchPolicyBoardConfigPreMem ( {=0D EFI_STATUS Status;=0D PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig;=0D + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig;=0D =0D DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre Mem\n"));= =0D =0D Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gPchGeneralPreMe= mConfigGuid, (VOID *) &PchGeneralPreMemConfig);=0D ASSERT_EFI_ERROR (Status);=0D =0D + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gDciPreMemConfig= Guid, (VOID *) &DciPreMemConfig);=0D + ASSERT_EFI_ERROR (Status);=0D +=0D + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2;=0D +=0D return Status;=0D }=0D =0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library= /PeiPolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf b/Platform/Intel/Whisk= eylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBoardConfigLib/PeiPolic= yBoardConfigLib.inf index 15ef223050..5de11d62e4 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPolicyBoardConfigLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPolicyBoardConfigLib.inf @@ -54,6 +54,7 @@ gPchGeneralConfigGuid ## CONSUMES=0D gEfiTpmDeviceInstanceTpm20DtpmGuid=0D gEfiTpmDeviceInstanceTpm12Guid=0D + gDciPreMemConfigGuid=0D =0D [Ppis]=0D gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES=0D --=20 2.24.0.windows.2