public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>, Ray Ni <ray.ni@intel.com>,
	Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
	Pete Batard <pete@akeo.ie>
Subject: [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE
Date: Tue, 24 Nov 2020 14:15:44 -0500	[thread overview]
Message-ID: <20201124191546.17403-2-Samer.El-Haj-Mahmoud@arm.com> (raw)
In-Reply-To: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com>

REF: https://github.com/pftf/RPi4/issues/115

GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE.
However, the driver never draws the cursor during init. This results
in the first call to disable the cursor (using ConOut->EnableCursor(FALSE))
to actually draw the cursor on the screen, as the logic in FlushCursor depends
on the Mode.CursorVisible state to determine if it should draw or erase
the cursor.

Fix by changing the default CursorVisible in this driver to FALSE.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
---
 MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
index c042451a9b52..6b8d11d587d1 100644
--- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
+++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c
@@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV    mGraphicsConsoleDevTemplate = {
     EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK),
     0,
     0,
-    TRUE
+    FALSE
   },
   (GRAPHICS_CONSOLE_MODE_DATA *) NULL,
   (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL
-- 
2.25.1


  reply	other threads:[~2020-11-24 19:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 19:15 [PATCH v1 0/3] MdeModulePkg/GraphicsConsole : Console cleanup Samer El-Haj-Mahmoud
2020-11-24 19:15 ` Samer El-Haj-Mahmoud [this message]
2020-12-01  0:45   ` [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Gao, Zhichao
2020-11-24 19:15 ` [PATCH v1 2/3] MdeModulePkg/Graphics: Fix spelling mistakes Samer El-Haj-Mahmoud
2020-12-01  0:45   ` Gao, Zhichao
2020-11-24 19:15 ` [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY Samer El-Haj-Mahmoud
2020-11-24 23:30   ` [edk2-devel] " Laszlo Ersek
2020-12-01  0:59     ` Gao, Zhichao
2020-12-01 15:17       ` Samer El-Haj-Mahmoud
2020-12-02 11:04         ` Gao, Zhichao
2020-12-04  0:04           ` Samer El-Haj-Mahmoud
2020-12-04  1:11             ` 回复: " gaoliming
2020-12-04  1:20               ` Samer El-Haj-Mahmoud
2020-12-04  5:23                 ` Gao, Zhichao
2020-12-04 12:42                   ` Samer El-Haj-Mahmoud
2020-12-04 14:13                     ` Ard Biesheuvel
2020-12-07 18:36                       ` Samer El-Haj-Mahmoud
2020-12-08  0:59                         ` Gao, Zhichao
2020-12-08 17:07                           ` Samer El-Haj-Mahmoud
2020-12-08  1:28                     ` Ni, Ray
2020-12-08 17:13                       ` Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124191546.17403-2-Samer.El-Haj-Mahmoud@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox