public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>, Ray Ni <ray.ni@intel.com>,
	Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Subject: [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
Date: Tue, 24 Nov 2020 14:15:46 -0500	[thread overview]
Message-ID: <20201124191546.17403-4-Samer.El-Haj-Mahmoud@arm.com> (raw)
In-Reply-To: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com>

ConSplitter was using EFI_LIGHTGRAY foreground color for ConOut
and EFI_MAGENTA for StdErr.

This does not work all the time, and StdErr ends up showing parts in
MAGENTA and other parts in LIGHTGRAY. Changing StdErr to LIGHTGRAY looks
better and is more consistent.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
---
 MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
index b090de288517..e8cd4ce120a0 100644
--- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
+++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
@@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart (
   // their MaxMode and QueryData should be the intersection of both.
   //
   Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
-  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK));
+  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIGHTGRAY, EFI_BLACK));
 
   return Status;
 }
-- 
2.25.1


  parent reply	other threads:[~2020-11-24 19:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 19:15 [PATCH v1 0/3] MdeModulePkg/GraphicsConsole : Console cleanup Samer El-Haj-Mahmoud
2020-11-24 19:15 ` [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Samer El-Haj-Mahmoud
2020-12-01  0:45   ` Gao, Zhichao
2020-11-24 19:15 ` [PATCH v1 2/3] MdeModulePkg/Graphics: Fix spelling mistakes Samer El-Haj-Mahmoud
2020-12-01  0:45   ` Gao, Zhichao
2020-11-24 19:15 ` Samer El-Haj-Mahmoud [this message]
2020-11-24 23:30   ` [edk2-devel] [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY Laszlo Ersek
2020-12-01  0:59     ` Gao, Zhichao
2020-12-01 15:17       ` Samer El-Haj-Mahmoud
2020-12-02 11:04         ` Gao, Zhichao
2020-12-04  0:04           ` Samer El-Haj-Mahmoud
2020-12-04  1:11             ` 回复: " gaoliming
2020-12-04  1:20               ` Samer El-Haj-Mahmoud
2020-12-04  5:23                 ` Gao, Zhichao
2020-12-04 12:42                   ` Samer El-Haj-Mahmoud
2020-12-04 14:13                     ` Ard Biesheuvel
2020-12-07 18:36                       ` Samer El-Haj-Mahmoud
2020-12-08  0:59                         ` Gao, Zhichao
2020-12-08 17:07                           ` Samer El-Haj-Mahmoud
2020-12-08  1:28                     ` Ni, Ray
2020-12-08 17:13                       ` Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124191546.17403-4-Samer.El-Haj-Mahmoud@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox