* [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox
@ 2020-11-25 2:30 Qi Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Qi Zhang @ 2020-11-25 2:30 UTC (permalink / raw)
To: devel; +Cc: Qi Zhang, Jiewen Yao, Jian J Wang, Rahul Kumar
wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
---
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
index 2946f95db0..81a4d3fa6a 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
@@ -710,9 +710,11 @@ SetConfigInfo (
)
{
switch (TpmAlgHash) {
+#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES
case TPM_ALG_SHA1:
Tcg2ConfigInfo->Sha1Supported = TRUE;
break;
+#endif
case TPM_ALG_SHA256:
Tcg2ConfigInfo->Sha256Supported = TRUE;
break;
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox
@ 2021-03-17 2:56 Qi Zhang
2021-03-17 4:19 ` Yao, Jiewen
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2021-03-17 2:56 UTC (permalink / raw)
To: devel; +Cc: Qi Zhang, Jiewen Yao, Jian J Wang, Rahul Kumar
wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
---
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
index 2946f95db0..81a4d3fa6a 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
@@ -710,9 +710,11 @@ SetConfigInfo (
)
{
switch (TpmAlgHash) {
+#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES
case TPM_ALG_SHA1:
Tcg2ConfigInfo->Sha1Supported = TRUE;
break;
+#endif
case TPM_ALG_SHA256:
Tcg2ConfigInfo->Sha256Supported = TRUE;
break;
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox
2021-03-17 2:56 Qi Zhang
@ 2021-03-17 4:19 ` Yao, Jiewen
0 siblings, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2021-03-17 4:19 UTC (permalink / raw)
To: Zhang, Qi1; +Cc: devel@edk2.groups.io, Wang, Jian J, Kumar, Rahul1
Thank you Qi.
i recommend we file a bugzilla on the scope of the problem
After the scope is agreed, then you can send the patch.
For example, I can ask why not remove the sha1supported field at all?
I hope the community can reach consensus on the problem statement at first.
thank you!
Yao, Jiewen
> 在 2021年3月17日，上午10:56，Zhang, Qi1 <qi1.zhang@intel.com> 写道：
>
> wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
> ---
> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
> index 2946f95db0..81a4d3fa6a 100644
> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
> @@ -710,9 +710,11 @@ SetConfigInfo (
> )
> {
> switch (TpmAlgHash) {
> +#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES
> case TPM_ALG_SHA1:
> Tcg2ConfigInfo->Sha1Supported = TRUE;
> break;
> +#endif
> case TPM_ALG_SHA256:
> Tcg2ConfigInfo->Sha256Supported = TRUE;
> break;
> --
> 2.26.2.windows.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 4:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-25 2:30 [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox Qi Zhang
-- strict thread matches above, loose matches on Subject: below --
2021-03-17 2:56 Qi Zhang
2021-03-17 4:19 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox