public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: [Patch v2][edk2-stable202011 1/4] .azurepipelines/templates/pr-gate-steps.yml: Fetch target branch
Date: Tue, 24 Nov 2020 21:07:55 -0800	[thread overview]
Message-ID: <20201125050758.1507-2-michael.d.kinney@intel.com> (raw)
In-Reply-To: <20201125050758.1507-1-michael.d.kinney@intel.com>

From: Sean Brogan <sean.brogan@microsoft.com>

Add step to fetch target branch so that PR_EVAL can resolve diff

Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .azurepipelines/templates/pr-gate-steps.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.azurepipelines/templates/pr-gate-steps.yml b/.azurepipelines/templates/pr-gate-steps.yml
index c1c0c04d6c17..70c19a462194 100644
--- a/.azurepipelines/templates/pr-gate-steps.yml
+++ b/.azurepipelines/templates/pr-gate-steps.yml
@@ -31,6 +31,12 @@ steps:
     echo "##vso[task.setvariable variable=pkgs_to_build]${{ parameters.build_pkgs }}"
     echo "##vso[task.setvariable variable=pkg_count]${{ 1 }}"
 
+# Fetch the target branch so that pr_eval can diff them.
+# Seems like azure pipelines/github changed checkout process in nov 2020.
+- script: git fetch origin $(System.PullRequest.targetBranch)
+  displayName: fetch target branch
+  condition: eq(variables['Build.Reason'], 'PullRequest')
+
 # trim the package list if this is a PR
 - task: CmdLine@1
   displayName: Check if ${{ parameters.build_pkgs }} need testing
-- 
2.29.2.windows.2


  reply	other threads:[~2020-11-25  5:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  5:07 [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures Michael D Kinney
2020-11-25  5:07 ` Michael D Kinney [this message]
2020-11-25  5:07 ` [Patch v2][edk2-stable202011 2/4] .azurepipelines/templates/platform-build-run-steps.yml: Fetch target branch Michael D Kinney
2020-11-25  5:07 ` [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU Michael D Kinney
2020-11-25  8:01   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-11-25 16:23     ` Michael D Kinney
2021-01-08  9:43       ` chocolatey.org instability [was: OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU] Laszlo Ersek
2020-11-25 14:11   ` [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU Laszlo Ersek
2020-11-25 14:57   ` [edk2-devel] " Rebecca Cran
2020-11-25 16:20     ` Michael D Kinney
2020-11-25 19:35       ` Rebecca Cran
2020-12-01  1:55         ` Michael D Kinney
2020-11-25  5:07 ` [Patch v2][edk2-stable202011 4/4] CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Fix MD5 Hash tests Michael D Kinney
2020-11-25  7:31   ` [edk2-devel] " Gao, Zhichao
2020-11-25 16:39     ` Michael D Kinney
2020-11-25  8:27   ` Yao, Jiewen
2020-11-25  5:11 ` [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures Michael D Kinney
2020-11-25  5:31   ` 回复: " gaoliming
2020-11-25 18:16     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125050758.1507-2-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox