From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.6476.1606310209287066853 for ; Wed, 25 Nov 2020 05:16:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=VtVyc0di; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id e7so1886417wrv.6 for ; Wed, 25 Nov 2020 05:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=E6LmWwzNxjZLFUak7XS6jhiq8bbInO66/d0EuqlVYNg=; b=VtVyc0disih5jMMJgQxErZu+S++x91TPC3FC3En5zHflFTXJU5ZLOfwsNVQ0IYy9MS B3Dj2GZb0U6n5kaiR0CqqwfaJnJgWZFm3FRP6roGgLb19URQXFhHVGsEGof+jv2cvhf0 ocDugeoxyU6PhTk/C6HmG6NYRcSCn/8bg81Nc0sD9c1MtYg7DLHsTIUHVniVGLP+aVVn igt30qemZfWmPtqms9xOx861GdsQlTMIFlXuZt0eeGetb5dQSjj6HmDAERXk7EI1Ml/U Dti37pm8ap3j9457FhwkDnRCpFVDKfiseTu15fnbqKfXrl323c04rO5ESgxYiwXsZavn oPOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=E6LmWwzNxjZLFUak7XS6jhiq8bbInO66/d0EuqlVYNg=; b=OufZVvpvEh+//Ix2JMmLA/T/yX3nwgBNgijDPMsXeAEU1+43kb9bP++sf6XouokTeC dE4mxW4l9IlszymMRHrJQ1FfjSwQrGiegTxG2VqNM6ftAho4gK/z5CCDWJGb+0VDEQ1p 3G0jfxtRNGxMBKzc28zM/ufS2zhYMOJL5xni7J9Q2ScOQWQa6fCIdx8hBvm6vg+lk6nL TZYw/WlTQj2rmYEsme8MbYUCz0thq5WmSJrzHgIT7n1HFCK9TIiLuNfqh8Ou0/XpjUpO bs4VhoKUvEDj3TzbItcUJ837UkTmYDim1Bws4PPqLsgR78OgWK0u29oGxaAMPdhsiFjp fjvw== X-Gm-Message-State: AOAM532VWGc0MWfmWJWVSlRh+DuQwMb4M3d4c/4m5vIRt54ETDEg0ePz +tHtiSlYJ/ndXjogVWhdKDIKcQ== X-Google-Smtp-Source: ABdhPJyMuAPGpZa2Psz13M6P65s3cWoDD/1qkPeEEcMiTkso60N+k1UgvKPsz7fHPCwMOE7cZJfJVw== X-Received: by 2002:a5d:634c:: with SMTP id b12mr4033190wrw.130.1606310207802; Wed, 25 Nov 2020 05:16:47 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id j8sm4775066wrx.11.2020.11.25.05.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 05:16:47 -0800 (PST) Date: Wed, 25 Nov 2020 13:16:45 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 14/15] Platform/SocioNext: add VariablePolicy resolutions Message-ID: <20201125131645.GR1664@vanye> References: <20201125125559.11631-1-leif@nuviainc.com> <20201125125559.11631-15-leif@nuviainc.com> <5b19eff6-6408-fb5a-7017-e94db9cfeb4a@arm.com> MIME-Version: 1.0 In-Reply-To: <5b19eff6-6408-fb5a-7017-e94db9cfeb4a@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 25, 2020 at 14:11:00 +0100, Ard Biesheuvel wrote: > On 11/25/20 1:55 PM, Leif Lindholm wrote: > > Add resolutions for > > - VariablePolicyLib > > - VariablePolicyHelperLib > > - VariablePolicyLib (DXE_RUNTIME_DRIVER) > > to DeveloperBox platform. > > > > Cc: Ard Biesheuvel > > Signed-off-by: Leif Lindholm > > Does this unbreak the build of DeveloperBoxMm.dsc as well? No. I was unsure of that being pretty much our reference for secure variable handling, just cargo culting a fix in place was the correct course of action. > If not, we should > probably drop some of these into the .dsc.in file instead. Unless the above is an issue, sure. / Leif > > --- > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > index a459079b1f26..c79792eef0aa 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > @@ -127,6 +127,7 @@ [LibraryClasses.common.UEFI_APPLICATION] > > # UiApp dependencies > > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > > @@ -143,6 +144,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > !endif > > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > [LibraryClasses.ARM] > > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > @@ -366,6 +368,7 @@ [Components.common] > > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > } > > !else > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf { > > >