From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.6549.1606310406205880588 for ; Wed, 25 Nov 2020 05:20:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=d9DalDBW; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id e7so1896616wrv.6 for ; Wed, 25 Nov 2020 05:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7vwadOupBAWKYO1fQpnEhw/WR1VUBFMcMwD8v4PeKws=; b=d9DalDBW/RBZN3qsK2GzrcIB5Xgtw+hJ0sWjXMi2GlBnE2hHKqhByEFux7np3Xn0+X oJHH99fFW1DoXFjZfeoJ/jO1uQHP52QmorGIK2zabacwbpFcW7u2MZuCTGcyRXKwGkMg cMygTuL+8/vbV2wP0AlFc5BVX4bJKxuFWGkwPAEzSRAvMrkFeh3HiLF51ygsn4J6Ufyr /MV3DufZLEJJdMojiBH6grru6u+cExYfZhI/m5jbTII4jBUwm8gCTno67d1WPg29G5+e JXqnyeCueov7haNCik5Q0q7mUgWSk8du3zNE/UcwdAm/kWgtmYLVirDQ5W7tYUkgRMVg d3mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7vwadOupBAWKYO1fQpnEhw/WR1VUBFMcMwD8v4PeKws=; b=FU38gG2VmXx+ut4DzQFzeY+X8PLPWqjrlT27HW6XzQaLqSe+w77251C65//kQsmG+k cBkCuFmFAXCAw6JwD34kUVrv7tXLNBXzTU5ya7B82jDMC1nbs7+o7lrTe1R+ZpA0DkHt joEWE+YS6AVqeyTpNJ2yxU3LCaX0XJKYxiQi1RRiu6b7zgdXmnaGI6tHxgxGg+XjvhqA zYUwiHA1Dl+8RJztRLA42ttfVu10R/wrgufsoBqzXAs/cEjN87YUSsf4Yu0VAeMR/Oqs cfySw6VIZ2hvXapw1vyMqWOuamJ7Dh4Ir5929LtZ5dW53e1CTKzHPQZpBmFvtcRRLlIp LA3g== X-Gm-Message-State: AOAM5309rxUCXgzfvwJbJzrtjzRy/olGJ7IKVH+0oXhypobAdTnl+THW OUM9koef0O/rpMAc26wGTSZIFw== X-Google-Smtp-Source: ABdhPJwpYYdcQ7sXu5mPxNo1BuzpdAHlcSe6tWHB6i8XTyQqZQsFOWqDPt1Qpjt4NViQ857Yvudl6w== X-Received: by 2002:adf:f102:: with SMTP id r2mr4111036wro.315.1606310404835; Wed, 25 Nov 2020 05:20:04 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id u23sm4481612wmc.32.2020.11.25.05.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 05:20:04 -0800 (PST) Date: Wed, 25 Nov 2020 13:20:02 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 02/15] Platform/AMD: add RngLib for Overdriveboard Message-ID: <20201125132002.GS1664@vanye> References: <20201125125559.11631-1-leif@nuviainc.com> <20201125125559.11631-3-leif@nuviainc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 25, 2020 at 14:09:00 +0100, Ard Biesheuvel wrote: > On 11/25/20 1:55 PM, Leif Lindholm wrote: > > OpenSSL now requires an RngLib. Add the generic > > MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > to fix Overdrive build. > > > > Cc: Ard Biesheuvel > > Signed-off-by: Leif Lindholm > > --- > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > index 5a38b9dd96ae..bf4d6dd7b804 100644 > > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > @@ -119,6 +119,7 @@ [LibraryClasses.common] > > PlatformFlashAccessLib|Silicon/AMD/Styx/Library/StyxPlatformFlashAccessLib/StyxPlatformFlashAccessLib.inf > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > > Could we use DxeRngLib here? That will be backed by the h/w RNG instead of > the cycle counter. You mean since we have EFI_RNG_PROTOCOL from StyxRngDxe? Good point, had forgotten about that. OK to fold in before pushing? / Leif