public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Wenyi Xie <xiewenyi2@huawei.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com, philmd@redhat.com,
	michael.d.kinney@intel.com, lersek@redhat.com,
	songdongkuang@huawei.com
Subject: Re: [EXTERNAL] [PATCH edk2-Platform v3 0/1] Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one
Date: Wed, 25 Nov 2020 14:26:52 +0000	[thread overview]
Message-ID: <20201125142652.GT1664@vanye> (raw)
In-Reply-To: <1599641549-25821-1-git-send-email-xiewenyi2@huawei.com>

I am sorry, I managed to misfile this set.

On Wed, Sep 09, 2020 at 16:52:28 +0800, Wenyi Xie wrote:
> Main Changes since v2:
> Adding ASSERT_EFI_ERROR() to check the return code from
> UnicodeStrToAsciiStrS.

Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as f37e98bfc00d.

However, the build still fails (for all of d03, d05, d06) due to
missing symbols in binary modules in edk2-non-osi.

Can you fix and post updated binaries required?
Please generate patches with --no-binary and include a link to a
repository which I can pick the commits directly from.

/
    Leif

> Wenyi Xie (1):
>   Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one
> 
>  Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c                          |  3 ++-
>  Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.c                       | 18 +++++++++++------
>  Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 | 21 +++++++++++++-------
>  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            |  9 ++++++---
>  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    | 18 +++++++++++------
>  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 18 +++++++++++------
>  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c   | 15 +++++++++-----
>  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c |  3 ++-
>  8 files changed, 70 insertions(+), 35 deletions(-)
> 
> -- 
> 2.20.1.windows.1
> 

  parent reply	other threads:[~2020-11-25 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  8:52 [PATCH edk2-Platform v3 0/1] Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one wenyi,xie
2020-09-09  8:52 ` [PATCH edk2-Platform v3 1/1] " wenyi,xie
2020-11-25 14:26 ` Leif Lindholm [this message]
2020-11-26 10:42   ` [EXTERNAL] [PATCH edk2-Platform v3 0/1] " wenyi,xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125142652.GT1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox