From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.7383.1606314416272264930 for ; Wed, 25 Nov 2020 06:26:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=PsOzkolY; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id w24so2342090wmi.0 for ; Wed, 25 Nov 2020 06:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZZ+9HpbaTsYXrFaELEO3Sm7WYxnpX62NNv/JY0mBy1U=; b=PsOzkolY5U7cdOMw8qEJ+8ySICe7GmYscbibtSMknuQyfq9rIfTv2sHgIIw5fCdaYq n7d2guxQ0Vg9moPo6np8ZrIZEo+l82f1yzRrGCY1VJCvkZ40Rkicnb0MBMBfVVY8X3Zy OFuB+X6vWkis0Khwzuy0WNBvk9yUO1bjilCHQnbUWVS8OU/XomqauIWpVeNGtKhFuBqd qdQjREdb09N+9S6pfx/xZPR+b85hjE5HABLuZTV7Vh+pT4U4UuI9w4Z+6qEU4rA6x8QK hQQA8epBnufuhfpeem6lQ7P8CTGVr2ktzWc0s3zlle9T8eHB/6l6U9EMSa7C0HDhe392 EU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZZ+9HpbaTsYXrFaELEO3Sm7WYxnpX62NNv/JY0mBy1U=; b=qJlNPb4QVqVOMJZ6fmGHEPOX6KbfaUMMww6ud+WQ7U+9I8Tj7Xcpmba6oAa/FCazGb 3iUOzkLE9xB1buyGQNaTwZkPHOaGVYY3uxYtrIKpPa+STUgAb4VA13dY0y7zJCpqTkJd pi5NIiDj0tsLG7IUaRHwAtGB92YVLHvHSW33wdGlsl/hWTUUcjXDrAv/ZP26Dgc2VvyQ minT4x51T8MKFDSa2W1TY0Srb3TU7419X8n9lkguccStgdpfYLMQTCiYSZm87M3U+R9m SVb+ckYItAir31lE4TyfDWBute7pEThp49eLs/bKAzgATTo5McT3W39LAElEgSimUlkr EBVw== X-Gm-Message-State: AOAM533QN49TMi2M3fLiQ+vkSY1h3geWjbTjCRpLvpxlEW9wC82j2vo5 XlONhk8fjqNXdRhC8X/bJ+0ndA== X-Google-Smtp-Source: ABdhPJxygHcOkJXMNbizHD/bXjKIzGxbBGfW6xWooM3VD0RZHzi55c5/DSpop1OyJ/D3eS+A7UsXXQ== X-Received: by 2002:a05:600c:2306:: with SMTP id 6mr4252576wmo.140.1606314414897; Wed, 25 Nov 2020 06:26:54 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id w1sm4545745wmi.24.2020.11.25.06.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 06:26:54 -0800 (PST) Date: Wed, 25 Nov 2020 14:26:52 +0000 From: "Leif Lindholm" To: Wenyi Xie Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com, philmd@redhat.com, michael.d.kinney@intel.com, lersek@redhat.com, songdongkuang@huawei.com Subject: Re: [EXTERNAL] [PATCH edk2-Platform v3 0/1] Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one Message-ID: <20201125142652.GT1664@vanye> References: <1599641549-25821-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 In-Reply-To: <1599641549-25821-1-git-send-email-xiewenyi2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I am sorry, I managed to misfile this set. On Wed, Sep 09, 2020 at 16:52:28 +0800, Wenyi Xie wrote: > Main Changes since v2: > Adding ASSERT_EFI_ERROR() to check the return code from > UnicodeStrToAsciiStrS. Reviewed-by: Leif Lindholm Pushed as f37e98bfc00d. However, the build still fails (for all of d03, d05, d06) due to missing symbols in binary modules in edk2-non-osi. Can you fix and post updated binaries required? Please generate patches with --no-binary and include a link to a repository which I can pick the commits directly from. / Leif > Wenyi Xie (1): > Hisilicon/Smbios: Replace DEPRECATED code with S-suffixed one > > Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 3 ++- > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.c | 18 +++++++++++------ > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 21 +++++++++++++------- > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 9 ++++++--- > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 18 +++++++++++------ > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 18 +++++++++++------ > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 15 +++++++++----- > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c | 3 ++- > 8 files changed, 70 insertions(+), 35 deletions(-) > > -- > 2.20.1.windows.1 >