public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
	Andrei Warkentin <awarkentin@vmware.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: RPi4 PMU interrupts are SPI not PPI
Date: Wed, 25 Nov 2020 10:11:08 -0500	[thread overview]
Message-ID: <20201125151108.21507-1-Samer.El-Haj-Mahmoud@arm.com> (raw)

REF: https://github.com/pftf/RPi4/issues/103

Commit 602a7ea1ab6d changed the RPi4 PMU interrupts reported
in GICC to the PPI values recommended by SBSA specification.
This caused the PMU overflow interrupts to stop working.

The RPi documentation (Figure 7, page 111) state that the
PMU interrupts are SPI not PPI: https://www.raspberrypi.org/
documentation/hardware/raspberrypi/bcm2711/rpi_DATA_2711_1p0.pdf

Also, the BSA 1.0 spec (page 24) clarifies hat the PPI values are
recommendations, not requirements:
https://developer.arm.com/documentation/den0094/latest

Fix by reverting to the old SPI values per the RPi spec.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 4e5a36edb76a..ddf4dd6a416e 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -440,10 +440,10 @@ [PcdsFixedAtBuild.common]
   gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceHBase|0xFF844000
   gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceVBase|0xFF846000
   gRaspberryPiTokenSpaceGuid.PcdGicGsivId|0x19
-  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|23
-  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|23
-  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|23
-  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|23
+  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|0x30
+  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|0x31
+  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|0x32
+  gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|0x33
 
   #
   # Fixed CPU settings.
-- 
2.25.1


             reply	other threads:[~2020-11-25 15:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 15:11 Samer El-Haj-Mahmoud [this message]
2020-11-25 15:18 ` [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: RPi4 PMU interrupts are SPI not PPI Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125151108.21507-1-Samer.El-Haj-Mahmoud@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox