From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.7996.1606317077727176271 for ; Wed, 25 Nov 2020 07:11:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: samer.el-haj-mahmoud@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 667E8106F; Wed, 25 Nov 2020 07:11:17 -0800 (PST) Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FE053F70D; Wed, 25 Nov 2020 07:11:17 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Pete Batard , Andrei Warkentin , Ard Biesheuvel Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: RPi4 PMU interrupts are SPI not PPI Date: Wed, 25 Nov 2020 10:11:08 -0500 Message-Id: <20201125151108.21507-1-Samer.El-Haj-Mahmoud@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://github.com/pftf/RPi4/issues/103 Commit 602a7ea1ab6d changed the RPi4 PMU interrupts reported in GICC to the PPI values recommended by SBSA specification. This caused the PMU overflow interrupts to stop working. The RPi documentation (Figure 7, page 111) state that the PMU interrupts are SPI not PPI: https://www.raspberrypi.org/ documentation/hardware/raspberrypi/bcm2711/rpi_DATA_2711_1p0.pdf Also, the BSA 1.0 spec (page 24) clarifies hat the PPI values are recommendations, not requirements: https://developer.arm.com/documentation/den0094/latest Fix by reverting to the old SPI values per the RPi spec. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index 4e5a36edb76a..ddf4dd6a416e 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -440,10 +440,10 @@ [PcdsFixedAtBuild.common] gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceHBase|0xFF844000=0D gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterfaceVBase|0xFF846000=0D gRaspberryPiTokenSpaceGuid.PcdGicGsivId|0x19=0D - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|23=0D - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|23=0D - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|23=0D - gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|23=0D + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|0x30=0D + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|0x31=0D + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|0x32=0D + gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|0x33=0D =0D #=0D # Fixed CPU settings.=0D --=20 2.25.1