From: "Heinrich Schuchardt" <xypron.glpk@gmx.de>
To: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: EDK II Development <devel@edk2.groups.io>,
Eric Jin <eric.jin@intel.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: build failure DevicePathToText test
Date: Wed, 25 Nov 2020 20:12:48 +0100 [thread overview]
Message-ID: <20201125191248.9381-1-xypron.glpk@gmx.de> (raw)
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3029
After commit 75c92b85bf9b ("uefi-sct/SctPkg: NULL deref in DevicePathToText
test") a build failure was observed.
Length is a field in MEDIA_OFFSET_DEVICE_PATH.Header and not in
MEDIA_OFFSET_DEVICE_PATH itself.
Fixes: 75c92b85bf9b ("uefi-sct/SctPkg: NULL deref in DevicePathToText test")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
.../BlackBoxTest/DevicePathToTextBBTestCoverage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c
index eb77c3564e95..e83d570662c2 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c
@@ -1200,7 +1200,7 @@ DevicePathToTextConvertDeviceNodeToTextCoverageTest (
pDeviceNode2 = SctConvertTextToDeviceNode(Text);
SctPrint(L"pDeviceNode2 = %p\n", pDeviceNode2);
if (pDeviceNode2 &&
- ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Length ==
+ ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Header.Length ==
sizeof(MEDIA_OFFSET_DEVICE_PATH)) {
((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Reserved = 0;
}
--
2.29.2
next reply other threads:[~2020-11-25 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 19:12 Heinrich Schuchardt [this message]
2020-11-30 12:59 ` [PATCH edk2-test 1/1] uefi-sct/SctPkg: build failure DevicePathToText test G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125191248.9381-1-xypron.glpk@gmx.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox