From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by mx.groups.io with SMTP id smtpd.web11.858.1606331616705316360 for ; Wed, 25 Nov 2020 11:13:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=N0dHYKOC; spf=pass (domain: gmx.de, ip: 212.227.15.19, mailfrom: xypron.glpk@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606331590; bh=WP6KmfmFXHoY4U18PD9ilvu7Q4XT+qlTlPi6FJOnV7Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=N0dHYKOC7H2Xbk8TZ1Vup8krZmky3kEWokozrtL4DFmTrBgxoXmvImkmsSFoByiFp eAB52nA1/XVC8PCjtoaFZ62fUXbrp9AKNjPbhcndBEY25X8NTU7dJx94ZYrgExzzm7 Ww+VXyGfIuwwUhw1a0pa34jPhscta78Pp7tVFI3w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MKKUv-1kw5Mo3whL-00LjgK; Wed, 25 Nov 2020 20:13:10 +0100 From: "Heinrich Schuchardt" To: G Edhaya Chandran Cc: EDK II Development , Eric Jin , Samer El-Haj-Mahmoud , Barton Gao , Heinrich Schuchardt Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: build failure DevicePathToText test Date: Wed, 25 Nov 2020 20:12:48 +0100 Message-Id: <20201125191248.9381-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:ugJN/1fzsmGMiXDoaY7QS3URPHb5gS8lEWPBu8OejgkztldNyMW CFtONs49j0ON/9Sts5CK/B5BWFkOxRF7zmqbmCc7z1lB3oBSfcOjPmGdJlZ0dz4FFK+Lbm7 GyxhwqnCIFwoc9Altl6jyp+65sd62PLEQLlsOaYKkMKZj6C7EKHoacOMRYEVu52fM2jWdPF 3bgHM84Tiff3NWjdbQnxw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:92ejZ4Xlwhw=:O/ZtY6AEOScVvrdoho5nQT q5hlv3OYRmkjwrovGnjn3PTDfTGmJUB/Lpa1zAFE0TKSmhxPlqNO8MzLB8fOMQiFf23p8rX4+ TEhRp7/aMDwBvrUBXOQNX4z6B0FXBSwoegvUHOKQZNw2svhTEowNG2vNIZODohfLDoWc7AA++ sroa8ifBDTkGoRoR3fZLamKklkxn29m6+ybb+2gFfroP2nl3JP1iRADkHcj5l6ipSwNGIn7Jb tI/db9HlZtfcsByIet8mXXCTbuPk9A3i89dPpSGXM6SNnbhj5uKp7tv8oZWzSNSYsJUBfnA/j f4lJ50v/6AiJpGQuQ+6fn+RdcqLV5OlZ2QG/CwjvxnpR6vLXO9VhkM6k4YagI9BB0x9FM5E1j t8CSKJVtJglM8sHfnWh/VSu6/vw7xGJe5+bLma+mGzWLUmLrBMw10+SaZGvMPshlK29NHJjYg 4GWH/QTwfng5ystpcFK3PO45RjQK0c3hGnm8EF3f8lK9rc5JP822LfZFnRvm29rpBIdmekyUC vYtvbEb2igoaJGJfpFfDYDKJXuD0VdO8o8SjzErMvsIUIlG/BeEc5xYUaElpk5SaqO6JT5XgV KujMuyhpbBMPL1F8vhFH1hiq+aTEfvap5jV3UVOI9E+glt3E647gWz3kTS13HPf+Abz7YJh0d 1JCA0mvGbrhLbo3OZc/jSjJjTOphDCjv8bCmAJHvGNw363Uh8qg2px5JY1nvexQqCrIzeYSAm d/WY0VsuTai2WnHBi+s1U+4KBZCK2QOJ718C88nN3nFW6d5pSrW+m5IyuLWGBg8hf2P0pnwcS GVZpEdeEgTja2DnOf5jKaf/W9G9jliaHejtgVQcLHe+apeLXA7y2PhgGiFeLBi8+9kCb6I5pd vXBlu1rorp1CRD/Qs0uw== Content-Transfer-Encoding: quoted-printable Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3029 After commit 75c92b85bf9b ("uefi-sct/SctPkg: NULL deref in DevicePathToText test") a build failure was observed. Length is a field in MEDIA_OFFSET_DEVICE_PATH.Header and not in MEDIA_OFFSET_DEVICE_PATH itself. Fixes: 75c92b85bf9b ("uefi-sct/SctPkg: NULL deref in DevicePathToText test") Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/DevicePathToTextBBTestCoverage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/Bl= ackBoxTest/DevicePathToTextBBTestCoverage.c b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c index eb77c3564e95..e83d570662c2 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxT= est/DevicePathToTextBBTestCoverage.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxT= est/DevicePathToTextBBTestCoverage.c @@ -1200,7 +1200,7 @@ DevicePathToTextConvertDeviceNodeToTextCoverageTest ( pDeviceNode2 =3D SctConvertTextToDeviceNode(Text);=0D SctPrint(L"pDeviceNode2 =3D %p\n", pDeviceNode2); if (pDeviceNode2 && - ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Length =3D=3D + ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Header.Length =3D=3D sizeof(MEDIA_OFFSET_DEVICE_PATH)) { ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Reserved =3D 0; } --=20 2.29.2