Re: [PATCH edk2-platforms 00/15] arm platform fixes triggered by VariablePolicy

["Leif Lindholm" <leif@nuviainc.com>]

On Thu, Nov 26, 2020 at 18:44:55 +0800, xiewenyi (A) wrote:
> 
> 
> On 2020/11/25 21:11, Leif Lindholm wrote:
> > On Wed, Nov 25, 2020 at 12:55:44 +0000, Leif Lindholm wrote:
> >> The recently merged VariablePolicy set in edk2,
> >> d448574e7310..124b3f9289f1, broke everything[tm].
> >> Fix up the ARM platforms I have any sort of history about,
> >> including some unrelated things that popped up along the way.
> >>
> >> Note: the hisilicon server platforms still don't build due to use
> >> of now deleted (previously deprecated) string functions in
> >> the SMBIOS code. Rebecca Cran has been sending out a genericised
> >> set *based* on this code, but now fixed. If Hisilicon could look
> >> into making use of that version instead, that might be less hassle
> >> than fixing the current implementation:
> >> https://edk2.groups.io/g/devel/message/67255
> > 
> > Double-whoops on the Hisilicon patches:
> > 1) Ming Huang bounces.
> > 2) I have a misfiled v3 of a set to deal with the above in my inbox
> >    from Wenyi Xie <xiewenyi2@huawei.com>
> > Adding them to this posting.
> > 
> > Wenyi - could you add an entry or entries to Maintainers.txt for the
> > Hisilicon platforms?
> > 
> May I ask what does entry mean, I don't understand.

Maintainers.txt defines several sections, describing who should be
Cc:d on patches to different parts of the source tree.

Ah, now that I look, I see we already have:
HiSilicon
F: Platform/Hisilicon/
F: Silicon/Hisilicon/
M: Leif Lindholm <leif@nuviainc.com>
R: Ard Biesheuvel <ard.biesheuvel@arm.com>

However, it would be very useful to have someone from Hisilicon/Huawei
to help out with reviewing patches to the Hisilicon platforms.
And if the mobile/server platforms should have different reviewers, it
would be useful to reflect that as well.
At a minimum, could you send a patch adding yourself as a reviewer (R:
) to the existing Hisilicon section?

Best Regards,

Leif

> Thanks
> Wenyi
> 
> > Best Regards,
> > 
> > Leif
> > 
> >> Cc: Abner Chang <abner.chang@hpe.com>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >> Cc: Bret Barkelew <brbarkel@microsoft.com>
> >> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> >> Cc: Graeme Gregory <graeme@nuviainc.com>
> >> Cc: Marcin Wojtas <mw@semihalf.com>
> >> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> >> Cc: Ming Huang <huangming23@huawei.com>
> >> Cc: Radoslaw Biernacki <rad@semihalf.com>
> >> Cc: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> >> Cc: Thomas Abraham <thomas.abraham@arm.com>
> >>
> >> Leif Lindholm (15):
> >>   Silicon/AMD: update Styx to use PcdSet*S APIs
> >>   Platform/AMD: add RngLib for Overdriveboard
> >>   Platform,Silicon: fix beagleboard tautological compares
> >>   Silicon/Hisilicon: add RngLib for Hisilicon
> >>   Platform/ARM: VExpressPkg fixes to work with new VariablePolicyLib
> >>   Platform/AMD: add VariablePolicy library resolutions for Overdrive
> >>   Platform/SoftIron: add VariablePolicy resolutions for Overdrive1000
> >>   Platform/LeMaker: add VariablePolicy resolutions for cello
> >>   Platform/SiFive: add VariablePolicy resolutions
> >>   Platform/Qemu: add VariablePolicy resolutions
> >>   Silicon/Marvell: add VariablePolicy resolutions
> >>   Platform/BeagleBoard: add VariablePolicy resolutions
> >>   Silicon/NXP: add VariablePolicy resolutions
> >>   Platform/SocioNext: add VariablePolicy resolutions
> >>   Silicon/Hisilicon: add VariablePolicy resolutions
> >>
> >>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc  |  1 +
> >>  Silicon/Hisilicon/Hisilicon.dsc.inc           |  4 ++++
> >>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc |  5 ++++-
> >>  Silicon/NXP/NxpQoriqLs.dsc.inc                |  4 ++++
> >>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     |  4 ++++
> >>  .../BeagleBoardPkg/BeagleBoardPkg.dsc         |  4 ++++
> >>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    |  4 ++++
> >>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc           |  3 +++
> >>  .../FreedomU500VC707Board/U500.dsc            |  4 ++++
> >>  .../FreedomU540HiFiveUnleashedBoard/U540.dsc  |  4 ++++
> >>  .../Socionext/DeveloperBox/DeveloperBox.dsc   |  3 +++
> >>  .../Overdrive1000Board/Overdrive1000Board.dsc |  4 ++++
> >>  .../Library/ResetSystemLib/ResetSystemLib.c   |  2 +-
> >>  .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 11 ++++++----
> >>  .../Library/MemoryInitPei/MemoryInitPeiLib.c  | 20 +++++++++++--------
> >>  .../Omap35xxPkg/SmbusDxe/Smbus.c              |  2 +-
> >>  16 files changed, 64 insertions(+), 15 deletions(-)
> >>
> >> -- 
> >> 2.20.1
> >>
> > .
> >