From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web08.4868.1606397496254219139 for ; Thu, 26 Nov 2020 05:31:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=If/hxW6a; spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f68.google.com with SMTP id 23so2152158wrc.8 for ; Thu, 26 Nov 2020 05:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zPqt4aGO0VRCOcH1488jVRhtpyQo4gf1FKzNFWSXkp0=; b=If/hxW6aKiBchzWdFyJ89/c0t/WJrlOQCIaEkOCFhao3+RHQMD2dvlAN6f8dqg53fb 4whzhlvz6eXgHvYGkS4BJIz/vLdu65PB/xSD6JpTTZtonBfA0YsyOoUJA1rxX2IexKa0 4v4mHOTir+1/ZkEndIn7u1fYy8kjYFhvZDWlz6/TgulroWVj3b2aEqwP2tPpXOAc7MOS 27kDpwHDW0oMmXxi8OC7ap/RTQWzYCtgBEZ+zqePkBN9DePmDXvZkasQ/3dVmr2okauL buVBhv96dMWtafuiMo/2gcbqiKJ1wxk9TQ2pHd1z4OEbpG0oC9Wys1lbzV41ANHbIHNS 2eQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zPqt4aGO0VRCOcH1488jVRhtpyQo4gf1FKzNFWSXkp0=; b=mbgFJPiOwIA2Mvnh97b4yGJspahzbxJG/K+KxCzGymzzU+SmmDwecnMY6IHiM/npjX ZrV86GqL/KJbtkiE57MvIdUoXTZaTf/ySSAlyge1pziYAmGSrZGWvrQuPIoWISdYFpoS pOJ76jjV3iQWw4qyqeYcHXVfDzLQvI2hziKGoGdR++VGEcQRpYfLaIDKsIDXY0aP9/Z/ TfPLF1Qy9PAo0FBbGBK65x13KoEUWFz0FD4zK0Iw992Dy5agRz1BkaW/BwmHMudAzYsu B/QibqTlaFui4Hxs6V1Eb82gfAPDH/JzZAOUS5hl4uQ0gJXb536yT9D+O/uT9WXXvz3n IrbA== X-Gm-Message-State: AOAM5326W3B8qdBjHIDCI0BJgDztpbSZu1BoRdNtMrqb0X3VMdAE9w4h BgeXIkeLjWCPPQj/ZGiNw12tpw== X-Google-Smtp-Source: ABdhPJx7MgKkIRyyMhadLrAwnI9WnqGaIhB6akvIQHeUK6dJCAVs+F5up6jDPV76QUWwvkBksJiLew== X-Received: by 2002:adf:e387:: with SMTP id e7mr3789008wrm.177.1606397494856; Thu, 26 Nov 2020 05:31:34 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id d8sm9059177wrp.44.2020.11.26.05.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:31:34 -0800 (PST) Date: Thu, 26 Nov 2020 13:31:32 +0000 From: "Leif Lindholm" To: "xiewenyi (A)" Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 00/15] arm platform fixes triggered by VariablePolicy Message-ID: <20201126133132.GW1664@vanye> References: <20201125125559.11631-1-leif@nuviainc.com> <20201125131154.GO1664@vanye> <0c7aa9c4-0367-f168-fc55-e8723cacdf57@huawei.com> MIME-Version: 1.0 In-Reply-To: <0c7aa9c4-0367-f168-fc55-e8723cacdf57@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 26, 2020 at 18:44:55 +0800, xiewenyi (A) wrote: > > > On 2020/11/25 21:11, Leif Lindholm wrote: > > On Wed, Nov 25, 2020 at 12:55:44 +0000, Leif Lindholm wrote: > >> The recently merged VariablePolicy set in edk2, > >> d448574e7310..124b3f9289f1, broke everything[tm]. > >> Fix up the ARM platforms I have any sort of history about, > >> including some unrelated things that popped up along the way. > >> > >> Note: the hisilicon server platforms still don't build due to use > >> of now deleted (previously deprecated) string functions in > >> the SMBIOS code. Rebecca Cran has been sending out a genericised > >> set *based* on this code, but now fixed. If Hisilicon could look > >> into making use of that version instead, that might be less hassle > >> than fixing the current implementation: > >> https://edk2.groups.io/g/devel/message/67255 > > > > Double-whoops on the Hisilicon patches: > > 1) Ming Huang bounces. > > 2) I have a misfiled v3 of a set to deal with the above in my inbox > > from Wenyi Xie > > Adding them to this posting. > > > > Wenyi - could you add an entry or entries to Maintainers.txt for the > > Hisilicon platforms? > > > May I ask what does entry mean, I don't understand. Maintainers.txt defines several sections, describing who should be Cc:d on patches to different parts of the source tree. Ah, now that I look, I see we already have: HiSilicon F: Platform/Hisilicon/ F: Silicon/Hisilicon/ M: Leif Lindholm R: Ard Biesheuvel However, it would be very useful to have someone from Hisilicon/Huawei to help out with reviewing patches to the Hisilicon platforms. And if the mobile/server platforms should have different reviewers, it would be useful to reflect that as well. At a minimum, could you send a patch adding yourself as a reviewer (R: ) to the existing Hisilicon section? Best Regards, Leif > Thanks > Wenyi > > > Best Regards, > > > > Leif > > > >> Cc: Abner Chang > >> Cc: Ard Biesheuvel > >> Cc: Bret Barkelew > >> Cc: Daniel Schaefer > >> Cc: Graeme Gregory > >> Cc: Marcin Wojtas > >> Cc: Meenakshi Aggarwal > >> Cc: Ming Huang > >> Cc: Radoslaw Biernacki > >> Cc: Tanmay Jagdale > >> Cc: Thomas Abraham > >> > >> Leif Lindholm (15): > >> Silicon/AMD: update Styx to use PcdSet*S APIs > >> Platform/AMD: add RngLib for Overdriveboard > >> Platform,Silicon: fix beagleboard tautological compares > >> Silicon/Hisilicon: add RngLib for Hisilicon > >> Platform/ARM: VExpressPkg fixes to work with new VariablePolicyLib > >> Platform/AMD: add VariablePolicy library resolutions for Overdrive > >> Platform/SoftIron: add VariablePolicy resolutions for Overdrive1000 > >> Platform/LeMaker: add VariablePolicy resolutions for cello > >> Platform/SiFive: add VariablePolicy resolutions > >> Platform/Qemu: add VariablePolicy resolutions > >> Silicon/Marvell: add VariablePolicy resolutions > >> Platform/BeagleBoard: add VariablePolicy resolutions > >> Silicon/NXP: add VariablePolicy resolutions > >> Platform/SocioNext: add VariablePolicy resolutions > >> Silicon/Hisilicon: add VariablePolicy resolutions > >> > >> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > >> Silicon/Hisilicon/Hisilicon.dsc.inc | 4 ++++ > >> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 5 ++++- > >> Silicon/NXP/NxpQoriqLs.dsc.inc | 4 ++++ > >> .../AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++++ > >> .../BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++++ > >> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 ++++ > >> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++ > >> .../FreedomU500VC707Board/U500.dsc | 4 ++++ > >> .../FreedomU540HiFiveUnleashedBoard/U540.dsc | 4 ++++ > >> .../Socionext/DeveloperBox/DeveloperBox.dsc | 3 +++ > >> .../Overdrive1000Board/Overdrive1000Board.dsc | 4 ++++ > >> .../Library/ResetSystemLib/ResetSystemLib.c | 2 +- > >> .../Styx/Drivers/PlatInitPei/PlatInitPei.c | 11 ++++++---- > >> .../Library/MemoryInitPei/MemoryInitPeiLib.c | 20 +++++++++++-------- > >> .../Omap35xxPkg/SmbusDxe/Smbus.c | 2 +- > >> 16 files changed, 64 insertions(+), 15 deletions(-) > >> > >> -- > >> 2.20.1 > >> > > . > >