From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size
Date: Thu, 26 Nov 2020 16:22:48 +0000 [thread overview]
Message-ID: <20201126162248.GX1664@vanye> (raw)
In-Reply-To: <20201126154046.6841-1-ard.biesheuvel@arm.com>
On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote:
> Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
> build no longer fits when built in DEBUG or NOOPT mode. So increase
> the FD size a little bit - we still have some spare room available in
> the FIP image.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
I will push this with (after) the VariablePolicy set since the problem
doesn't actually trigger until then.
/
Leif
> ---
> Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> index 83a3c4660cb3..58efed89b26e 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> @@ -21,12 +21,12 @@
>
> [FD.STANDALONE_MM]
> BaseAddress = 0xfc000000
> -Size = 0x00040000
> +Size = 0x00050000
> ErasePolarity = 1
>
> # This one is tricky, it must be: BlockSize * NumBlocks = Size
> BlockSize = 0x00010000
> -NumBlocks = 0x4
> +NumBlocks = 0x5
>
> ################################################################################
> #
> @@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
> #
> ################################################################################
>
> -0x00000000|0x00040000
> +0x00000000|0x00050000
> FV = FvStandaloneMmCompact
>
> ################################################################################
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-11-26 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 15:40 [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size Ard Biesheuvel
2020-11-26 16:22 ` Leif Lindholm [this message]
2020-11-27 11:50 ` Leif Lindholm
2020-11-27 11:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126162248.GX1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox