From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by mx.groups.io with SMTP id smtpd.web11.7420.1606407772493265949
 for <devel@edk2.groups.io>;
 Thu, 26 Nov 2020 08:22:52 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=LQ1SHZyK;
 spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com)
Received: by mail-wr1-f67.google.com with SMTP id k14so2758732wrn.1
        for <devel@edk2.groups.io>; Thu, 26 Nov 2020 08:22:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=L3gZFNRHAmuvQHbKpj2G+B3nkY2M6/jz+mMJoulokq0=;
        b=LQ1SHZyKHljFfOQ9XU0zwNZZqaiRi87E7JUiI8tpymfrFG245YiqQKIN5qJMEOoAxd
         5QNQs8OzgWqgpICo9sRVXTWI6Vwiom5rwKe8ZQ3HI0Hg9eBaUOMzHyHo2Kb4L8G9/Ezz
         OPCiew40KbMXSa/dhBxirqL9mP+9Ij/T1d8qx0HfGKBuUtu1FOq0s+rIHXDgiJJguKum
         uE6BXGRhEtlGawJGZrb0oxPj5Ozf9+gmX5WmtviDcZsXKI3DYIhkTq7qXXUWe572TVHI
         xUKmPvLAwa5oWySdL2zBwcZN94hTGablxBeQ+BaN2pM8QMpOoStZNRrow7qylLSXOxNL
         h3iA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=L3gZFNRHAmuvQHbKpj2G+B3nkY2M6/jz+mMJoulokq0=;
        b=euTLeoSb7rU2UuqbcqSzOPh5l9TGqb6CXj+6MW1lJk9IqJkboUcdEiuiq9RY0OHuIo
         5eq7JnUdHhwt4DLGPcsYkeb5y5ia/+voQIO8DmY0jRc6n82lD0xrNOQ1vpc/IP4lTJ/p
         jAOHyj9qUjph3H++xjjOORCAOHpDtPdSj4qjKwgT+0MnZ3WOHP+d4gbrltI1vWAH7vrx
         IEYPsVCow2aSvaufkS5ClN5b3DHwJsvMtFU9+EgwLi2VyuKjSLDgn8OcwckpuxvIx2ub
         pC8qBhB+bs2Um5v2pmZzSouqDmw6WtHvSbRgD31yC/dDOZg9oc1hsFa12SC+OYHfRdNt
         K16Q==
X-Gm-Message-State: AOAM533r7F2mLZb/RRQ/j+jJLS87VAkpJOLGu5p8UkN8RrAkzj383eG9
	9aAVArUYxHeZd1zy+iUQlkEiQg==
X-Google-Smtp-Source: ABdhPJzpcyWQ+V7baqdG0yoHrvuxnj5g1GlWxMJGO5JiSBbEPOrU2BvZjKWEBEAqL/P3q09xop3ORw==
X-Received: by 2002:a5d:554a:: with SMTP id g10mr4927941wrw.253.1606407771096;
        Thu, 26 Nov 2020 08:22:51 -0800 (PST)
Return-Path: <leif@nuviainc.com>
Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148])
        by smtp.gmail.com with ESMTPSA id d16sm10555797wrw.17.2020.11.26.08.22.50
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 26 Nov 2020 08:22:50 -0800 (PST)
Date: Thu, 26 Nov 2020 16:22:48 +0000
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size
Message-ID: <20201126162248.GX1664@vanye>
References: <20201126154046.6841-1-ard.biesheuvel@arm.com>
MIME-Version: 1.0
In-Reply-To: <20201126154046.6841-1-ard.biesheuvel@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote:
> Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
> build no longer fits when built in DEBUG or NOOPT mode. So increase
> the FD size a little bit - we still have some spare room available in
> the FIP image.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

I will push this with (after) the VariablePolicy set since the problem
doesn't actually trigger until then.

/
    Leif

> ---
>  Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> index 83a3c4660cb3..58efed89b26e 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> @@ -21,12 +21,12 @@
>  
>  [FD.STANDALONE_MM]
>  BaseAddress   = 0xfc000000
> -Size          = 0x00040000
> +Size          = 0x00050000
>  ErasePolarity = 1
>  
>  # This one is tricky, it must be: BlockSize * NumBlocks = Size
>  BlockSize     = 0x00010000
> -NumBlocks     = 0x4
> +NumBlocks     = 0x5
>  
>  ################################################################################
>  #
> @@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
>  #
>  ################################################################################
>  
> -0x00000000|0x00040000
> +0x00000000|0x00050000
>  FV = FvStandaloneMmCompact
>  
>  ################################################################################
> -- 
> 2.17.1
>