Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size

["Leif Lindholm" <leif@nuviainc.com>]

On Thu, Nov 26, 2020 at 16:22:48 +0000, Leif Lindholm wrote:
> On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote:
> > Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
> > build no longer fits when built in DEBUG or NOOPT mode. So increase
> > the FD size a little bit - we still have some spare room available in
> > the FIP image.
> > 
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 
> I will push this with (after) the VariablePolicy set since the problem
> doesn't actually trigger until then.

Urgh. This fixes DEBUG, but in my setup NOOPT is still too big.
Would it be OK if I folded in an increase from 0x50000 to 0x60000
before pushing?

/
    Leif

> /
>     Leif
> 
> > ---
> >  Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> > index 83a3c4660cb3..58efed89b26e 100644
> > --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> > +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> > @@ -21,12 +21,12 @@
> >  
> >  [FD.STANDALONE_MM]
> >  BaseAddress   = 0xfc000000
> > -Size          = 0x00040000
> > +Size          = 0x00050000
> >  ErasePolarity = 1
> >  
> >  # This one is tricky, it must be: BlockSize * NumBlocks = Size
> >  BlockSize     = 0x00010000
> > -NumBlocks     = 0x4
> > +NumBlocks     = 0x5
> >  
> >  ################################################################################
> >  #
> > @@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
> >  #
> >  ################################################################################
> >  
> > -0x00000000|0x00040000
> > +0x00000000|0x00050000
> >  FV = FvStandaloneMmCompact
> >  
> >  ################################################################################
> > -- 
> > 2.17.1
> >