* [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size
@ 2020-11-26 15:40 Ard Biesheuvel
2020-11-26 16:22 ` Leif Lindholm
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2020-11-26 15:40 UTC (permalink / raw)
To: devel; +Cc: leif, Ard Biesheuvel
Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
build no longer fits when built in DEBUG or NOOPT mode. So increase
the FD size a little bit - we still have some spare room available in
the FIP image.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
index 83a3c4660cb3..58efed89b26e 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
+++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
@@ -21,12 +21,12 @@
[FD.STANDALONE_MM]
BaseAddress = 0xfc000000
-Size = 0x00040000
+Size = 0x00050000
ErasePolarity = 1
# This one is tricky, it must be: BlockSize * NumBlocks = Size
BlockSize = 0x00010000
-NumBlocks = 0x4
+NumBlocks = 0x5
################################################################################
#
@@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
#
################################################################################
-0x00000000|0x00040000
+0x00000000|0x00050000
FV = FvStandaloneMmCompact
################################################################################
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size
2020-11-26 15:40 [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size Ard Biesheuvel
@ 2020-11-26 16:22 ` Leif Lindholm
2020-11-27 11:50 ` Leif Lindholm
0 siblings, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2020-11-26 16:22 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote:
> Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
> build no longer fits when built in DEBUG or NOOPT mode. So increase
> the FD size a little bit - we still have some spare room available in
> the FIP image.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
I will push this with (after) the VariablePolicy set since the problem
doesn't actually trigger until then.
/
Leif
> ---
> Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> index 83a3c4660cb3..58efed89b26e 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> @@ -21,12 +21,12 @@
>
> [FD.STANDALONE_MM]
> BaseAddress = 0xfc000000
> -Size = 0x00040000
> +Size = 0x00050000
> ErasePolarity = 1
>
> # This one is tricky, it must be: BlockSize * NumBlocks = Size
> BlockSize = 0x00010000
> -NumBlocks = 0x4
> +NumBlocks = 0x5
>
> ################################################################################
> #
> @@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
> #
> ################################################################################
>
> -0x00000000|0x00040000
> +0x00000000|0x00050000
> FV = FvStandaloneMmCompact
>
> ################################################################################
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size
2020-11-26 16:22 ` Leif Lindholm
@ 2020-11-27 11:50 ` Leif Lindholm
2020-11-27 11:56 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2020-11-27 11:50 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Thu, Nov 26, 2020 at 16:22:48 +0000, Leif Lindholm wrote:
> On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote:
> > Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
> > build no longer fits when built in DEBUG or NOOPT mode. So increase
> > the FD size a little bit - we still have some spare room available in
> > the FIP image.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> I will push this with (after) the VariablePolicy set since the problem
> doesn't actually trigger until then.
Urgh. This fixes DEBUG, but in my setup NOOPT is still too big.
Would it be OK if I folded in an increase from 0x50000 to 0x60000
before pushing?
/
Leif
> /
> Leif
>
> > ---
> > Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> > index 83a3c4660cb3..58efed89b26e 100644
> > --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> > +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
> > @@ -21,12 +21,12 @@
> >
> > [FD.STANDALONE_MM]
> > BaseAddress = 0xfc000000
> > -Size = 0x00040000
> > +Size = 0x00050000
> > ErasePolarity = 1
> >
> > # This one is tricky, it must be: BlockSize * NumBlocks = Size
> > BlockSize = 0x00010000
> > -NumBlocks = 0x4
> > +NumBlocks = 0x5
> >
> > ################################################################################
> > #
> > @@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
> > #
> > ################################################################################
> >
> > -0x00000000|0x00040000
> > +0x00000000|0x00050000
> > FV = FvStandaloneMmCompact
> >
> > ################################################################################
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size
2020-11-27 11:50 ` Leif Lindholm
@ 2020-11-27 11:56 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-11-27 11:56 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel
On 11/27/20 12:50 PM, Leif Lindholm wrote:
> On Thu, Nov 26, 2020 at 16:22:48 +0000, Leif Lindholm wrote:
>> On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote:
>>> Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
>>> build no longer fits when built in DEBUG or NOOPT mode. So increase
>>> the FD size a little bit - we still have some spare room available in
>>> the FIP image.
>>>
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>
>> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>>
>> I will push this with (after) the VariablePolicy set since the problem
>> doesn't actually trigger until then.
>
> Urgh. This fixes DEBUG, but in my setup NOOPT is still too big.
> Would it be OK if I folded in an increase from 0x50000 to 0x60000
> before pushing?
>
Yeah that's fine.
> /
> Leif
>
>> /
>> Leif
>>
>>> ---
>>> Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
>>> index 83a3c4660cb3..58efed89b26e 100644
>>> --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
>>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
>>> @@ -21,12 +21,12 @@
>>>
>>> [FD.STANDALONE_MM]
>>> BaseAddress = 0xfc000000
>>> -Size = 0x00040000
>>> +Size = 0x00050000
>>> ErasePolarity = 1
>>>
>>> # This one is tricky, it must be: BlockSize * NumBlocks = Size
>>> BlockSize = 0x00010000
>>> -NumBlocks = 0x4
>>> +NumBlocks = 0x5
>>>
>>> ################################################################################
>>> #
>>> @@ -44,7 +44,7 @@ [FD.STANDALONE_MM]
>>> #
>>> ################################################################################
>>>
>>> -0x00000000|0x00040000
>>> +0x00000000|0x00050000
>>> FV = FvStandaloneMmCompact
>>>
>>> ################################################################################
>>> --
>>> 2.17.1
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-27 11:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-26 15:40 [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size Ard Biesheuvel
2020-11-26 16:22 ` Leif Lindholm
2020-11-27 11:50 ` Leif Lindholm
2020-11-27 11:56 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox