From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.18007.1606477812576566660 for ; Fri, 27 Nov 2020 03:50:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=pS2d9P6A; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id h21so6261420wmb.2 for ; Fri, 27 Nov 2020 03:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tHs5X0gYrYQ9Oz22nXTzLPGAeyx09Odj1rHZd65ChBw=; b=pS2d9P6AMPe4anXK6w7nFM9u1zJ+MZXpqsa7gxSV1/hBkW+V2rJj+mJcm0YYtT8AXm xFMODCupftBskTgxEQdcxZu05BEIv4RgtrLSBRV2C5xYHqUZiwN7nIiIGeHp7ZPOoXtH +xpSqMqCU7iI2oiCQcj6nnZn/HJ8RRcH9JjrQnVOJaLBQE6klH0iS3AdedNIQogSzegv jX5hsQ1cv9z1akENlXR56EUsbFVIZwYvFpYqSy1haEG5D5GVhyYxHN0Dd38Hams2p4nz rcenA56b//PdEbp0U9/Bqfc12pDryjsajKuLbT8AgnpTg/UvinhHOT4bPpyOBr/8AXna tpWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tHs5X0gYrYQ9Oz22nXTzLPGAeyx09Odj1rHZd65ChBw=; b=Y1KQTMwF3k4Jun1sAwDSksEU/iN3VOnEuK9d63I1zhXL0SVEcfkEnjBeFfZHZgW3fe YIPVsZuZdG57VdxoV22O7L7/ghoX0vYnykzz7ZdW2tWrwxT0ks5Mql1ij4EJ87HblGbU hl6SoPvlWlMfv88oYEDBs8QOWu5x+GWmNuW0Te/mGRidefstGJXYg5/Pc+be3Cu3OIJd 1Th9Py2s7JXbBz5jeHvxAmwQBKTnpqfLzWgnRyb2xly5oRgBQlkrDj0ILhvaUF8dn0ok BkfliYbN+H6Nbphmy4TnsDOcc7DdFlDDuMBaxtiuNmA887ZdjRkJwIceU+B206kUyZeF PJxw== X-Gm-Message-State: AOAM530DMuea5RzeHCkFy90cs8WS1jyt1hcX2RK7ot8yxbWOcKqfrJwE +M75lsgM+hFadyGCk87P+TGDwg== X-Google-Smtp-Source: ABdhPJxkZuKApeLlHOGeQZX6DBUCC7IJarrs451Wa84xjd600hBNOELqIympndr2cfOUKPQroOFyYw== X-Received: by 2002:a1c:dd86:: with SMTP id u128mr7501161wmg.102.1606477808112; Fri, 27 Nov 2020 03:50:08 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id d16sm15195503wrw.17.2020.11.27.03.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 03:50:07 -0800 (PST) Date: Fri, 27 Nov 2020 11:50:05 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size Message-ID: <20201127115005.GY1664@vanye> References: <20201126154046.6841-1-ard.biesheuvel@arm.com> <20201126162248.GX1664@vanye> MIME-Version: 1.0 In-Reply-To: <20201126162248.GX1664@vanye> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 26, 2020 at 16:22:48 +0000, Leif Lindholm wrote: > On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote: > > Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM > > build no longer fits when built in DEBUG or NOOPT mode. So increase > > the FD size a little bit - we still have some spare room available in > > the FIP image. > > > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > > I will push this with (after) the VariablePolicy set since the problem > doesn't actually trigger until then. Urgh. This fixes DEBUG, but in my setup NOOPT is still too big. Would it be OK if I folded in an increase from 0x50000 to 0x60000 before pushing? / Leif > / > Leif > > > --- > > Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf > > index 83a3c4660cb3..58efed89b26e 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf > > @@ -21,12 +21,12 @@ > > > > [FD.STANDALONE_MM] > > BaseAddress = 0xfc000000 > > -Size = 0x00040000 > > +Size = 0x00050000 > > ErasePolarity = 1 > > > > # This one is tricky, it must be: BlockSize * NumBlocks = Size > > BlockSize = 0x00010000 > > -NumBlocks = 0x4 > > +NumBlocks = 0x5 > > > > ################################################################################ > > # > > @@ -44,7 +44,7 @@ [FD.STANDALONE_MM] > > # > > ################################################################################ > > > > -0x00000000|0x00040000 > > +0x00000000|0x00050000 > > FV = FvStandaloneMmCompact > > > > ################################################################################ > > -- > > 2.17.1 > >