From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web08.18312.1606481759456281515 for ; Fri, 27 Nov 2020 04:56:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=iwiVBSZ2; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id f190so3426611wme.1 for ; Fri, 27 Nov 2020 04:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6jdGxog++mCOvTL2WuUFcGWdHxHGKM8wJjxQtHLoIHU=; b=iwiVBSZ2mmQvBav/+PKnERFXpinPFiMEAAjDA1XxDEca+xDq87Kprr9oQspHq+FxE1 PBk0Eow5j2wubciJOVEV6IDapCbjxAOD68r5jUcp0sahGDC4DtOXApO2pf/QlrLvbFL5 9yFRJRmvBPUCgLa8B39wYB3WXWnO9wJvP7HBw6lSKXa1NPA2tPj7034NZQSR9p1WHo3l IiZMWkTSLdlp006XlEfxuapLNRxXk1YT7nii+51NrP9lcSLZu8/WP15V8fUKL2DBRKrF SV5MaKiekDDznnaDmkGKMeav5i5h9O9eVHEsPGvtn0C/+nqPcKC38PwUnqfiYvY3nzk5 /ImQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6jdGxog++mCOvTL2WuUFcGWdHxHGKM8wJjxQtHLoIHU=; b=o8Ey96o/fwhs6r5wVVBpt8rx3Q8ZcfDk/FioMGj4TW5FTdrvTAiFctNbuyIARNsJHF YctLZyx6CZPvFOu41fT7JOym4Dd7lZlXDarVKmlEQpzjb8pWRkjUO6WVz813VrUSGJxu SrTh2haF6XRhC1AI51dVQ8IuRpNH89cqJFBjuIk+2FvDjbqUyRWy/2z1bUdZQV7bpCZC P0YE7Hq5ehR5Hb10MrtFtqUWb2Xc5Nr+rA+qb58bxww//OkYKndYUKjLMlYu5u0JVhdL J0gq067KOh+k/Jc79A2Lt7dJmkxUIxkXkf9B5sS/RxsdIXlWe9XPKMSTQbhNIXHT3KIK SWoQ== X-Gm-Message-State: AOAM530r/VEXOs0R+uROx/SZ+o/VjLj9rNIuhBcdyTgx7+e5v6WPWFCo Tq+LTVDwL1sjIOJMGwQGCNJjHA== X-Google-Smtp-Source: ABdhPJxpb6oiPhi/fn4VHusEgnU6lBhaiZw1dyNqw+JkVgWGNSiSu6n7uD65+BZeK33qaZQfhdAjSw== X-Received: by 2002:a05:600c:215:: with SMTP id 21mr4184978wmi.118.1606481758057; Fri, 27 Nov 2020 04:55:58 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id u81sm14313674wmb.27.2020.11.27.04.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 04:55:57 -0800 (PST) Date: Fri, 27 Nov 2020 12:55:55 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 06/17] Silicon/Socionext: fix unused variable error NorFlashFvb Message-ID: <20201127125555.GZ1664@vanye> References: <20201127113140.6904-1-leif@nuviainc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 27, 2020 at 12:42:46 +0100, Ard Biesheuvel wrote: > On 11/27/20 12:31 PM, Leif Lindholm wrote: > > When building in NOOPT mode, SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c > > fails to build with -Werror=unused-but-set-variable due to the Instance > > variable being set from the This pointer but never actually referenced. > > > > Cc: Ard Biesheuvel > > Signed-off-by: Leif Lindholm > > Acked-by: Ard Biesheuvel Thanks! Series pushed as 734fed7db671..abd92d65cf3b, with FV size patch at the end as previously mentioned. / Leif > > --- > > > > Submitting as a single additional patch rather than a full v2. > > (Patch 17 is Ard's new one increasing the FV size for DeveloperBoxMm.) > > > > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c > > index 387789fb9782..48774e955faf 100644 > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c > > @@ -209,9 +209,6 @@ FvbGetAttributes( > > ) > > { > > EFI_FVB_ATTRIBUTES_2 FlashFvbAttributes; > > - NOR_FLASH_INSTANCE *Instance; > > - > > - Instance = INSTANCE_FROM_FVB_THIS(This); > > FlashFvbAttributes = EFI_FVB2_READ_ENABLED_CAP | EFI_FVB2_READ_STATUS | > > EFI_FVB2_WRITE_ENABLED_CAP | EFI_FVB2_WRITE_STATUS | > > >