From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Peter Grehan <grehan@freebsd.org>
Subject: [PATCH 0/5] OvmfPkg: Fix Bhyve code formatting and style problems
Date: Sun, 29 Nov 2020 22:34:07 -0700 [thread overview]
Message-ID: <20201130053412.2-1-rebecca@bsdio.com> (raw)
There are several problems with the code style and formatting in Bhyve related files.
These include using structs without typedef'ing them, wrong indentation (e.g. three
spaces instead of two), and UINTN/UINT32 mix-ups which cause build errors when
using VS 2019.
I've taken this opportunity to also change the INF and DSC versions to decimal and
bump the version to 1.29 for INF files and 1.30 for the DSC.
Rebecca Cran (5):
OvmfPkg: Fix BhyveFwCtlLib build with VS2019
OvmfPkg: Improve code style/formatting in BhyveFwCtlLib.c
OvmfPkg: Fix style of BhyveFwCtlLib.inf
OvmfPkg: Improve style and formatting in BhyveFwCtlLib.h
OvmfPkg/Bhyve: Fix various style issues
OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
.../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 18 +-
OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf | 10 +-
OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf | 8 +-
OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 12 +-
.../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 10 +-
.../Library/BhyveFwCtlLib/BhyveFwCtlLib.inf | 5 +-
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 10 +-
OvmfPkg/Bhyve/AcpiTables/Platform.h | 2 +-
OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h | 6 +-
OvmfPkg/Bhyve/PlatformPei/Cmos.h | 6 +-
.../SmbiosPlatformDxe/SmbiosPlatformDxe.h | 7 +-
OvmfPkg/Include/Library/BhyveFwCtlLib.h | 24 +--
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 3 +-
OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 2 +-
OvmfPkg/Bhyve/PlatformPei/Fv.c | 2 +-
OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +-
OvmfPkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.c | 162 +++++++++---------
18 files changed, 143 insertions(+), 148 deletions(-)
--
2.29.2.windows.2
next reply other threads:[~2020-11-30 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 5:34 Rebecca Cran [this message]
2020-11-30 5:34 ` [PATCH 1/5] OvmfPkg: Fix BhyveFwCtlLib build with VS2019 Rebecca Cran
2020-11-30 5:34 ` [PATCH 2/5] OvmfPkg: Improve code style/formatting in BhyveFwCtlLib.c Rebecca Cran
2020-11-30 5:34 ` [PATCH 3/5] OvmfPkg: Fix style of BhyveFwCtlLib.inf Rebecca Cran
2020-11-30 5:34 ` [PATCH 4/5] OvmfPkg: Improve style and formatting in BhyveFwCtlLib.h Rebecca Cran
2020-11-30 5:34 ` [PATCH 5/5] OvmfPkg/Bhyve: Fix various style issues Rebecca Cran
2020-11-30 5:37 ` [edk2-devel] [PATCH 0/5] OvmfPkg: Fix Bhyve code formatting and style problems Peter Grehan
2020-11-30 5:48 ` Rebecca Cran
2020-11-30 16:35 ` Laszlo Ersek
2020-11-30 17:50 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130053412.2-1-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox