From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web12.55968.1606714478224270996 for ; Sun, 29 Nov 2020 21:34:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=UmXF9VXw; spf=none, err=SPF record not found (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MPQbrZucyQUCER0zzWn7liL5FSLHaM4fHVVPSIGgn+4=; b=UmXF9VXw0ZtBeTlPmA9byZjc6i IPv6AMc+8F7ytrB9d2iHgsm7Spm/7vmzHaYvxfHo8x0Ms8oeLhlBa3hL8o9uKmlEXOs1ithZLpJxZ QViFO7G3+X3CcNuvGWFV9U+nB/i03mSIIGldYjORZ2JIHB9tXd+JK2x8nnJjHwV2jIPQ=; Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kjbpc-003peb-0e; Sun, 29 Nov 2020 22:34:36 -0700 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1kjbpb-0007KA-24; Sun, 29 Nov 2020 22:34:35 -0700 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id C567B12807A0; Sun, 29 Nov 2020 22:34:34 -0700 (MST) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cZ6X_bE3nstQ; Sun, 29 Nov 2020 22:34:34 -0700 (MST) Received: from localhost.localdomain (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 8751912806C1; Sun, 29 Nov 2020 22:34:34 -0700 (MST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Peter Grehan Date: Sun, 29 Nov 2020 22:34:07 -0700 Message-Id: <20201130053412.2-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.29.2.windows.2 MIME-Version: 1.0 X-XM-SPF: eid=1kjbpb-0007KA-24;;;mid=<20201130053412.2-1-rebecca@bsdio.com>;;;hst=in01.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,XMNoVowels,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] X-Spam-DCC: XMission; sa06 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;devel@edk2.groups.io X-Spam-Relay-Country: X-Spam-Timing: total 398 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 8 (2.1%), b_tie_ro: 7 (1.7%), parse: 0.82 (0.2%), extract_message_metadata: 4.1 (1.0%), get_uri_detail_list: 0.95 (0.2%), tests_pri_-1000: 4.5 (1.1%), tests_pri_-950: 1.70 (0.4%), tests_pri_-900: 1.31 (0.3%), tests_pri_-90: 85 (21.5%), check_bayes: 84 (21.0%), b_tokenize: 10 (2.5%), b_tok_get_all: 6 (1.6%), b_comp_prob: 2.2 (0.6%), b_tok_touch_all: 61 (15.3%), b_finish: 1.19 (0.3%), tests_pri_0: 268 (67.4%), check_dkim_signature: 0.94 (0.2%), check_dkim_adsp: 42 (10.6%), poll_dns_idle: 33 (8.4%), tests_pri_10: 3.2 (0.8%), tests_pri_500: 14 (3.4%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 0/5] OvmfPkg: Fix Bhyve code formatting and style problems X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Content-Transfer-Encoding: 8bit There are several problems with the code style and formatting in Bhyve related files. These include using structs without typedef'ing them, wrong indentation (e.g. three spaces instead of two), and UINTN/UINT32 mix-ups which cause build errors when using VS 2019. I've taken this opportunity to also change the INF and DSC versions to decimal and bump the version to 1.29 for INF files and 1.30 for the DSC. Rebecca Cran (5): OvmfPkg: Fix BhyveFwCtlLib build with VS2019 OvmfPkg: Improve code style/formatting in BhyveFwCtlLib.c OvmfPkg: Fix style of BhyveFwCtlLib.inf OvmfPkg: Improve style and formatting in BhyveFwCtlLib.h OvmfPkg/Bhyve: Fix various style issues OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 18 +- OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf | 10 +- OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf | 8 +- OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 12 +- .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 10 +- .../Library/BhyveFwCtlLib/BhyveFwCtlLib.inf | 5 +- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 10 +- OvmfPkg/Bhyve/AcpiTables/Platform.h | 2 +- OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h | 6 +- OvmfPkg/Bhyve/PlatformPei/Cmos.h | 6 +- .../SmbiosPlatformDxe/SmbiosPlatformDxe.h | 7 +- OvmfPkg/Include/Library/BhyveFwCtlLib.h | 24 +-- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 3 +- OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 2 +- OvmfPkg/Bhyve/PlatformPei/Fv.c | 2 +- OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +- OvmfPkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.c | 162 +++++++++--------- 18 files changed, 143 insertions(+), 148 deletions(-) -- 2.29.2.windows.2