From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by mx.groups.io with SMTP id smtpd.web11.3029.1606782852173161171 for ; Mon, 30 Nov 2020 16:34:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=QTJpGlmZ; spf=pass (domain: nuviainc.com, ip: 209.85.216.66, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f66.google.com with SMTP id ms7so147118pjb.4 for ; Mon, 30 Nov 2020 16:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VhbI2iS+vXWA2K/76aHVpxUp9uxxN1oSJHNce4rZPLE=; b=QTJpGlmZhjfwa+pj8jCuHFIi/ZBdqhXEfqOpBWlrOIH2Iyzkfe9cm4iq4YdX9wXjKp RocllZ04iCXpr+QpwHT9yYW7GE38QAugdxl72wlbabFhymH5A9l2AWEjSWtUcsP/tNu+ GxJQ22c0NlkdPH46+4VIrd8FjoWYiMCKB1VdGv8mTWTNI924mMCHt4RoaRTaqsZ9eZhY OSl3WohfMxJIN7NLzPS4zloCrVW6s68z+e8XmP8v2zOdqFpUC/0oMFgGXX4fUoFJigTN M450kc/qkVEjXNjPwYdbKSxDk04Ceb40J+Co5syM3pgvEwJOX2vlWPMoDjwI/wgpafMv eZUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VhbI2iS+vXWA2K/76aHVpxUp9uxxN1oSJHNce4rZPLE=; b=SgE59PVYcBstBGNi0HcA2PrSiDcl27bjFqJPr5R5lIJm+hEgOpYjVVAlU36lCbisJx hfDFVFirTXam2h2BmDKdUIYUZQ/hzXlxg9zpui4/iozcAMGgOTmESDp9TcUeeCzj8+31 fD8yeApOjqtJoJQiT3S5AdTefHPweS7tpi1f6a6OR3Gj9Cbc5/K8C5mYEfZ0xbl3etWA L0eaRcI0gvlZY8gOeO3FWD3zIwx5VKk+aeCC7jTZylqX+bb3kUZy8SMSkusV7TtzzLGy /D9JaFlfSTshRP5u4/o80mbVB4t78NcWpvvvsBtSR2Qn7UCG2JSBEWDMQwu4yIOCzPgX LVlg== X-Gm-Message-State: AOAM5312CGN1jJy6jkNUsTkcEUwk3hTZ2xJFyt7UHlKReCRYLMsMKz2R hbKHsGBJ5CxAyAh4IkZhPDzw91r5JujdmlBqTP5XxxKvuXICXe5YFrnJlMjoe10/gbGdC2kv9QR HBnovCSbOWuTg1deqmc8ftelUbcKfWyf/oaudjrJUWwJYT6TxugPOaUyo0Aop0SLAR+5a0y/r X-Google-Smtp-Source: ABdhPJzIZ3Kumubbgd4PX/zk3TywfjORcxIYKejDoSYH5MeZ49baqazkLLJx6zCY/fxpVJHWnt1NBA== X-Received: by 2002:a17:90b:350a:: with SMTP id ls10mr463413pjb.192.1606782851202; Mon, 30 Nov 2020 16:34:11 -0800 (PST) Return-Path: Received: from cube.nuviainc.com (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id 22sm57899pjb.40.2020.11.30.16.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 16:34:10 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , Sami Mujawar Subject: [PATCH v4 00/11] ArmPkg,MdePkg: Add Universal/Smbios and Drivers/FirmwareVersionInfoPeim Date: Mon, 30 Nov 2020 17:33:47 -0700 Message-Id: <20201201003358.8780-1-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Much of the data for the SMBIOS tables is generic, and need not be duplicated for each platform. This patch series introduces ArmPkg/Universal/Smbios, which is largely copied from edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS tables 0,1,2,3,4,7,13,32 and uses a combination of PCDs and calls into a new OemMiscLib to get information which varies between platforms. I plan to submit a patch against SbsaQemu to update it to use this new functionality. Changes from v3 to v4: - Split changes up into many more patches. - Renamed VersionInfoHob to FirmwareVersionInfoHob. - Refactored ProcessorSubClass.c to reduce function complexity. - Removed BOM from .uni files. - Added comment to OemMiscLib.h to clarify that the functions listed are to be implemented by the individual platforms. - Added Doxygen comments in many places. - Moved definition of MAX_ARM_CACHE_LEVEL to ArmPkg/Include/Library/ArmLib.h - Addressed other review feedback. Leif: I decided not to rename Smbios to SmBios because that capitalization doesn't appear to be common. "SMBIOS" or "Smbios" seem more common, so I plan to submit a patch to rename MdePkg/Include/IndustryStandard/SmBios to Smbios.h. Rebecca Cran (11): ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h MdePkg: Update IndustryStandard/SmBios.h with processor status data ArmPkg: Add register encoding definition for MMFR2 ArmPkg: Add helper to read the Memory Model Features Register 2 ArmPkg: Add helper function to read the Memory Model Feature Register 4 ArmPkg: Add helper to read CCIDX status ArmPkg: Fix the return type of the ReadCCSIDR function ArmPkg: Update ArmLibPrivate.h with cache register definitions ArmPkg: Add FirmwareVersionInfoPeim ArmPkg: Add Universal/Smbios, a generic SMBIOS library for ARM ArmPkg: Add definition of the maximum cache level in ARMv8-A ArmPkg/ArmPkg.dec | 3 + ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.inf | 47 ++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 55 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 90 +++ ArmPkg/Include/Chipset/AArch64.h | 4 + ArmPkg/Include/Guid/FirmwareVersionInfoHobGuid.h | 29 + ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 13 + ArmPkg/Include/Library/ArmLib.h | 10 + ArmPkg/Include/Library/OemMiscLib.h | 91 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 + ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 + ArmPkg/Library/ArmLib/ArmLibPrivate.h | 93 ++- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h | 34 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 217 ++++++ MdePkg/Include/IndustryStandard/SmBios.h | 13 + ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.c | 91 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 12 + ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 12 + ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 798 ++++++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c | 68 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 167 ++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 100 +++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 238 ++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 43 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 181 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 51 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 194 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 58 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 192 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 39 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 155 ++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 41 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 67 ++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 + ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 4 + ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 6 +- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 23 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscLibString.uni | 21 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 18 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 21 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 21 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 18 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni | 43 ++ 44 files changed, 3395 insertions(+), 3 deletions(-) create mode 100644 ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.inf create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf create mode 100644 ArmPkg/Include/Guid/FirmwareVersionInfoHobGuid.h create mode 100644 ArmPkg/Include/Library/OemMiscLib.h create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h create mode 100644 ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscLibString.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni -- 2.26.2