From: "Leif Lindholm" <leif@nuviainc.com>
To: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: devel@edk2.groups.io, Heinrich Schuchardt <xypron.glpk@gmx.de>,
Abner Chang <abner.chang@hpe.com>,
Gilbert Chen <gilbert.chen@hpe.com>,
Eric Jin <eric.jin@intel.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg
Date: Wed, 2 Dec 2020 12:07:20 +0000 [thread overview]
Message-ID: <20201202120720.GF1664@vanye> (raw)
In-Reply-To: <20201201161752.23734-1-daniel.schaefer@hpe.com>
On Wed, Dec 02, 2020 at 00:17:50 +0800, Daniel Schaefer wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>
> With this patch series we can build the UEFI SCT for RISCV64. It was confirmed
> to be working on the U-Boot UEFI implementation by Heinrich.
> It hasn't been tested on EDK2 yet.
>
> Build requirements are the same as for the EDK2 RISCV64 port and detailed here:
> https://github.com/riscv/riscv-uefi-edk2-docs
>
> The second patch is a big one because it adds architecture specific files by
> copying them from the Aarch64 directory. Only a single file, an assembly file
> needed modifications. I'm not sure why the other ones are in an architecture
> specific directory. They're all C files and seem to be generic. We can probably
> unify them.
It seems to me this can be trivially unified for all !x86 platforms,
and I don't think it would take much more to unify for all platforms.
Certainly, looking at the code you copy, that could already do with
some cleanup of its own.
/
Leif
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Eric Jin <eric.jin@intel.com>
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
> Daniel Schaefer (2):
> SctPkg: Add RISCV64 support
> SctPkg: Enable RISCV64 support using AARCH64 sources
>
> uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h | 3 +
> uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h | 32 +++
> uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c | 45 ++++
> uefi-sct/SctPkg/Library/SctLib/SctLib.inf | 6 +
> uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S | 45 ++++
> uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c | 182 +++++++++++++
> uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf | 6 +
> uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c | 88 +++++++
> uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c | 68 +++++
> uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c | 134 ++++++++++
> uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h | 48 ++++
> uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf | 7 +
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf | 6 +
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c | 137 ++++++++++
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c | 276 ++++++++++++++++++++
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c | 30 +++
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf | 4 +
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/Riscv64/TimerInterrupt.c | 51 ++++
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf | 4 +
> uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf | 5 +
> uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h | 55 ++++
> uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c | 55 ++++
> uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile | 3 +
> uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 14 +-
> uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h | 62 ++++-
> uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 14 +-
> uefi-sct/SctPkg/build.sh | 10 +-
> 27 files changed, 1386 insertions(+), 4 deletions(-)
> create mode 100644 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> create mode 100644 uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> create mode 100644 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> create mode 100644 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h
> create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c
> create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
> create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c
> create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/Riscv64/TimerInterrupt.c
> create mode 100644 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h
> create mode 100644 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c
>
> --
> 2.28.0
>
prev parent reply other threads:[~2020-12-02 12:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 16:17 [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg Daniel Schaefer
2020-12-01 16:17 ` [edk2-test PATCH v1 1/2] SctPkg: Add RISCV64 support Daniel Schaefer
2020-12-02 11:44 ` [edk2-devel] " Leif Lindholm
2021-02-08 15:09 ` Daniel Schaefer
2020-12-01 16:17 ` [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources Daniel Schaefer
2020-12-02 12:04 ` [edk2-devel] " Leif Lindholm
2021-02-08 15:09 ` Daniel Schaefer
2021-02-08 17:04 ` Heinrich Schuchardt
2021-02-09 12:42 ` Leif Lindholm
2021-02-09 13:47 ` Heinrich Schuchardt
2021-02-09 14:58 ` Leif Lindholm
2021-02-09 15:11 ` Daniel Schaefer
2020-12-01 16:59 ` [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg Heinrich Schuchardt
2020-12-01 17:11 ` Daniel Schaefer
2020-12-01 17:37 ` Heinrich Schuchardt
2021-02-08 14:30 ` Daniel Schaefer
2021-02-08 15:50 ` Heinrich Schuchardt
2020-12-02 12:07 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202120720.GF1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox