From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.3781.1606910845537231317 for ; Wed, 02 Dec 2020 04:07:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UtjUiSw6; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id 3so7196307wmg.4 for ; Wed, 02 Dec 2020 04:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2E27hq3D+rHSzq0w3hx3e4uyZr9gcdQaqNvIDgzIDHM=; b=UtjUiSw65gs0sIU/khnAhWHu8IQrEqoh76YSJZFL1t2GKKgGXM1n6l8a3bPaiT9d4z 2hmSbqtx01nL85zzvLTi9omTQjkcdKt3aA9IVZ8Cspql74z4RYfryQpxX+HKElM4ZI5I wTCfDjuAK4CWPhxuzpGWHaqQhSyDH/SmOyECH8kuC4ldk1yQ0E6tyHWz2YAv1yvoHDHt sDfGahbChIAN6XICKasrwzVwD5LzYzDZG80ob+bbiptwc81/vPSw0EgrlR7IgAN037FJ S2Vt7IXrezxgKgiIvitozxkDQE92Y8qz4+CM5AMP3RRwbFpvbCzDDLKj+KViJyieqUZf wWuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2E27hq3D+rHSzq0w3hx3e4uyZr9gcdQaqNvIDgzIDHM=; b=ZhqBc/L83+4UOrMlQ/gJAGYz8PrE6bcJv3IM7j4kCmc+KUMS8iwk9KWhDh4vY41Egy ks7psINFg50TnhDuxyXU428f58UUQnjf/JlnsuWnt4yZ0yMVZRqRLDFJ1DEeelvpUXyl 8nAJDCWu6RvX437gRBidHgQONI9y9UmVGSuDdUm4cc7tIDpA8bpoz3pkxOx0symyhZkO YIiALc4Vw0oVgKwOEPiSSiOU1xCsuynFoUiHzEleXg4Z15gZX3OFj3/g4gCX2Pg4DpAO vXKHVGuxXQMOxiIW8jH78rDr8rqu8a8SOL0ZSOfu+mUSkePC6b87rcaA1dqNWJ3b08fI eglg== X-Gm-Message-State: AOAM532PwFr1JdDKRiY9PM6VfbVqHY3z+67cNvOteBdLtVVih7R0nwyd Oan1OsOhbY7H/Yn1wdtLX3FpEg== X-Google-Smtp-Source: ABdhPJx49pXZHAaI5gZfG05c7EYeWednPd0+KHG7iIFqj0rfHBd3FHhjRBndtoVqclAGqR/blyywTw== X-Received: by 2002:a1c:2b03:: with SMTP id r3mr2844583wmr.184.1606910843609; Wed, 02 Dec 2020 04:07:23 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id u66sm1851621wmg.30.2020.12.02.04.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 04:07:22 -0800 (PST) Date: Wed, 2 Dec 2020 12:07:20 +0000 From: "Leif Lindholm" To: Daniel Schaefer Cc: devel@edk2.groups.io, Heinrich Schuchardt , Abner Chang , Gilbert Chen , Eric Jin , G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg Message-ID: <20201202120720.GF1664@vanye> References: <20201201161752.23734-1-daniel.schaefer@hpe.com> MIME-Version: 1.0 In-Reply-To: <20201201161752.23734-1-daniel.schaefer@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 02, 2020 at 00:17:50 +0800, Daniel Schaefer wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 > > With this patch series we can build the UEFI SCT for RISCV64. It was confirmed > to be working on the U-Boot UEFI implementation by Heinrich. > It hasn't been tested on EDK2 yet. > > Build requirements are the same as for the EDK2 RISCV64 port and detailed here: > https://github.com/riscv/riscv-uefi-edk2-docs > > The second patch is a big one because it adds architecture specific files by > copying them from the Aarch64 directory. Only a single file, an assembly file > needed modifications. I'm not sure why the other ones are in an architecture > specific directory. They're all C files and seem to be generic. We can probably > unify them. It seems to me this can be trivially unified for all !x86 platforms, and I don't think it would take much more to unify for all platforms. Certainly, looking at the code you copy, that could already do with some cleanup of its own. / Leif > Cc: Leif Lindholm > Cc: Heinrich Schuchardt > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Eric Jin > Cc: G Edhaya Chandran > Cc: Barton Gao > Cc: Samer El-Haj-Mahmoud > > Daniel Schaefer (2): > SctPkg: Add RISCV64 support > SctPkg: Enable RISCV64 support using AARCH64 sources > > uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h | 3 + > uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h | 32 +++ > uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c | 45 ++++ > uefi-sct/SctPkg/Library/SctLib/SctLib.inf | 6 + > uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S | 45 ++++ > uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c | 182 +++++++++++++ > uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf | 6 + > uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c | 88 +++++++ > uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c | 68 +++++ > uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c | 134 ++++++++++ > uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h | 48 ++++ > uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf | 7 + > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf | 6 + > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c | 137 ++++++++++ > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c | 276 ++++++++++++++++++++ > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c | 30 +++ > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf | 4 + > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/Riscv64/TimerInterrupt.c | 51 ++++ > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf | 4 + > uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf | 5 + > uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h | 55 ++++ > uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c | 55 ++++ > uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile | 3 + > uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 14 +- > uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h | 62 ++++- > uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 14 +- > uefi-sct/SctPkg/build.sh | 10 +- > 27 files changed, 1386 insertions(+), 4 deletions(-) > create mode 100644 uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h > create mode 100644 uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c > create mode 100644 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S > create mode 100644 uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c > create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c > create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c > create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c > create mode 100644 uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.h > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestCacheFunction.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/PlatformIsa.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/Riscv64/TimerInterrupt.c > create mode 100644 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat.h > create mode 100644 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c > > -- > 2.28.0 >