public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Vu Nguyen <vunguyen@os.amperecomputing.com>
Cc: devel@edk2.groups.io, patches@amperecomputing.com,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-non-osi][PATCH 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package
Date: Wed, 2 Dec 2020 12:44:34 +0000	[thread overview]
Message-ID: <20201202124434.GH1664@vanye> (raw)
In-Reply-To: <20201201085409.20045-1-vunguyen@os.amperecomputing.com>

Hi Vu,

Thanks for this.

However, as previously communicated to your colleague:
---
As for the mechanism, please generate a separate patch set, adding
--no-binary to the git format-patch command line.
Then make the commits available in a public repository referred to in
the cover letter.
----

As a feedback detail - please drop any leading _ characters from
include file header guards (or other macros), these are reserved for
toolchain use.

Also, since this is the first on-list communication about this
platform, it would be helpful if the cover letter stated what these
files are and why they are being upstreamed.

Best Regards,

Leif

On Tue, Dec 01, 2020 at 15:54:07 +0700, Vu Nguyen wrote:
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Vu Nguyen (2):
>   AmpereAltraBinPkg: Add PciePhyLib library and header
>   edk2-non-osi: Add AmpereAltraBinPkg maintainers
> 
>  Maintainers.txt                               |   4 +
>  Silicon/Ampere/License.txt                    |  25 +++
>  .../Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec   |  16 ++
>  .../Library/PciePhyLib/PciePhyLib.inf         |  23 +++
>  .../Include/Library/PciePhyLib.h              | 165 ++++++++++++++++++
>  .../Library/PciePhyLib/PciePhyLib.lib         | Bin 0 -> 26026 bytes
>  6 files changed, 233 insertions(+)
>  create mode 100644 Silicon/Ampere/License.txt
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.lib
> 
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-12-02 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  8:54 [edk2-non-osi][PATCH 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package vunguyen
2020-12-01  8:54 ` [edk2-non-osi][PATCH 1/2] AmpereAltraBinPkg: Add PciePhyLib library and header Vu Nguyen
2020-12-01  8:54 ` [edk2-non-osi][PATCH 2/2] edk2-non-osi: Add AmpereAltraBinPkg maintainers Vu Nguyen
2020-12-02 12:44 ` Leif Lindholm [this message]
2020-12-02 14:34   ` [edk2-non-osi][PATCH 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package Vu Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202124434.GH1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox