From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.4222.1606913078885136523 for ; Wed, 02 Dec 2020 04:44:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=rZuBh8FB; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id o1so3775811wrx.7 for ; Wed, 02 Dec 2020 04:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G4Vjc2We9iG6EdHSkfHfmnbp5BU8XUb4NYwG0l6/pn0=; b=rZuBh8FBYP/f8IpPKuH1BlbwYV/mjNr5q2xKd8RgEVgXbi4vOgrbMwoZwuazO1dVPQ kf4WyoHpd5o1VbjMiVGmFUfV1wp355b/J9DTFyEzxuIFk39t7yOnJOQqYAIM5CwyPV4l WjLPqRuN10XW5Jyx1fuozu7Ll3koYQy0oo+ScOzkURi3ADbV+wtZwfr1gIhfTGdnly9p FEarTMNE25BaAuC0k/jzDzUndDm1tWYvHvpIBaDwJhVZ9lRZWn/gpM49cuyuZl3Vw/FS 58Eb7Kdme9laCVv9aC6/DSpx5cT7rwpeDKQ+QdwLQ34Aksn6Fm8eAxCr5v54pwKUf+sA 0qTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G4Vjc2We9iG6EdHSkfHfmnbp5BU8XUb4NYwG0l6/pn0=; b=AIWGU8f47HFVPhs/2Yf6eH6D1sBvPvPqwBnKxnohct5mWKBfscZbBP5kEHHNG4nrSV c4PFqVyVqXTJMQFuW7bbyvg2ZUmWQ5GoqJbaR+8r2yGGAi75Bn+V93UrMuPc+LFI0vcG EN1iBXUA+i55H3X/QL3KGbV6A2DL1FbIfJ00EIVp7ZF42SySsdtD5WKvOscbI7ViuQDb Bh1G/9uLaYvzgLdX/Iru0dQBxeDIKMzk7VGVLAlrA/fwIGsdIviUbN/zBTK6Kc4W3Jam 56C971Uphy0/Z1YVrtSLac5wjZbPyNwkyhyOLu3EiMFC2UlI+bb/Lr4VfymFV7bjtxO5 mPpg== X-Gm-Message-State: AOAM532W5nk6mHpkb7ufAvtWUepVJzQdNKyihvsfwFJ9xlR88viP/USp Sbz/+Z45Yb+xy1A4QydA23Rt1w== X-Google-Smtp-Source: ABdhPJw3nHCWd9Aabx244OGxddOxDlrEBftZEd/uQIqAtXYBlk3acAHh0Wge+Y8YVk6muIJGwhQ6TQ== X-Received: by 2002:adf:a39e:: with SMTP id l30mr3240837wrb.195.1606913077226; Wed, 02 Dec 2020 04:44:37 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id j6sm1918600wrq.38.2020.12.02.04.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 04:44:36 -0800 (PST) Date: Wed, 2 Dec 2020 12:44:34 +0000 From: "Leif Lindholm" To: Vu Nguyen Cc: devel@edk2.groups.io, patches@amperecomputing.com, Ard Biesheuvel , Nate DeSimone Subject: Re: [edk2-non-osi][PATCH 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package Message-ID: <20201202124434.GH1664@vanye> References: <20201201085409.20045-1-vunguyen@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20201201085409.20045-1-vunguyen@os.amperecomputing.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Vu, Thanks for this. However, as previously communicated to your colleague: --- As for the mechanism, please generate a separate patch set, adding --no-binary to the git format-patch command line. Then make the commits available in a public repository referred to in the cover letter. ---- As a feedback detail - please drop any leading _ characters from include file header guards (or other macros), these are reserved for toolchain use. Also, since this is the first on-list communication about this platform, it would be helpful if the cover letter stated what these files are and why they are being upstreamed. Best Regards, Leif On Tue, Dec 01, 2020 at 15:54:07 +0700, Vu Nguyen wrote: > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Nate DeSimone > > Vu Nguyen (2): > AmpereAltraBinPkg: Add PciePhyLib library and header > edk2-non-osi: Add AmpereAltraBinPkg maintainers > > Maintainers.txt | 4 + > Silicon/Ampere/License.txt | 25 +++ > .../Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec | 16 ++ > .../Library/PciePhyLib/PciePhyLib.inf | 23 +++ > .../Include/Library/PciePhyLib.h | 165 ++++++++++++++++++ > .../Library/PciePhyLib/PciePhyLib.lib | Bin 0 -> 26026 bytes > 6 files changed, 233 insertions(+) > create mode 100644 Silicon/Ampere/License.txt > create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec > create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf > create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h > create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.lib > > -- > 2.17.1 >