[PATCH 0/3] MdePkg: fix typos in SmBios.h

[PATCH 0/3] MdePkg: fix typos in SmBios.h

[Rebecca Cran]

Since the edk2-stable202011 tag has been created, I'm resubmitting the
SmBios.h typo fixes.

Rebecca Cran (3):
  MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct
  MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
    ProcessorManufacturer
  MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field FirmwareVersion

 MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)

-- 
2.26.2

[PATCH 1/3] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct

[Rebecca Cran]

Fix typos of "Processor64BitCapable", "ProcessorEnhancedVirtualization",
and Processor128BitCapable.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 22 ++++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 1ee01645679a..400bdef90b4f 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -862,17 +862,17 @@ typedef struct {
 } PROCESSOR_FEATURE_FLAGS;
 
 typedef struct {
-  UINT16  ProcessorReserved1             :1;
-  UINT16  ProcessorUnknown               :1;
-  UINT16  Processor64BitCapble           :1;
-  UINT16  ProcessorMultiCore             :1;
-  UINT16  ProcessorHardwareThread        :1;
-  UINT16  ProcessorExecuteProtection     :1;
-  UINT16  ProcessorEnhancedVirtulization :1;
-  UINT16  ProcessorPowerPerformanceCtrl  :1;
-  UINT16  Processor128bitCapble          :1;
-  UINT16  ProcessorArm64SocId            :1;
-  UINT16  ProcessorReserved2             :6;
+  UINT16  ProcessorReserved1              :1;
+  UINT16  ProcessorUnknown                :1;
+  UINT16  Processor64BitCapable           :1;
+  UINT16  ProcessorMultiCore              :1;
+  UINT16  ProcessorHardwareThread         :1;
+  UINT16  ProcessorExecuteProtection      :1;
+  UINT16  ProcessorEnhancedVirtualization :1;
+  UINT16  ProcessorPowerPerformanceCtrl   :1;
+  UINT16  Processor128BitCapable          :1;
+  UINT16  ProcessorArm64SocId             :1;
+  UINT16  ProcessorReserved2              :6;
 } PROCESSOR_CHARACTERISTIC_FLAGS;
 
 typedef struct {
-- 
2.26.2

[PATCH 2/3] MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field ProcessorManufacturer

[Rebecca Cran]

In SmBios.h, the SMBIOS_TABLE_TYPE4 field "ProcessorManufacture"
should be "ProcessorManufacturer".

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 400bdef90b4f..ac2498482a92 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -894,7 +894,7 @@ typedef struct {
   SMBIOS_TABLE_STRING   Socket;
   UINT8                 ProcessorType;          ///< The enumeration value from PROCESSOR_TYPE_DATA.
   UINT8                 ProcessorFamily;        ///< The enumeration value from PROCESSOR_FAMILY_DATA.
-  SMBIOS_TABLE_STRING   ProcessorManufacture;
+  SMBIOS_TABLE_STRING   ProcessorManufacturer;
   PROCESSOR_ID_DATA     ProcessorId;
   SMBIOS_TABLE_STRING   ProcessorVersion;
   PROCESSOR_VOLTAGE     Voltage;
-- 
2.26.2

[PATCH 3/3] MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field FirmwareVersion

[Rebecca Cran]

"FirmwareVersion" was misspelled "FirwareVersion"

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index ac2498482a92..3bc8732eef99 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1837,7 +1837,7 @@ typedef struct {
   //
   UINT8                                     MemoryTechnology;   ///< The enumeration value from MEMORY_DEVICE_TECHNOLOGY
   MEMORY_DEVICE_OPERATING_MODE_CAPABILITY   MemoryOperatingModeCapability;
-  SMBIOS_TABLE_STRING                       FirwareVersion;
+  SMBIOS_TABLE_STRING                       FirmwareVersion;
   UINT16                                    ModuleManufacturerID;
   UINT16                                    ModuleProductID;
   UINT16                                    MemorySubsystemControllerManufacturerID;
-- 
2.26.2

回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[gaoliming]

Rebecca:
  I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
There are many platform SmbiosDxe driver to depend on them. 
  So, this change impacts widely. This change is just to rename field name.
There is no real functionality change. I suggest to add comments for those
typo fields instead of changing them. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+68193+4905953+8761045@groups.io
> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
> 发送时间: 2020年12月3日 3:03
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> 
> Since the edk2-stable202011 tag has been created, I'm resubmitting the
> SmBios.h typo fixes.
> 
> Rebecca Cran (3):
>   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> struct
>   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>     ProcessorManufacturer
>   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> FirmwareVersion
> 
>  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> --
> 2.26.2
> 
> 
> 
> 
> 

Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[Rebecca Cran]

Liming,


Yes lots of platforms use the structures, but most (all?) don't 
reference the fields themselves.

For example, searching for "FirwareVersion" in edk2-platforms gives just 
one results:


../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:576: 
0,                    // FirwareVersion


Same for 'Processor64BitCapble:


../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:276: 
// Processor64BitCapble            :1;


I did find a problem with this patch: SmbiosView in edk2 needs updated 
at the same time - so I'll send out a v2 shortly.


-- 

Rebecca Cran


On 12/2/20 6:18 PM, gaoliming wrote:
> Rebecca:
>    I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
> There are many platform SmbiosDxe driver to depend on them.
>    So, this change impacts widely. This change is just to rename field name.
> There is no real functionality change. I suggest to add comments for those
> typo fields instead of changing them.
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+68193+4905953+8761045@groups.io
>> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
>> 发送时间: 2020年12月3日 3:03
>> 收件人: devel@edk2.groups.io
>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Zhiguang Liu <zhiguang.liu@intel.com>
>> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>>
>> Since the edk2-stable202011 tag has been created, I'm resubmitting the
>> SmBios.h typo fixes.
>>
>> Rebecca Cran (3):
>>    MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
>> struct
>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>>      ProcessorManufacturer
>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
>> FirmwareVersion
>>
>>   MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2
>>
>>
>>
>>
>>
>
>
>
>
> 
>
>

Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[Leif Lindholm]

Liming,

These aren't randomly named fields, they are incorrect representations
of an industry standard.

We are now in the period just after stable tag, breaking platforms is
perfectly acceptable.

Also, we just happily broke all known platforms during soft freeze by
merging the VariablePolicy set.

/
    Leif

On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
> Rebecca:
>   I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
> There are many platform SmbiosDxe driver to depend on them. 
>   So, this change impacts widely. This change is just to rename field name.
> There is no real functionality change. I suggest to add comments for those
> typo fields instead of changing them. 
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+68193+4905953+8761045@groups.io
> > <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
> > 发送时间: 2020年12月3日 3:03
> > 收件人: devel@edk2.groups.io
> > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> > 
> > Since the edk2-stable202011 tag has been created, I'm resubmitting the
> > SmBios.h typo fixes.
> > 
> > Rebecca Cran (3):
> >   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> > struct
> >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
> >     ProcessorManufacturer
> >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> > FirmwareVersion
> > 
> >  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
> >  1 file changed, 13 insertions(+), 13 deletions(-)
> > 
> > --
> > 2.26.2
> > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 
> 
> 
> 
> 

回复: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[gaoliming]

Leif:
  I don't mean to object the incompatible change. I understand that the field name is changed for the readable source code. So, I propose to add comments for it to achieve the same goal.

Thanks
Liming
> -----邮件原件-----
> 发件人: Leif Lindholm <leif@nuviainc.com>
> 发送时间: 2020年12月3日 19:24
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: rebecca@nuviainc.com; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>;
> 'Laszlo Ersek' <lersek@redhat.com>
> 主题: Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> 
> Liming,
> 
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
> 
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
> 
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
> 
> /
>     Leif
> 
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
> > Rebecca:
> >   I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in
> edk2-platforms.
> > There are many platform SmbiosDxe driver to depend on them.
> >   So, this change impacts widely. This change is just to rename field name.
> > There is no real functionality change. I suggest to add comments for those
> > typo fields instead of changing them.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: bounce+27952+68193+4905953+8761045@groups.io
> > > <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca
> Cran
> > > 发送时间: 2020年12月3日 3:03
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Zhiguang Liu <zhiguang.liu@intel.com>
> > > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> > >
> > > Since the edk2-stable202011 tag has been created, I'm resubmitting the
> > > SmBios.h typo fixes.
> > >
> > > Rebecca Cran (3):
> > >   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> > > struct
> > >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
> > >     ProcessorManufacturer
> > >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> > > FirmwareVersion
> > >
> > >  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
> > >  1 file changed, 13 insertions(+), 13 deletions(-)
> > >
> > > --
> > > 2.26.2
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> > 
> >
> >

Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

[Sean]

As a downstream consumer and maintainer I strongly support correcting 
these fields.

If a platform dev model can't handle this type of breaking change then 
this project is paralyzed and bigger things should be addressed.

Thanks
Sean

On 12/3/2020 3:24 AM, Leif Lindholm wrote:
> Liming,
> 
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
> 
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
> 
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
> 
> /
>      Leif
> 
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
>> Rebecca:
>>    I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
>> There are many platform SmbiosDxe driver to depend on them.
>>    So, this change impacts widely. This change is just to rename field name.
>> There is no real functionality change. I suggest to add comments for those
>> typo fields instead of changing them.
>>
>> Thanks
>> Liming
>>> -----邮件原件-----
>>> 发件人: bounce+27952+68193+4905953+8761045@groups.io
>>> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
>>> 发送时间: 2020年12月3日 3:03
>>> 收件人: devel@edk2.groups.io
>>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>>> Zhiguang Liu <zhiguang.liu@intel.com>
>>> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>>>
>>> Since the edk2-stable202011 tag has been created, I'm resubmitting the
>>> SmBios.h typo fixes.
>>>
>>> Rebecca Cran (3):
>>>    MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
>>> struct
>>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>>>      ProcessorManufacturer
>>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
>>> FirmwareVersion
>>>
>>>   MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>>
>>> --
>>> 2.26.2
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>>
>>
> 
> 
> 
> 
>