[edk2-non-osi][PATCH v4 0/1] Add ASpeed AST2500 GOP driver

[edk2-non-osi][PATCH v4 0/1] Add ASpeed AST2500 GOP driver

[Nhi Pham]

This adds the AArch64 binary for ASpeed GOP driver version 1.10.00.

The commit is currently available at 
https://github.com/AmpereComputing/edk2-non-osi/tree/add-aspeed-ast2500-gop-driver

Cc: Ray Ni <ray.ni@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Version history
V4:
  + Changed license statement to use SPDX-License-Identifier
  + Changed the INF version to 0x0001001B.

V3:
  + Changed the origin uefi_2500_800.efi name to ASpeedAst2500Gop.efi to
  conform to EDK2 naming convention.
  + Changed the GopDxe.inf name to the meaningful ASpeedAst2500GopDxe.inf

Nhi Pham (1):
  Drivers/ASpeed: Add ASpeed AST2500 GOP driver

 .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf   |  19 +++++++++++++
 .../AArch64/ASpeedAst2500Gop.efi              | Bin 0 -> 42880 bytes
 Drivers/ASpeed/License.txt                    |  25 ++++++++++++++++++
 3 files changed, 44 insertions(+)
 create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
 create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2500Gop.efi
 create mode 100644 Drivers/ASpeed/License.txt

-- 
2.17.1

[edk2-non-osi][PATCH v4 1/1] Drivers/ASpeed: Add ASpeed AST2500 GOP driver

[Nhi Pham]

This is the AArch64 binary provided by ASpeed for AST2500 Gop driver
version 1.10.00.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>

Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf      |  19 +++++++++++++++
 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2500Gop.efi | Bin 0 -> 42880 bytes
 Drivers/ASpeed/License.txt                                  |  25 ++++++++++++++++++++
 3 files changed, 44 insertions(+)

diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
new file mode 100644
index 000000000000..b3cee454d2e6
--- /dev/null
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
@@ -0,0 +1,19 @@
+## @file
+#  Component description file for ASPEED Graphics Controller Driver.
+#
+#  Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2020, ASPEED Technology Inc. All rights reserved.<BR>
+#
+#  SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  INF_VERSION                    = 0x0001001B
+  BASE_NAME                      = ASpeedAst2500GopDxe
+  FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD
+  MODULE_TYPE                    = UEFI_DRIVER
+  VERSION_STRING                 = 1.1
+
+[Binaries.AArch64]
+  PE32|AArch64/ASpeedAst2500Gop.efi|*
diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2500Gop.efi b/Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2500Gop.efi
new file mode 100644
index 000000000000..4b36e189b3a1
Binary files /dev/null and b/Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2500Gop.efi differ
diff --git a/Drivers/ASpeed/License.txt b/Drivers/ASpeed/License.txt
new file mode 100644
index 000000000000..3dc49d3aff4f
--- /dev/null
+++ b/Drivers/ASpeed/License.txt
@@ -0,0 +1,25 @@
+Copyright (c) 2020, ASPEED Technology Inc. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+
+1. Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in
+   the documentation and/or other materials provided with the
+   distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
-- 
2.17.1

Re: [edk2-non-osi][PATCH v4 0/1] Add ASpeed AST2500 GOP driver

[Ard Biesheuvel]

On 12/3/20 6:48 AM, Nhi Pham wrote:
> This adds the AArch64 binary for ASpeed GOP driver version 1.10.00.
> 
> The commit is currently available at 
> https://github.com/AmpereComputing/edk2-non-osi/tree/add-aspeed-ast2500-gop-driver
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> 
> Version history
> V4:
>   + Changed license statement to use SPDX-License-Identifier
>   + Changed the INF version to 0x0001001B.
> 
> V3:
>   + Changed the origin uefi_2500_800.efi name to ASpeedAst2500Gop.efi to
>   conform to EDK2 naming convention.
>   + Changed the GopDxe.inf name to the meaningful ASpeedAst2500GopDxe.inf
> 
> Nhi Pham (1):
>   Drivers/ASpeed: Add ASpeed AST2500 GOP driver
> 

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 3d1bb660664b..0733fa29ec00



>  .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf   |  19 +++++++++++++
>  .../AArch64/ASpeedAst2500Gop.efi              | Bin 0 -> 42880 bytes
>  Drivers/ASpeed/License.txt                    |  25 ++++++++++++++++++
>  3 files changed, 44 insertions(+)
>  create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
>  create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2500Gop.efi
>  create mode 100644 Drivers/ASpeed/License.txt
>