From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web10.8593.1606994655678838082 for ; Thu, 03 Dec 2020 03:24:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ylrFdzcK; spf=pass (domain: nuviainc.com, ip: 209.85.221.53, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f53.google.com with SMTP id 23so1490943wrc.8 for ; Thu, 03 Dec 2020 03:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=I+LkEWlX++Z32UCLO11whLAHzuVEC83gr7N+WMBMxPs=; b=ylrFdzcKJSYXw+8LQmSWINorNpkz1m4yZYltRPw1j8cGWuQZj+MUofvY+J9UbmSQdG MFIegkQqF6MWDj4e+HjaQnq8BlXG7JvKG/+EdIMOsq6D9Jv20oSyl9ETD5CNTbRioezB ZiGeBpZUVv9ORjfo4Yj0rAHlw703lg99HKyqR3fJvmJ+KVM3RGXjI/2EZ6hCSPRasX5p lA67h5AXbIgWY+HgxybqtESD8rmsYANhpFNniETdhfrHY7vzIW+f8PJSOxMAVopSrK5c vKgja4cTJux7i9k+j6S1Fnrvx+84RgQnWVyd/+capVb2ne6NJiGeQImy6TuiC4ccwczR qJ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=I+LkEWlX++Z32UCLO11whLAHzuVEC83gr7N+WMBMxPs=; b=bERNbZayNG8xmghwrxWnQM9W3zJAuhwCePjz+hUsk/vuNCFkJsSkMHYpnMNIX17oY2 6KKuJ+vN9+mLJ9U9ZFq9hVFIO1lQLz5DHz0Wnt8D4G2UZN5gk/PFVt/ZkrUymjmOw3tp 35sxuMN93q2xbRc6u6eIoui5epd2vDG9PXGzYzmXdzUxJoKdbCjrz4Mkf3cJALqXcCMN INdnCzpKws7A6mkZF6OooCrZFdxQcMeDYY7+NHpsckNbF7V08Ij+BmmswrKNmwYErSiD 9OZtj0Rb6lHRwS86u0nVOYW1LoZh/orMGfFRbkVi3mvfashQB96vXJRK9mTSXAtjgjW1 2D9A== X-Gm-Message-State: AOAM5332v7lvCQeSKpBXYTv7NjGS5xM9taqhxYQCRxkvau2OuEpQGLFx 626e6fM0RaBeZoy/rpLZ1AxlfVuO0enT2PbS88angRoy/v2smbLBRWxnMvV/N9AZSDEuO5RoiXG 38eCRt7dCyCktgvbY8l+/EITn3RGEdt6r8fQvu8bEI8g5b4OC9rUd4Fiz3rj2uKo/pCLD X-Google-Smtp-Source: ABdhPJzwfFADJCL4d+P2DkRHrF9MjIbgIIQLlEqZhcqx8XQDD/6mbzadHT/W5C4ClymPF8CgJmJWeA== X-Received: by 2002:adf:f881:: with SMTP id u1mr3111726wrp.103.1606994653728; Thu, 03 Dec 2020 03:24:13 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id i16sm1439031wru.92.2020.12.03.03.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 03:24:10 -0800 (PST) Date: Thu, 3 Dec 2020 11:24:08 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: rebecca@nuviainc.com, 'Michael D Kinney' , 'Zhiguang Liu' , 'Laszlo Ersek' Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCAwLzNdIE1kZVBrZzogZml4IHR5cG9zIGluIFNtQmlvcy5o?= Message-ID: <20201203112408.GP1664@vanye> References: <20201202190325.20310-1-rebecca@nuviainc.com> <005b01d6c912$2d94d050$88be70f0$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: <005b01d6c912$2d94d050$88be70f0$@byosoft.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Liming, These aren't randomly named fields, they are incorrect representations of an industry standard. We are now in the period just after stable tag, breaking platforms is perfectly acceptable. Also, we just happily broke all known platforms during soft freeze by merging the VariablePolicy set. / Leif On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote: > Rebecca: > I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms. > There are many platform SmbiosDxe driver to depend on them. > So, this change impacts widely. This change is just to rename field name. > There is no real functionality change. I suggest to add comments for those > typo fields instead of changing them. > > Thanks > Liming > > -----邮件原件----- > > 发件人: bounce+27952+68193+4905953+8761045@groups.io > > 代表 Rebecca Cran > > 发送时间: 2020年12月3日 3:03 > > 收件人: devel@edk2.groups.io > > 抄送: Rebecca Cran ; Michael D Kinney > > ; Liming Gao ; > > Zhiguang Liu > > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h > > > > Since the edk2-stable202011 tag has been created, I'm resubmitting the > > SmBios.h typo fixes. > > > > Rebecca Cran (3): > > MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS > > struct > > MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field > > ProcessorManufacturer > > MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field > > FirmwareVersion > > > > MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++---------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > -- > > 2.26.2 > > > > > > > > > > > > > > > > > >