From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.9359.1606999983765509586 for ; Thu, 03 Dec 2020 04:53:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UjEwJdLP; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id k10so2633203wmi.3 for ; Thu, 03 Dec 2020 04:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tV2WRKWpr0yVgIVb0I95iGguGgl/iaB0sjmX1x6aV3w=; b=UjEwJdLPO1Fx66pYdcoHcR2FScOm5Lw0hmoIvMvZB3pCoKt47FoHVXge31AmT/tGDR XLg/Ql1HfNYBE98lZD3zPGrZ4IMEgZqySjHPMuDsmNsRyZU0fRwsbPt8zidhfu14pkdy pUPa8mgY3pFmow5lbBashElz6ndsm2MCZhpO9gS+NY31XA1Zpi3WgqZypRtGRaAyEk5H acJ6woo0mkPJe2Bw5fzLNZi0rEJ2j51HTC4maQ3uMd5C0XAz7mjG7ICLDt6+bn5dsddN nbmJwR5dyHolTRaE4wgkDCvK80zuCS8AdomWRvUWAzhRAncRvVGRl7TRQXMMWWmD3f8A N0vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tV2WRKWpr0yVgIVb0I95iGguGgl/iaB0sjmX1x6aV3w=; b=XDCmCDQWiNBXcPlZzINrZ3N0rLNBPVUEiG7AIud7IjqoqqI3TTjlDmAlb6yRGkaOww t7E6nXsRpgc6aNwcKloaRqO386SVQKLhmcOIrPkUDYb7T2bWPyfnh5yJAVeL3WMMwfne AliETfpNq4YRLUCPc0pJVo5vThViMZ+UCo6fAIp8CTFs088Gs7Wf2ulBsp2n+uYuMa/c MAD9YZQUeBlhRzb6C81sh64tYaaJ7tB13CL8ZWJi+l1vjZO/yUuUrnFLqNdl74wTq0wk ByvTVNnhwofmwDgks+8Ngmd2HHPJYCS07n/xoEG120FPI4wOVMPbJ3YkdC2QT63eQFK3 UU8Q== X-Gm-Message-State: AOAM5336kr9ZndMBNudMsqIaWAlKm1vfcttl9N3UPvoy14/ZLcC+Yd3C TiaCC2d2rbklhY+OVock6/0ocn7lRsbIdtl6AQTFFE/0NE5/x5frIY+P8qHMhjt6Rnyap/PxZFl brNBwt8i5swrTWsCp9GbIvnrvFHACN1wWSfV5a7vKGj4WwaSt9mYjTv5IT96yaOEc7DXU X-Google-Smtp-Source: ABdhPJyQA5dTVhiIZ9NRd+NvH8aPig/Gk64Kb8mAbIUB1Zde44R4ZtUsGCyac3TNA2hzcd69juEsoA== X-Received: by 2002:a1c:9e41:: with SMTP id h62mr3228991wme.51.1606999981911; Thu, 03 Dec 2020 04:53:01 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id c2sm1607207wrv.41.2020.12.03.04.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 04:53:01 -0800 (PST) Date: Thu, 3 Dec 2020 12:52:59 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, nhi@os.amperecomputing.com Subject: Re: [edk2-devel] [edk2-platforms][PATCH 0/3] Introduce Ampere Mt. Jade support to edk2-platforms Message-ID: <20201203125259.GS1664@vanye> References: <20201203114602.GQ1664@vanye> <6521.1606997727161006207@groups.io> MIME-Version: 1.0 In-Reply-To: <6521.1606997727161006207@groups.io> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Nhi, On Thu, Dec 03, 2020 at 04:15:27 -0800, Nhi Pham via groups.io wrote: > Hi Leif, > > Please find my response inline. > > On Thu, Dec 3, 2020 at 06:46 PM, Leif Lindholm wrote: > > > > > On Thu, Dec 03, 2020 at 11:03:59 +0700, Nhi Pham wrote: > > > >> This short patch series introduces the support for Ampere Computing's > >> Arm64 hardware platforms, > > > > Well, it doesn't really, does it? > > It adds a Maintainers.txt entry, a Readme.md describing a fork > > somewhere, and links that Readme into the top-level one. > > > > I think it's great you've posted it here for people to see, but can > > you clarify your intent somewhat? > > Is this a precursor to a full upstreaming effort? > > Yes, this patch series works as bootstrap that we will push all > Mt. Jade code in one shot (about 35 commits) to the edk2-platforms > for review after this is approved and merged. This series provides > Maintainers and Reviewers in the Maintainer.txt who are responsible > for giving code review feedback (Reviewed-by tag) if stewards can > not review a large patch series. Glad to hear it! However, can we keep the Platform/Ampere/Readme.md aligned with what is currentlt merged in edk2-platforms? I have given some feedback on that file directly, but I think given the above statement it would be more appropriate to start with a very small document describing that upstreaming is in progress, and a link to https://github.com/AmpereComputing/edk2-platforms/blob/ampere/Platform/Ampere/Readme.md . Best Regards, Leif > > Thanks, > Nhi > > > > > > > I don't see a point in merging just this, although I can (and will) > > provide some feedback on the documentation. > > > > Best Regards, > > > > Leif > > > > > >> specifically the Mt. Jade platform based on > >> Ampere's Altra Family processor at this moment. > >> > >> A public fork of EDK2 for supporting Mt. Jade is currently available at > >> https://github.com/AmpereComputing/edk2-platforms > >> > >> Cc: Leif Lindholm > >> Cc: Michael D Kinney > >> Cc: Ard Biesheuvel > >> Cc: Nate DeSimone > >> > >> Nhi Pham (1): > >> Maintainers.txt: Update for Ampere platforms > >> > >> Phong Vo (2): > >> Platform/Ampere: Add Readme.md > >> Update Readme.md > >> > >> Maintainers.txt | 6 + > >> Platform/Ampere/Readme.md | 167 ++++++++++++++++++++ > >> Readme.md | 3 + > >> 3 files changed, 176 insertions(+) > >> create mode 100644 Platform/Ampere/Readme.md > >> > >> -- > >> 2.17.1 > > > > > > > > >