From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.859.1607019601357518777 for ; Thu, 03 Dec 2020 10:20:01 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F8BA11FB; Thu, 3 Dec 2020 10:20:01 -0800 (PST) Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9D8173F575; Thu, 3 Dec 2020 10:19:59 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [PATCH v1 01/16] ArmPlatformPkg: Fix Ecc error 3001 in NorFlashDxe Date: Thu, 3 Dec 2020 18:19:30 +0000 Message-Id: <20201203181945.10880-2-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: Boolean values and variable type BOOLEAN should not use explicit comparisons to TRUE or FALSE Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c index d9e196cbf18c32fe5306cc3c0674a7b5798a9191..b681c4b4668630de8a9585363a328b3e3f1bc324 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c @@ -1,6 +1,6 @@ /** @file NorFlashDxe.c - Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -259,7 +259,7 @@ NorFlashUnlockSingleBlockIfNecessary ( Status = EFI_SUCCESS; - if (NorFlashBlockIsLocked (Instance, BlockAddress) == TRUE) { + if (NorFlashBlockIsLocked (Instance, BlockAddress)) { Status = NorFlashUnlockSingleBlock (Instance, BlockAddress); } -- 2.17.1