[edk2-platforms][PATCH v2 0/3] Introduce Ampere Mt. Jade support

[edk2-platforms][PATCH v2 0/3] Introduce Ampere Mt. Jade support

[Nhi Pham]

Ampere would like to contribute our Mt. Jade's implementation to the
Tianocore community. Mt. Jade is Ampere’s  hardware reference platform
based on the Ampere Altra 80-core arm64 SoC. The purpose of this patch
series is to create the precursor for subsequent merging of Ampere's
Tianocore fork at https://github.com/AmpereComputing/edk2-platforms.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Version History
v1->v2:
  * Updated Platform/Ampere/Readme.md per Leif's comments

Nhi Pham (1):
  Maintainers.txt: Update for Ampere platforms

Phong Vo (2):
  Platform/Ampere: Add Readme.md
  Update Readme.md

 Maintainers.txt           |  8 ++++
 Platform/Ampere/Readme.md | 39 ++++++++++++++++++++
 Readme.md                 |  3 ++
 3 files changed, 50 insertions(+)
 create mode 100644 Platform/Ampere/Readme.md

-- 
2.17.1

[edk2-platforms][PATCH v2 1/3] Platform/Ampere: Add Readme.md

[Nhi Pham]

From: Phong Vo <phong@os.amperecomputing.com>

Add initial version of Readme.md for Ampere platform

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
---
 Platform/Ampere/Readme.md | 39 ++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/Platform/Ampere/Readme.md b/Platform/Ampere/Readme.md
new file mode 100644
index 000000000000..894bad3437b8
--- /dev/null
+++ b/Platform/Ampere/Readme.md
@@ -0,0 +1,39 @@
+# Introduction
+
+This document provides the guideline to build UEFI firmware for Ampere Computing's Arm64 reference platforms.
+
+Platform code is located under Platform/Ampere/{Platform Name}Pkg.
+
+Silicon code is located under Silicon/Ampere/Ampere{SoC Name}Pkg.
+
+# Build machines
+
+- x86 Linux host machines running latest Ubuntu or CentOS releases.
+- Arm64 Linux host machines if native compiling. This has been tested on Ampere's eMAG and Altra hardware platforms with latest AArch64 CentOS or Ubuntu releases.
+
+# How to build (Linux Environment)
+
+Please follow top-level Readme.md for build instructions.
+
+## Additional build tools
+
+Ampere provides additional tools and documentation for automating the manual process described as described in the top-level README.md,
+and for building a final Tianocore UEFI image that can be flashed onto the target system.
+
+To use these tools, clone the following to the **WORKSPACE** location:
+
+```bash
+$ git clone https://github.com/AmpereComputing/edk2-ampere-tools.git
+```
+
+## Notes
+
+If you run into any build issue with the Intel ASL+ Optimizing Compiler/Disassembler (IASL) that comes with your Linux distro,
+download and install the IASL compiler from https://acpica.org/. At the time of this write-up, we have tested with version 20200110.
+
+```bash
+$ wget https://acpica.org/sites/acpica/files/acpica-unix2-20200110.tar.gz
+$ tar xzf acpica-unix2-20200110.tar.gz
+$ cd acpica-unix2-20200110
+$ make HOST=_CYGWIN && sudo make install
+```
-- 
2.17.1

[edk2-platforms][PATCH v2 2/3] Update Readme.md

[Nhi Pham]

From: Phong Vo <phong@os.amperecomputing.com>

Update Readme.md with information about Ampere's Mt. Jade platform

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
---
 Readme.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Readme.md b/Readme.md
index d896b2c5fcdf..d00600d35018 100644
--- a/Readme.md
+++ b/Readme.md
@@ -223,6 +223,9 @@ they will be documented with the platform.
 * [Overdrive](Platform/AMD/OverdriveBoard)
 * [Overdrive 1000](Platform/SoftIron/Overdrive1000Board)
 
+## [Ampere](Platform/Ampere/Readme.md)
+* [Mt. Jade](Platform/Ampere/JadePkg)
+
 ## [ARM](Platform/ARM/Readme.md)
 * [Juno](Platform/ARM/JunoPkg)
 * [SGI family](Platform/ARM/SgiPkg)
-- 
2.17.1

[edk2-platforms][PATCH v2 3/3] Maintainers.txt: Update for Ampere platforms

[Nhi Pham]

This change adds maintainers and reviewers for Ampere platforms.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
 Maintainers.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index da90c8a11452..4b21dc9805fb 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -91,6 +91,14 @@ F: Silicon/AMD/Styx/
 M: Ard Biesheuvel <ard.biesheuvel@arm.com>
 M: Leif Lindholm <leif@nuviainc.com>
 
+Ampere Computing
+F: Platform/Ampere
+F: Silicon/Ampere
+M: Nhi Pham <nhi@os.amperecomputing.com>
+M: Vu Nguyen <vunguyen@os.amperecomputing.com>
+R: Thang Nguyen <thang@os.amperecomputing.com>
+R: Chuong Tran <chuong@os.amperecomputing.com>
+
 ARM
 F: Platform/ARM/
 F: Silicon/ARM/
-- 
2.17.1

Re: [edk2-platforms][PATCH v2 3/3] Maintainers.txt: Update for Ampere platforms

[Leif Lindholm]

On Fri, Dec 04, 2020 at 20:07:52 +0700, Nhi Pham wrote:
> This change adds maintainers and reviewers for Ampere platforms.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> ---
>  Maintainers.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index da90c8a11452..4b21dc9805fb 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -91,6 +91,14 @@ F: Silicon/AMD/Styx/
>  M: Ard Biesheuvel <ard.biesheuvel@arm.com>
>  M: Leif Lindholm <leif@nuviainc.com>
>  
> +Ampere Computing
> +F: Platform/Ampere
> +F: Silicon/Ampere
> +M: Nhi Pham <nhi@os.amperecomputing.com>
> +M: Vu Nguyen <vunguyen@os.amperecomputing.com>

We tend to reserve the M role for maintainers, with write access to
the repository. If that's something you're interested in becoming, we
can have a discussion on the side.

However, for now, could I add myself as M: to this section, and change
the M: entries to R:?

Regards,

Leif

> +R: Thang Nguyen <thang@os.amperecomputing.com>
> +R: Chuong Tran <chuong@os.amperecomputing.com>
> +
>  ARM
>  F: Platform/ARM/
>  F: Silicon/ARM/
> -- 
> 2.17.1
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/3] Maintainers.txt: Update for Ampere platforms

[Nhi Pham]

On Tue, Dec  8, 2020 at 07:45 PM, Leif Lindholm wrote:

>
> On Fri, Dec 04, 2020 at 20:07:52 +0700, Nhi Pham wrote:
> > This change adds maintainers and reviewers for Ampere platforms.
> > 
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > 
> > Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> > ---
> >  Maintainers.txt | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index da90c8a11452..4b21dc9805fb 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -91,6 +91,14 @@ F: Silicon/AMD/Styx/
> >  M: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >  M: Leif Lindholm <leif@nuviainc.com>
> >
> > +Ampere Computing
> > +F: Platform/Ampere
> > +F: Silicon/Ampere
> > +M: Nhi Pham <nhi@os.amperecomputing.com>
> > +M: Vu Nguyen <vunguyen@os.amperecomputing.com>
> 
> We tend to reserve the M role for maintainers, with write access to
> the repository. If that's something you're interested in becoming, we
> can have a discussion on the side.
> 
> However, for now, could I add myself as M: to this section, and change
> the M: entries to R:?

OK, Leif.

-Nhi
> 
> Regards,
> 
> Leif
> 
> > +R: Thang Nguyen <thang@os.amperecomputing.com>
> > +R: Chuong Tran <chuong@os.amperecomputing.com>
> > +
> >  ARM
> >  F: Platform/ARM/
> >  F: Silicon/ARM/
> > -- 
> > 2.17.1
> > 
>

Re: [edk2-platforms][PATCH v2 0/3] Introduce Ampere Mt. Jade support

[Leif Lindholm]

On Fri, Dec 04, 2020 at 20:07:49 +0700, Nhi Pham wrote:
> Ampere would like to contribute our Mt. Jade's implementation to the
> Tianocore community. Mt. Jade is Ampere’s  hardware reference platform
> based on the Ampere Altra 80-core arm64 SoC. The purpose of this patch
> series is to create the precursor for subsequent merging of Ampere's
> Tianocore fork at https://github.com/AmpereComputing/edk2-platforms.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

For the series (with the discussed update to Maintainers.txt):
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 100e360ab522..c5523bd3cfe2.

> 
> Version History
> v1->v2:
>   * Updated Platform/Ampere/Readme.md per Leif's comments
> 
> Nhi Pham (1):
>   Maintainers.txt: Update for Ampere platforms
> 
> Phong Vo (2):
>   Platform/Ampere: Add Readme.md
>   Update Readme.md
> 
>  Maintainers.txt           |  8 ++++
>  Platform/Ampere/Readme.md | 39 ++++++++++++++++++++
>  Readme.md                 |  3 ++
>  3 files changed, 50 insertions(+)
>  create mode 100644 Platform/Ampere/Readme.md
> 
> -- 
> 2.17.1
>