* [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
@ 2020-12-04 18:11 Wadhawan, Divneil R
2020-12-05 1:43 ` Michael D Kinney
0 siblings, 1 reply; 4+ messages in thread
From: Wadhawan, Divneil R @ 2020-12-04 18:11 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Sean Brogan, Bret Barkelew
o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
required in building of MdeModulePkg
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
---
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
index 96e40e973c..0dabd6a6f3 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
@@ -12,7 +12,7 @@
FILE_GUID = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
VERSION_STRING = 1.0
MODULE_TYPE = UEFI_DRIVER
- LIBRARY_CLASS = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
+ LIBRARY_CLASS = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_DRIVER UEFI_APPLICATION
[Sources]
UnitTestLib.c
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
2020-12-04 18:11 [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib Wadhawan, Divneil R
@ 2020-12-05 1:43 ` Michael D Kinney
2020-12-05 2:03 ` Michael D Kinney
0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2020-12-05 1:43 UTC (permalink / raw)
To: Wadhawan, Divneil R, devel@edk2.groups.io, Kinney, Michael D
Cc: Sean Brogan, Bret Barkelew
Divneil,
Thank you for reposting with a correct commit message and email format.
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> Sent: Friday, December 4, 2020 10:12 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
>
> o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
> required in building of MdeModulePkg
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> ---
> UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> index 96e40e973c..0dabd6a6f3 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> @@ -12,7 +12,7 @@
> FILE_GUID = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
> VERSION_STRING = 1.0
> MODULE_TYPE = UEFI_DRIVER
> - LIBRARY_CLASS = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
> + LIBRARY_CLASS = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> SMM_CORE UEFI_DRIVER UEFI_APPLICATION
>
> [Sources]
> UnitTestLib.c
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
2020-12-05 1:43 ` Michael D Kinney
@ 2020-12-05 2:03 ` Michael D Kinney
2020-12-07 5:45 ` Wadhawan, Divneil R
0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2020-12-05 2:03 UTC (permalink / raw)
To: Wadhawan, Divneil R, devel@edk2.groups.io, Kinney, Michael D
Cc: Sean Brogan, Bret Barkelew
Merged
https://github.com/tianocore/edk2/pull/1182
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, December 4, 2020 5:44 PM
> To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: RE: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
>
> Divneil,
>
> Thank you for reposting with a correct commit message and email format.
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Mike
>
>
> > -----Original Message-----
> > From: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > Sent: Friday, December 4, 2020 10:12 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>
> > Subject: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
> >
> > o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
> > required in building of MdeModulePkg
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > ---
> > UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > index 96e40e973c..0dabd6a6f3 100644
> > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > @@ -12,7 +12,7 @@
> > FILE_GUID = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
> > VERSION_STRING = 1.0
> > MODULE_TYPE = UEFI_DRIVER
> > - LIBRARY_CLASS = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
> > + LIBRARY_CLASS = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> > SMM_CORE UEFI_DRIVER UEFI_APPLICATION
> >
> > [Sources]
> > UnitTestLib.c
> > --
> > 2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
2020-12-05 2:03 ` Michael D Kinney
@ 2020-12-07 5:45 ` Wadhawan, Divneil R
0 siblings, 0 replies; 4+ messages in thread
From: Wadhawan, Divneil R @ 2020-12-07 5:45 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Sean Brogan, Bret Barkelew, Wadhawan, Divneil R
Thanks Mike for helping out with the process.
Regards,
Divneil
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Saturday, December 5, 2020 7:34 AM
To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: RE: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
Merged
https://github.com/tianocore/edk2/pull/1182
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, December 4, 2020 5:44 PM
> To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>;
> devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: RE: [Patch V2] UnitTestFrameworkPg: Fix build failure of
> MdeModulePkg with UnitTestLib
>
> Divneil,
>
> Thank you for reposting with a correct commit message and email format.
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Mike
>
>
> > -----Original Message-----
> > From: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > Sent: Friday, December 4, 2020 10:12 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan
> > <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>
> > Subject: [Patch V2] UnitTestFrameworkPg: Fix build failure of
> > MdeModulePkg with UnitTestLib
> >
> > o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
> > required in building of MdeModulePkg
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > ---
> > UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > index 96e40e973c..0dabd6a6f3 100644
> > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > @@ -12,7 +12,7 @@
> > FILE_GUID = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
> > VERSION_STRING = 1.0
> > MODULE_TYPE = UEFI_DRIVER
> > - LIBRARY_CLASS = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
> > + LIBRARY_CLASS = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> > SMM_CORE UEFI_DRIVER UEFI_APPLICATION
> >
> > [Sources]
> > UnitTestLib.c
> > --
> > 2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-07 5:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-04 18:11 [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib Wadhawan, Divneil R
2020-12-05 1:43 ` Michael D Kinney
2020-12-05 2:03 ` Michael D Kinney
2020-12-07 5:45 ` Wadhawan, Divneil R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox