From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by mx.groups.io with SMTP id smtpd.web10.612.1607365437966316368 for ; Mon, 07 Dec 2020 10:23:58 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: nuviainc.com, ip: 209.85.166.200, mailfrom: rebecca@nuviainc.com) Received: by mail-il1-f200.google.com with SMTP id u17so13717648ilb.4 for ; Mon, 07 Dec 2020 10:23:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lbsvRo2k3jdxjzs61FrVoSf2SPpge+aKyFjQEF1Zg1Y=; b=SsuRKpGuxuH4zYHrF0CVDa+JnbiIylRgcSBmdppQCjBB1A+QOQAY9dHFoZ43HRnKFZ j+AcdUslqhtkuurhVwyAtyblBkJ4fMoWHUq5dMEhFw7X2d74er8bkr7Tdu7dki2ZZblc F74yzOUmhP+WvE/Use+ykADpAbA/l99JhXWcEKDHklWTY6+yCAZlBAjp+ZTGl8bIWk3Z 6qxAePGFzvef6PpC4kTJzrXxwp1gioLXQD+sOm9W0l7IJwtsP/+YB9sKRs6CKoE5QiFK ePieEOv6aq/oytMzBKYJdylWFsVQHSMW9XwKQsRU7yt4uXDVhj+xKvjg5RvYry4HPv9z ATTw== X-Gm-Message-State: AOAM532Edu/ianNhU/bUj/8pwZ0sRI9imEnASmt5V0OYU3LgYaLZP7u6 Pl2wgvcT9228f1KFPbcdugY+WLRdCZWShAUoj4bKWpUM6FIes2qHcclR76jT60TjjP3uvRI7eHd mZMCwF/TwQhxOR0tOjgMOx3+GzDI5ZocqK+92b5ETHS6f98kMv3rkJzRV/z4nMSbx2kv68rC4qq yAJ5UH148a5pgh X-Google-Smtp-Source: ABdhPJx4VhGLrp9BiQbGxBzqjlnj1+hMMkUIU4kxRE0P1ms9yfNImRGCSn9t0F6+ArL5z9Aa2WXZ/dIzNOYdKmXcfo3xaPYof7q1tg== X-Received: by 2002:a05:6e02:f0f:: with SMTP id x15mr23539035ilj.12.1607365436273; Mon, 07 Dec 2020 10:23:56 -0800 (PST) Return-Path: Received: from cube.nuviainc.com (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id s189sm11618292pfb.60.2020.12.06.18.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 18:25:34 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Michael D Kinney , Leif Lindholm , Laszlo Ersek , Andrew Fish Subject: [edk2-CCodingStandardsSpecification PATCH 1/1] Update the Name Space Rules page examples to follow the coding standard Date: Sun, 6 Dec 2020 19:25:20 -0700 Message-Id: <20201207022520.7963-1-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The examples in the 45_name_space_rules.md files doesn't follow the coding standard in the following ways: - Only use UEFI data types. Use of standard C data types is prohibited. - Identifiers shall contain mixed upper- and lower-case text. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- 4_naming_conventions/45_name_space_rules.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/4_naming_conventions/45_name_space_rules.md b/4_naming_conventions/45_name_space_rules.md index 1234250756cc..ecdebbe28339 100644 --- a/4_naming_conventions/45_name_space_rules.md +++ b/4_naming_conventions/45_name_space_rules.md @@ -53,9 +53,9 @@ tags may be reused only for union types. ```c typedef struct MyStruct { - int one; - int two; - int three; + UINT32 One; + UINT32 Two; + UINT32 Three; } MY_STRUCT; ``` @@ -68,14 +68,14 @@ Exceptions are structure member and union member names. ```c typedef struct StructOne { - INT32 one; - INT16 two; + INT32 One; + INT16 Two; struct StructOne *MySelf; } STRUCT_ONE; typedef struct StructTwo { - INT16 one; - INT8 *two; + INT16 One; + INT8 *Two; struct StructTwo *MySelf; } STRUCT_TWO; -- 2.26.2