From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library
Date: Mon, 7 Dec 2020 17:11:21 +0000 [thread overview]
Message-ID: <20201207171121.GE1664@vanye> (raw)
In-Reply-To: <d509676b-71df-8968-6177-729eb997e79a@nuviainc.com>
On Sun, Dec 06, 2020 at 21:59:48 -0700, Rebecca Cran wrote:
> On 11/19/20 5:58 AM, Leif Lindholm wrote:
>
> > > +#define MAX_HANDLE_COUNT 0x10
> > Why?
> > Does this belong in a generic header?
>
> It's an arbitrary value, since the SMBIOS protocol doesn't have a way of
> letting you know how many records of a certain type are available without
> iterating through them. It might be better to just iterate twice.
Sadly, yes.
Avoiding hard-coding of sizes is worth some extra code.
/
Leif
prev parent reply other threads:[~2020-12-07 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 0:17 [PATCH v3 0/3] ArmPkg,MdePkg: Add Universal/Smbios and Drivers/VersionInfoPeim Rebecca Cran
2020-11-11 0:17 ` [PATCH v3 1/3] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Rebecca Cran
2020-11-12 21:49 ` [edk2-devel] " Sami Mujawar
2020-11-19 12:00 ` Leif Lindholm
2020-11-11 0:17 ` [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with processor status data Rebecca Cran
2020-11-11 1:18 ` 回复: " gaoliming
2020-11-13 11:25 ` [edk2-devel] " Sami Mujawar
2020-11-19 12:05 ` Leif Lindholm
2020-11-11 0:17 ` [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library Rebecca Cran
2020-11-16 13:43 ` [edk2-devel] " Sami Mujawar
2020-11-17 3:27 ` Rebecca Cran
2020-11-19 12:58 ` Leif Lindholm
2020-12-07 4:59 ` Rebecca Cran
2020-12-07 17:11 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207171121.GE1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox