From: "Leif Lindholm" <leif@nuviainc.com>
To: Vu Nguyen <vunguyen@os.amperecomputing.com>
Cc: devel@edk2.groups.io, patches@amperecomputing.com,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-non-osi][PATCH v2 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package
Date: Tue, 8 Dec 2020 14:11:22 +0000 [thread overview]
Message-ID: <20201208141122.GM1664@vanye> (raw)
In-Reply-To: <20201203042924.28557-1-vunguyen@os.amperecomputing.com>
Hi Vu,
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
However, I'm not sure it makes sense to push this until there is some
platform in edk2-platforms that makes use of it. So I'm holding off on
that for now.
Best Regards,
Leif
On Thu, Dec 03, 2020 at 11:29:22 +0700, Vu Nguyen wrote:
> This patchset creates edk2-non-osi component holder for Ampere Silicon.
> Included is PciePhyLib library that provides necessary functions to
> initialize PCIe PHY on ARM64-based Ampere Altra processor. This library
> will be used by all Ampere Altra platforms later.
>
> The changes for this patchset can be found at:
> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib-v2
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
>
> Version History:
> V2:
> Remove PciePhyLib.lib binary from the commit
> Update header guard to align with coding standard
>
> Vu Nguyen (2):
> AmpereAltraBinPkg: Add PciePhyLib library and header
> edk2-non-osi: Add AmpereAltraBinPkg maintainers
>
> Maintainers.txt | 4 +
> Silicon/Ampere/License.txt | 25 +++
> .../Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec | 16 ++
> .../Library/PciePhyLib/PciePhyLib.inf | 23 +++
> .../Include/Library/PciePhyLib.h | 165 ++++++++++++++++++
> .../Library/PciePhyLib/PciePhyLib.lib | Bin 0 -> 26026 bytes
> 6 files changed, 233 insertions(+)
> create mode 100644 Silicon/Ampere/License.txt
> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec
> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.lib
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-12-08 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 4:29 [edk2-non-osi][PATCH v2 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package Vu Nguyen
2020-12-03 4:29 ` [edk2-non-osi][PATCH v2 1/2] AmpereAltraBinPkg: Add PciePhyLib library and header Vu Nguyen
2020-12-03 4:29 ` [edk2-non-osi][PATCH v2 2/2] edk2-non-osi: Add AmpereAltraBinPkg maintainers Vu Nguyen
2020-12-08 14:11 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208141122.GM1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox