From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.2950.1607497202774700380 for ; Tue, 08 Dec 2020 23:00:03 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: aaron.li@intel.com) IronPort-SDR: KSQOZeKneh8MB/zGZDE/14+njlCPeeTWpL98I4NTe8C5oocQTfVsRpaYv5IqIyqOHf+WZa+j0+ sl6Eqsauve9w== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="192330111" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="192330111" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 23:00:01 -0800 IronPort-SDR: b70JV0mLJf0tjDiqeb5wJ4sMry097fzJtszpJlEvPfESkHVAgqjDBXwb4rYpLGLuNeV2hRf1FN KrugrfMayydg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="318156826" Received: from sh1gapp1015.ccr.corp.intel.com ([10.239.189.85]) by fmsmga008.fm.intel.com with ESMTP; 08 Dec 2020 23:00:00 -0800 From: "Aaron Li" To: devel@edk2.groups.io Cc: Ray Ni , Rangasai V Chaganty , Siyuan Fu Subject: [PATCH v2 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Date: Wed, 9 Dec 2020 14:59:48 +0800 Message-Id: <20201209065948.6852-1-aaron.li@intel.com> X-Mailer: git-send-email 2.29.2.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ShadowMicrocode should return EFI_NOT_FOUND when no valid Microcode found in FIT table. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3110 Signed-off-by: Aaron Li Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Siyuan Fu --- Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.c= | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMi= crocodePei.c b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/Shadow= MicrocodePei.c index 5c7ee6910c8e..1494397a8e36 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocode= Pei.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocode= Pei.c @@ -377,6 +377,9 @@ IsValidFitTable ( with microcode patches data in it.=0D =0D @retval EFI_SUCCESS The microcode has been shadowed to memo= ry.=0D + @retval EFI_INVALID_PARAMETER BufferSize or Buffer is NULL.=0D + @retval EFI_INVALID_PARAMETER CpuIdCount not equal to 0 and Microcode= CpuId is NULL.=0D + @retval EFI_NOT_FOUND No valid microcode found.=0D @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of reso= urces.=0D =0D **/=0D @@ -390,6 +393,7 @@ ShadowMicrocode ( OUT VOID **Buffer=0D )=0D {=0D + EFI_STATUS Status;=0D UINT64 FitPointer;=0D FIRMWARE_INTERFACE_TABLE_ENTRY *FitEntry;=0D UINT32 EntryNum;=0D @@ -460,10 +464,13 @@ ShadowMicrocode ( ));=0D =0D ShadowMicrocodePatchWorker (PatchInfoBuffer, PatchCount, TotalLoadSize= , BufferSize, Buffer);=0D + Status =3D EFI_SUCCESS;=0D + } else {=0D + Status =3D EFI_NOT_FOUND;=0D }=0D =0D FreePool (PatchInfoBuffer);=0D - return EFI_SUCCESS;=0D + return Status;=0D }=0D =0D =0D --=20 2.29.2.windows.2