From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.42]) by mx.groups.io with SMTP id smtpd.web11.451.1607539669901544105 for ; Wed, 09 Dec 2020 10:47:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=BfNUwENt; spf=pass (domain: arm.com, ip: 40.107.21.42, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IECaqLUMrxThwxnoukvf1s/TwMGDwy5UewrK0okJOFM=; b=BfNUwENt3HtXaswCP9CC/BPqNPWmXcFRfbMvgT3nbnd1VpPkZOuAu/7qfj6jQOtPKM61xCMG5YEEgnXBFJusS9DB0xhQcl3zDfsM0BnCQ1XWvEQHkvUWzCGQbqvest2DVlv7+0lOc22jbdgi6kt6Y4zzQth8cc/H6TONVqLY58Q= Received: from AM5PR0502CA0006.eurprd05.prod.outlook.com (2603:10a6:203:91::16) by AM0PR08MB3249.eurprd08.prod.outlook.com (2603:10a6:208:5d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.28; Wed, 9 Dec 2020 18:47:47 +0000 Received: from AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::8c) by AM5PR0502CA0006.outlook.office365.com (2603:10a6:203:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT051.mail.protection.outlook.com (10.152.16.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:46 +0000 Received: ("Tessian outbound 8b6e0bb22f1c:v71"); Wed, 09 Dec 2020 18:47:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5b5eb9b02f54d45e X-CR-MTA-TID: 64aa7808 Received: from b18bc4840a4f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1413BD28-147A-4135-957F-DC5542D2E2A0.1; Wed, 09 Dec 2020 18:47:28 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b18bc4840a4f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Dec 2020 18:47:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dvea2Ztxi8OSEZiKQpzsYBz2/VqL9AOGzp+njTuHRjG7UUjSKbxoik7aHWx+6RVpXGZ7+gdvGZNp99jxKaT5iyJq2QmhYbPu2cBXfRL4qT8Lz3YalrNT/Jg8qc8BlaW6rJpAXYV3DNSfpFyyZq0YsrjJqXpTYXKSALKK8eFJSaKSiHxQJoB8iUi2i8RVZk3/pZZSSC62vau7tT71UYlCTB2oRUAxNiHO2DFT9/Hc/ijm79bQUXTjCJ3G4hiJUBPr2Z2dp4T3J9GWGAhjlbQfTnjcf+SseRkBGMEN6Kmw1V6GVy0nNuSMTfsckHYLm+OaI0E6VQf+0u7rHIHTBM0NQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IECaqLUMrxThwxnoukvf1s/TwMGDwy5UewrK0okJOFM=; b=GUBvUXkAMAFbLuOZaHbme12N/kHqfSGESRUTWvj0CuH6r96HUKzbFjJWw5ykDj2VLxCq4z9BICzWfo9pEOOPVgdq+Lz9OxCH91JekdGtABMel9zOUmuXtE9/fE45yCvN6/giy35W7WkeJn9Im/N5VS9UN9Iq67c+SPGfGFzvgx55DwwbzwdYcHDyElI8YY98tJIVdi367fEMqkMq40QtzyA6OxOITiDI2ur6ZaFKeJkGl/eDPWnLz9ihFTvnjva4K/MgrX7lMzHFLGCdshYk06vt+EPlWrP+ATWwRasGLsNW9DO9+9JIxp7bxEwTF99tnTl4C5DjnNRWWOSJbrPSpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IECaqLUMrxThwxnoukvf1s/TwMGDwy5UewrK0okJOFM=; b=BfNUwENt3HtXaswCP9CC/BPqNPWmXcFRfbMvgT3nbnd1VpPkZOuAu/7qfj6jQOtPKM61xCMG5YEEgnXBFJusS9DB0xhQcl3zDfsM0BnCQ1XWvEQHkvUWzCGQbqvest2DVlv7+0lOc22jbdgi6kt6Y4zzQth8cc/H6TONVqLY58Q= Received: from DB7PR02CA0034.eurprd02.prod.outlook.com (2603:10a6:10:52::47) by VI1PR08MB4525.eurprd08.prod.outlook.com (2603:10a6:803:101::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 18:47:25 +0000 Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::3d) by DB7PR02CA0034.outlook.office365.com (2603:10a6:10:52::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:25 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 9 Dec 2020 18:47:20 +0000 Received: from E107187.Arm.com (10.57.26.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Wed, 9 Dec 2020 18:47:20 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , Subject: [PATCH v1 15/25] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint Date: Wed, 9 Dec 2020 18:47:00 +0000 Message-ID: <20201209184710.20912-16-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201209184710.20912-1-sami.mujawar@arm.com> References: <20201209184710.20912-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f723b65e-2a8b-48aa-3b1c-08d89c72ebd3 X-MS-TrafficTypeDiagnostic: VI1PR08MB4525:|AM0PR08MB3249: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WnDzu5oVyR4064dzHGtv0cYjCdSpS4RuTpABm8D9/1V0Oxbk0M6dCb+wLv0PdM7+2ypyATqedJwQ6E7YEoA4tmJDe2LMy9FJAe4Ylr602ejmXHBRwjsYa3rcP7QxPW0VoKhN9ZbRBjTDG/rVHsTyUFKlHsSdL3Yp7fmDRwL7oTWm4ZAQ1I/SgBsN/6wuLyvXCgqMVAXBnCaYDlkZqlM5ZShrzz3/+vXTaiO7xPd5qtdz7Nvb4TT7YY1Bgk98ix3Xn9B/L6Pbu5KNxMVpUmDw3+RCDWID8oC/kMZ0TlgzUwnTWgixqponiSS7AJlH22l1wxyhFRCVnfwExp6kn37wHzIbumWiktbf0mqbqPRLX2f6QRmQ6pWDW9x83Bc9I1Ymy7g6IdnVjF6CRBWU97TKww== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(376002)(346002)(39860400002)(136003)(396003)(46966005)(86362001)(8936002)(83380400001)(1076003)(26005)(82310400003)(36756003)(336012)(54906003)(6666004)(2906002)(7696005)(4326008)(44832011)(356005)(5660300002)(8676002)(81166007)(2616005)(70586007)(478600001)(426003)(316002)(82740400003)(186003)(6916009)(70206006)(47076004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4525 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ed007c9b-e0a7-4ed6-511b-08d89c72df24 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fvChi9PhBgtmrma2AYbBRoo/cyjhMyZ0bcM9D7zQWJP/l2I8AK3ktLAM7imssRArIl3Yb4qZcCRMaTsJY4FEGlz9pNVeXd6YknjfECRMTnda7l4pXmZWk7+IcP4y+YVNHPGJYac4RpfM9dtUHUKOsv8JeRwdiPViPxBReJpJXnI/uriGT8zm6h/FQlqQVFJzqpWCidZx4+QDEC45n0DRsQ6vAXIxLQSuK4BOM4YakLSmPQpRbEsAVXxkHVoXdVVZoJrP5ZlnuXmS9GTFl3kyA8fAM+crG7QtWUj3RKIskh4DiJb3oBjFDu3EmrAIgOWWpFoCMfG9DF0V4u7kapCb1kAgD4puxZ61AQd9Htt3bry8cV6aMCjx0is+/rAhkl0+WRY6k6Xl1Iv3NpWPHGDBpA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(136003)(376002)(46966005)(81166007)(7696005)(82310400003)(44832011)(70206006)(4326008)(5660300002)(70586007)(426003)(186003)(1076003)(36906005)(8676002)(2616005)(54906003)(8936002)(508600001)(336012)(86362001)(47076004)(83380400001)(26005)(6666004)(6916009)(2906002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2020 18:47:46.8989 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f723b65e-2a8b-48aa-3b1c-08d89c72ebd3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3249 Content-Type: text/plain Fix the ECC reported error "[9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment". Signed-off-by: Sami Mujawar --- StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 13 ++++++++----- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 ++++-- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 7 ++++--- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h b/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h index 34c43897dded9aebe1470f2dbfe96b93590a9e45..b176e56e789b0bc766e48a6083512a9d0ae3ebc3 100644 --- a/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h +++ b/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h @@ -140,8 +140,9 @@ LocateStandaloneMmCorePeCoffData ( Use the boot information passed by privileged firmware to populate a HOB list suitable for consumption by the MM Core and drivers. - @param CpuDriverEntryPoint Address of MM CPU driver entrypoint - @param PayloadBootInfo Boot information passed by privileged firmware + @param [in, out] CpuDriverEntryPoint Address of MM CPU driver entrypoint + @param [in] PayloadBootInfo Boot information passed by privileged + firmware **/ VOID * @@ -155,9 +156,11 @@ CreateHobListFromBootInfo ( /** The entry point of Standalone MM Foundation. - @param SharedBufAddress Pointer to the Buffer between SPM and SP. - @param cookie1. - @param cookie2. + @param [in] SharedBufAddress Pointer to the Buffer between SPM and SP. + @param [in] SharedBufSize Size of the shared buffer. + @param [in] cookie1 Cookie 1 + @param [in] cookie2 Cookie 2 + **/ VOID EFIAPI diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c index 08b12c45bc2937942a85ee66cf1a6d80bfa41e69..887f2559dfd05bedb66bb86cd17021efa6a4aea0 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c @@ -2,7 +2,7 @@ Creates HOB during Standalone MM Foundation entry point on ARM platforms. -Copyright (c) 2017 - 2018, ARM Ltd. All rights reserved.
+Copyright (c) 2017 - 2020, Arm Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -46,7 +46,9 @@ extern EFI_GUID gEfiArmTfCpuDriverEpDescriptorGuid; Use the boot information passed by privileged firmware to populate a HOB list suitable for consumption by the MM Core and drivers. - @param PayloadBootInfo Boot information passed by privileged firmware + @param [in, out] CpuDriverEntryPoint Address of MM CPU driver entrypoint + @param [in] PayloadBootInfo Boot information passed by privileged + firmware **/ VOID * diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index 3d3c772019df9afe9b8ec77019c776ea7c3b55fb..19472fa659a20d84eebd9e31e20eabab6596f799 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -214,9 +214,10 @@ GetSpmVersion (VOID) /** The entry point of Standalone MM Foundation. - @param SharedBufAddress Pointer to the Buffer between SPM and SP. - @param cookie1. - @param cookie2. + @param [in] SharedBufAddress Pointer to the Buffer between SPM and SP. + @param [in] SharedBufSize Size of the shared buffer. + @param [in] cookie1 Cookie 1 + @param [in] cookie2 Cookie 2 **/ VOID -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'