From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.54]) by mx.groups.io with SMTP id smtpd.web12.464.1607539672218205762 for ; Wed, 09 Dec 2020 10:47:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=BqQGS5TN; spf=pass (domain: arm.com, ip: 40.107.7.54, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcP2JyDP1E+Y9AWUPmdJs9segnDe7BPpsE6PFuDacqc=; b=BqQGS5TN5M6PBOneIh5H41g4SYMNA/XMSJ2dGp7E9o6S9IWHqA4BHUZ45UzXZPW4dJiUQ9Lm5cuE3Rw+HsYUwCp0gJWiPE28uHnR9flJkAu200OmenyiQLwG/K2hA0EJZOiTpeDIonQQxBhU7LNkavUH9t3YdnXDCUn1dNpyM6I= Received: from MR2P264CA0022.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::34) by AM6PR08MB4616.eurprd08.prod.outlook.com (2603:10a6:20b:6f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Wed, 9 Dec 2020 18:47:49 +0000 Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:1:cafe::6f) by MR2P264CA0022.outlook.office365.com (2603:10a6:500:1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21 via Frontend Transport; Wed, 9 Dec 2020 18:47:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:49 +0000 Received: ("Tessian outbound 665ba7fbdfd9:v71"); Wed, 09 Dec 2020 18:47:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e3026f28069e16a3 X-CR-MTA-TID: 64aa7808 Received: from 1624fdd84d0d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F69C296E-B1C0-48EF-9C6B-4E13A9A27545.1; Wed, 09 Dec 2020 18:47:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1624fdd84d0d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Dec 2020 18:47:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d3wymT6gPdSCTgyxgZvZQxuqBFLUbihDSTCJOw+HlWS08S5WwqFBWOO3eDv96GaTDnlCWQuNCB0x6nL4SuQ9gFIX5HimCkr5uP5PWnt7KscotkTTTiW6AN7zX6eKLRTc5DZc91Mx/ZVszZCiobU36j1zKV8mPuzMqv9EHr85Pal72I3+0ujKelRjtR4PJjNfMknSmumg77bcxjuZ/rwms+2f+FDdtMXePbi3AxixpV8oCIwrK0HawyhhBicu0C29AIBmzYhuJpONeYfela+0ZS+K/FsIo43huSjqvkOe5DLq/NZTTqQ5NXnSQpxbveaG4PniFpXzU+XaSa5KLNchWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcP2JyDP1E+Y9AWUPmdJs9segnDe7BPpsE6PFuDacqc=; b=SuZT/Am5Mla3hxKTfxbBWmhNXMbkHoix5FToiW5QOovR4RBg/OKp1tkpO8afDFykUZ7mAzpZ/Wtlx4Ti6eaBmrnOzKT/f5Z6AZ/0teCgeL6AaJM0psuTfNzLGBSJq8wNW1AzzyVV2CmVmf/fXXrrxplJST9hhdCkbCL2lh/AevZrTxguOqxWT7hIwHW5QEUkgQvSP2acEU+D792sfpSGARZmjthCmX6/axI3rOXVzpK2nlb2e2/9O++pKqv4Bv4FQl6UEo/lfCZsVxtmsB5D7yAsfUrXgsmm6VbNTq62le99G6FtTY9k+rTPSdaISyFFKd1Hv+2JHCwA1qrig1L++Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcP2JyDP1E+Y9AWUPmdJs9segnDe7BPpsE6PFuDacqc=; b=BqQGS5TN5M6PBOneIh5H41g4SYMNA/XMSJ2dGp7E9o6S9IWHqA4BHUZ45UzXZPW4dJiUQ9Lm5cuE3Rw+HsYUwCp0gJWiPE28uHnR9flJkAu200OmenyiQLwG/K2hA0EJZOiTpeDIonQQxBhU7LNkavUH9t3YdnXDCUn1dNpyM6I= Received: from DB9PR05CA0017.eurprd05.prod.outlook.com (2603:10a6:10:1da::22) by VI1PR0801MB1709.eurprd08.prod.outlook.com (2603:10a6:800:59::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 18:47:32 +0000 Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da::4) by DB9PR05CA0017.outlook.office365.com (2603:10a6:10:1da::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:32 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 9 Dec 2020 18:47:24 +0000 Received: from E107187.Arm.com (10.57.26.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Wed, 9 Dec 2020 18:47:24 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , Subject: [PATCH v1 22/25] StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint Date: Wed, 9 Dec 2020 18:47:07 +0000 Message-ID: <20201209184710.20912-23-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201209184710.20912-1-sami.mujawar@arm.com> References: <20201209184710.20912-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7fce253-5367-4753-8b87-08d89c72ed1e X-MS-TrafficTypeDiagnostic: VI1PR0801MB1709:|AM6PR08MB4616: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3gLvA6NfXzq942z6nk17Hn4ZTeyQq5dttMqZ5GXQQk+RnaxmG6qf/iCt5Sqw2TvAz19E/l6pyKE0jiieaJWSXCvGOlIbkZddIabcHa1gkpmcQChu/krzUpG6X3XiBSa7O89iZMwkzOIvR1kyM+h+C+6x9234Uu1AG6ICk8XtVYdKAKcwIzHDNXd8pqVZbBs7y51elU+qdw4+yAqANi2X1dqYrmhmj47L4Ih6SlJ2SzNdvD22wSNHhgpuppsZHfSPw0lBdWwfWqSdvkIPRDJ35R6VSpDNpjki8g0nAsZI584D6eO71wv2DIJP2cdDLiYHWXzwWwsn5dsOp0dgYzMDx4RukkOpCfk31hrswNgXadrNt2npqO/PM1z1MS9Tm5PUGZKjJEXg8iPPl2hMo5FZHg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(376002)(136003)(346002)(46966005)(508600001)(2616005)(7696005)(44832011)(6666004)(426003)(36756003)(54906003)(26005)(70206006)(83380400001)(70586007)(1076003)(5660300002)(81166007)(356005)(8676002)(86362001)(186003)(8936002)(336012)(4326008)(6916009)(82310400003)(2906002)(47076004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1709 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: da4212e1-6384-49ea-57e8-08d89c72e30f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QghchO+iMWJCt+O2eWNNXIiRLWXD4QfZ2tDHXlidvgCDw5gW2rlttCoP3fj/fjUTw0PrfQnBgDuEpIW5XrQMwSrwEKZBDIDMzdhllBg4KqX5a43XKlU+ikpT1c6UMVVtzpzLu3OARXdg+SsTTpB0XXNgs1AcRlRgFzPIzwkV6NhfGjYlue++iM7SMO5Nwn+QY6GeIAOQ8m5SPfxkF9JuJQlQmCp4RoL8atxu4DhnAN2Bc6Cg0Db7mQl5yAfj/WBnyWMiQIgnOoV6ooVT6JTusNA8FXTYubMYR6hw3THu+JUxMoP+lWw6/VQ8H71F4wGe+Fp06caX3btcQka+S2apvsS6DHM2+Jxgd2JhIKvpIXo930ZpBjOYdM69Q3MyJMCcD5jR7IBj/xRWRifqpenuTg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966005)(5660300002)(1076003)(82740400003)(70206006)(70586007)(47076004)(54906003)(86362001)(316002)(478600001)(6916009)(186003)(83380400001)(4326008)(8936002)(2906002)(336012)(426003)(8676002)(2616005)(7696005)(44832011)(6666004)(36756003)(81166007)(82310400003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2020 18:47:49.0052 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7fce253-5367-4753-8b87-08d89c72ed1e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4616 Content-Type: text/plain The ECC tool reports error [8005] Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' for the constants SPM_MAJOR_VER, SPM_MINOR_VER & BOOT_PAYLOAD_VERSION. Fix this by changing converting these constant variables to #defined values. Signed-off-by: Sami Mujawar --- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index d097c50360adce7f2280ea4d575971927860706e..1363d54ceebfcbc1d64ff476d4f33bdd626a2422 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -31,10 +31,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define SPM_MINOR_VER_MASK 0x0000FFFF #define SPM_MAJOR_VER_SHIFT 16 -CONST UINT32 SPM_MAJOR_VER = 0; -CONST UINT32 SPM_MINOR_VER = 1; +#define SPM_MAJOR_VER 0 +#define SPM_MINOR_VER 1 -CONST UINT8 BOOT_PAYLOAD_VERSION = 1; +#define BOOT_PAYLOAD_VERSION 1 PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT CpuDriverEntryPoint = NULL; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'