From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.74]) by mx.groups.io with SMTP id smtpd.web08.479.1607539671540043413 for ; Wed, 09 Dec 2020 10:47:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=w2F+M+Ac; spf=pass (domain: arm.com, ip: 40.107.5.74, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7WYojA4vuMXzWIwjZr+L0KqJo3i+n7JI0nhOWdyzlM=; b=w2F+M+Ac5xZPlZ7BhaL7JuesU+skBQrGBmMkDaATBUWwBmt4gjDjrajxMS5pWtDFd5YWlazx/+vVfm2liB/E1Xf/HhWtZ/L1IJPukEu9UtTOnhysdEW7Z34oTJj4ot4r4W9Z05g9aPYG+h+FwgQkMKWrPkJ1oqhxy7U8S0ifoo4= Received: from AM5PR0402CA0003.eurprd04.prod.outlook.com (2603:10a6:203:90::13) by VI1PR0802MB2461.eurprd08.prod.outlook.com (2603:10a6:800:af::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Wed, 9 Dec 2020 18:47:48 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::d9) by AM5PR0402CA0003.outlook.office365.com (2603:10a6:203:90::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:48 +0000 Received: ("Tessian outbound 39646a0fd094:v71"); Wed, 09 Dec 2020 18:47:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4d77bbf462a5cd91 X-CR-MTA-TID: 64aa7808 Received: from 78c8aaaa8a79.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F33C94EA-BE58-4008-B84F-6CFA400BB675.1; Wed, 09 Dec 2020 18:47:32 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 78c8aaaa8a79.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Dec 2020 18:47:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZJBVMnRZhojDxI+uSzbmrTPzXgfViIQkRN8CZ/IdrSvn3uL3F2TuxLM2O2iDTrxVBSSn8lfU4bj79vrAU+s/D73bcOyd9eNanv0y9EFA6SWcNZcG8e84AuMu478Ce+um4sfjuqCRZGud9S61H+IEXFnQWzYGpz5ZgBqPZ3VdpAv4Tdy3fUO95N/9s9LQSVmX7o1KhX9MTPWgBmNbSU8eGtEesNoLzW0DZXlC0ERquOEt04J69rAyv+fn8cfTA4ivOzTTgbJ0wThXf5EUPvaNMW3dqh/8Uu/QY+c2pvormIx1ZpsVnEaspXglUUmY5XJg9v8fyar+nHjayJG2j0B0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7WYojA4vuMXzWIwjZr+L0KqJo3i+n7JI0nhOWdyzlM=; b=DhpkZAwoZj/13WbJc1l/s5Pfd7ao0llHtipbDhB5UHHcidQeBc4SXmVjWg5zOTMJ5T1DzgrMldLiVvvVUuPomxCByJNWRuU8hwyET3FMG4J09L8725XFhAZuLKyPs6dhvKvRAb6lUKVlj3q4JLwtfOVM/gRybz+YThZaeSwHbErrg7KSzL4qltkwJoMXTrHCPJVPi5GtRF2gvf1BGCLsbJoZIyqKUGchFlcrqf4QAJfakUzO0oK7ulL9y9pktTlGIJsWtrm3pgat5T2bCoTvyEtilS3DmaE6z+YEYR5A+nKQX2kv9QLT/zBPljU7zuVx5yP53LxJgis4+EcmNDaTTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7WYojA4vuMXzWIwjZr+L0KqJo3i+n7JI0nhOWdyzlM=; b=w2F+M+Ac5xZPlZ7BhaL7JuesU+skBQrGBmMkDaATBUWwBmt4gjDjrajxMS5pWtDFd5YWlazx/+vVfm2liB/E1Xf/HhWtZ/L1IJPukEu9UtTOnhysdEW7Z34oTJj4ot4r4W9Z05g9aPYG+h+FwgQkMKWrPkJ1oqhxy7U8S0ifoo4= Received: from AM0PR04CA0008.eurprd04.prod.outlook.com (2603:10a6:208:122::21) by DBBPR08MB6140.eurprd08.prod.outlook.com (2603:10a6:10:20a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Wed, 9 Dec 2020 18:47:31 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:122:cafe::85) by AM0PR04CA0008.outlook.office365.com (2603:10a6:208:122::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 18:47:31 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 9 Dec 2020 18:47:16 +0000 Received: from E107187.Arm.com (10.57.26.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Wed, 9 Dec 2020 18:47:15 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , Subject: [PATCH v1 07/25] StandaloneMmPkg: Fix ECC error 4002 in FwVol helper Date: Wed, 9 Dec 2020 18:46:52 +0000 Message-ID: <20201209184710.20912-8-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201209184710.20912-1-sami.mujawar@arm.com> References: <20201209184710.20912-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64572f26-3924-4caf-7756-08d89c72ecb1 X-MS-TrafficTypeDiagnostic: DBBPR08MB6140:|VI1PR0802MB2461: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2657;OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DcTP1ADPEuSLzAxsHZUne5gjfDj2SIoIeNgVEH0ExQNFqlnFIYPrDYPHUxvektQCflLZC00xOa6WAIY6pCopvV9YXYafmkZDCWuL5phN15LX4g/EWGDO4Km7nSq5LJ+fexu2SjdMBEq0xgPulp0VAzvNI7zCxxP++dS/NhAgn75nEIoxwBYMTSSDR59kq0Bw1HGTdYxB/NWhnxeyA0smBiDAVlkth8r3XeXwOVR7rkiNwrLpJaZJXspSgast1H5OlVoiScfAjo1YGH6B6+BCs/Z4MFHWR7RngTVMrBeXPDhJxDI3PMo7KGIPR/vX9Z3imLMjq8rGhdpE3i6zvy0PI6XXAFA792aaA596BtD4bPjeUmgAExph5GHTBsi+kmyfFpcEd+oaREy1/Kc3CtxI1g== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(346002)(376002)(136003)(46966005)(2906002)(26005)(426003)(70206006)(54906003)(508600001)(2616005)(356005)(82310400003)(7696005)(6666004)(44832011)(86362001)(6916009)(8936002)(5660300002)(186003)(36756003)(336012)(81166007)(1076003)(70586007)(4326008)(8676002)(83380400001)(47076004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6140 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 41183e2d-b7ba-48d6-e7c2-08d89c72e2a7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aAG4tTUbYLgl+CqSPyIu9ZxNW+fZykdwBJAJLRm1KwUrZDsM4tPvEIj+y299ag+cktzknI7eLViy+7RRY9Sq5NOy/q0g3s5JvpdbtiFIj7aOz41wflYpXQPPra8ilsi2Y3pC5N6/FTUJpB5JoH2mz35fyC4RbMpV2soS1p4Rm4F0Dss4cuTKabtN51mIxSBK8Ygx8ZyxU6AjWfx1mNKLNagVPtXan31uAIfd96qdzDyguHtOvJAC1KzBUB5FXaadbmR0LqFjddnpo79Pk49We2H7fspnrdYjF7NSrfzZ/xYS1tMlm0ZuybmsD5WgPaUXh/ET3xHZqS+sDy1kmBWg7nyKrf+2EtJjs/0sNL24v4OttAZSw1kvusK2C/aUBNb0def5K/weNbZzAfg3u9cXEg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(376002)(136003)(46966005)(508600001)(26005)(70586007)(44832011)(6916009)(36906005)(81166007)(8936002)(47076004)(70206006)(1076003)(86362001)(82310400003)(336012)(8676002)(6666004)(83380400001)(7696005)(2616005)(54906003)(36756003)(426003)(2906002)(5660300002)(4326008)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2020 18:47:48.3523 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64572f26-3924-4caf-7756-08d89c72ecb1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2461 Content-Type: text/plain Fix ECC Error "[4002] Function header doesn't exist Function [MmCoreFfsFindMmDriver] has NO comment immediately preceding it." Signed-off-by: Sami Mujawar --- StandaloneMmPkg/Core/FwVol.c | 29 ++++++++++---------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index 856d86011d314a33cdee66af77f34fc8b290b509..c441afc3957b0f8c39625d8199a16c3823990e99 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -1,7 +1,7 @@ /**@file Copyright (c) 2015, Intel Corporation. All rights reserved.
-Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
+Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -42,23 +42,24 @@ FvIsBeingProcessed ( IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader ); +/** + Given the pointer to the Firmware Volume Header find the + MM driver and return its PE32 image. + + @param [in] FwVolHeader Pointer to memory mapped FV + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_NOT_FOUND Could not find section data. + @retval EFI_OUT_OF_RESOURCES Out of resources. + @retval EFI_VOLUME_CORRUPTED Firmware volume is corrupted. + @retval EFI_UNSUPPORTED Operation not supported. + +**/ EFI_STATUS MmCoreFfsFindMmDriver ( IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader ) -/*++ - -Routine Description: - Given the pointer to the Firmware Volume Header find the - MM driver and return its PE32 image. - -Arguments: - FwVolHeader - Pointer to memory mapped FV - -Returns: - other - Failure - ---*/ { EFI_STATUS Status; EFI_STATUS DepexStatus; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'