public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Vitaly Cheptsov" <cheptsov@ispras.ru>
To: devel@edk2.groups.io
Cc: Vitaly Cheptsov <cheptsov@ispras.ru>,
	Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>,
	Mateusz Albecki <mateusz.albecki@intel.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH 2/2] MdeModulePkg/AtaAtapiPassThru: Add support for drives in RAID mode
Date: Fri, 11 Dec 2020 12:25:02 +0300	[thread overview]
Message-ID: <20201211092502.21763-2-cheptsov@ispras.ru> (raw)
In-Reply-To: <20201211092502.21763-1-cheptsov@ispras.ru>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3118

This resolves the problem of using drivers connected to Intel G33
builtin SATA controller when run from DuetPkg when it can only
be configured in RAID mode through the firmware settings.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Mateusz Albecki <mateusz.albecki@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Vitaly Cheptsov <cheptsov@ispras.ru>
---
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
index 86fe9d954f..5892508aef 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
@@ -620,7 +620,7 @@ AtaAtapiPassThruSupported (
     return EFI_UNSUPPORTED;
   }
 
-  if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) {
+  if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) {
     return EFI_SUCCESS;
   }
 
@@ -1208,6 +1208,12 @@ EnumerateAttachedDevice (
         goto Done;
       }
       break;
+    case PCI_CLASS_MASS_STORAGE_RAID :
+      Instance->AtaPassThruMode.Attributes &= ~EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL;
+      Instance->ExtScsiPassThruMode.Attributes &= ~EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL;
+      //
+      // Fall through to AHCI
+      //
     case PCI_CLASS_MASS_STORAGE_SATADPA :
       //
       // The ATA controller is working at AHCI mode
-- 
2.24.3 (Apple Git-128)


  reply	other threads:[~2020-12-11  9:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11  9:25 [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Vitaly Cheptsov
2020-12-11  9:25 ` Vitaly Cheptsov [this message]
2020-12-14  6:22 ` Wu, Hao A
2020-12-14  7:33   ` Vitaly Cheptsov
2020-12-14  7:56     ` [edk2-devel] " Wu, Hao A
2020-12-14  8:28       ` Vitaly Cheptsov
2020-12-15  1:28         ` Wu, Hao A
2020-12-15  1:44 ` Ni, Ray
2020-12-15  1:52   ` Wu, Hao A
2020-12-15  3:54     ` Michael D Kinney
2020-12-15  8:58       ` Vitaly Cheptsov
2020-12-15 11:07         ` Wu, Hao A
2020-12-15 16:58         ` Michael D Kinney
2020-12-15 17:34           ` Vitaly Cheptsov
2020-12-15 17:41             ` Michael D Kinney
2020-12-15 17:44               ` Vitaly Cheptsov
2020-12-15 18:09                 ` Michael D Kinney
2020-12-15 18:55                   ` Vitaly Cheptsov
2020-12-15 18:59                     ` Michael D Kinney
2020-12-15 19:40                       ` Vitaly Cheptsov
2020-12-15 19:41                         ` Michael D Kinney
2020-12-15 19:46                           ` Vitaly Cheptsov
2020-12-15 20:01                             ` Michael D Kinney
2020-12-16  9:31                               ` Vitaly Cheptsov
2021-02-02 13:00                                 ` Albecki, Mateusz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211092502.21763-2-cheptsov@ispras.ru \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox