public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "INDIA\\sivaramann" <emergingsiva@gmail.com>
To: devel@edk2.groups.io
Subject: [PATCH v1 1/1] Adding changes for issue with Certificate Validation Bug 2433 - HTTPS Certificate Enrollment Issue
Date: Fri, 11 Dec 2020 17:39:27 +0530	[thread overview]
Message-ID: <20201211120927.1478-1-sivaramann@ami.com> (raw)

---
 NetworkPkg/HttpDxe/HttpsSupport.c | 16 +++++++++++-----
 edk2.diff.order                   |  8 ++++++++
 tianocore.template                |  3 +++
 3 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c b/NetworkPkg/HttpDxe/HttpsSupport.c
index 7e0bf85c3c42..5bf2ecec4baa 100644
--- a/NetworkPkg/HttpDxe/HttpsSupport.c
+++ b/NetworkPkg/HttpDxe/HttpsSupport.c
@@ -380,6 +380,7 @@ TlsConfigCertificate (
   EFI_SIGNATURE_DATA  *Cert;
   UINTN               CertArraySizeInBytes;
   UINTN               CertCount;
+  BOOLEAN             CertValidFlag;
   UINT32              ItemDataSize;
 
   CACert     = NULL;
@@ -493,6 +494,7 @@ TlsConfigCertificate (
   //
   ItemDataSize = (UINT32) CACertSize;
   CertList = (EFI_SIGNATURE_LIST *) CACert;
+  CertValidFlag = 0;
   while ((ItemDataSize > 0) && (ItemDataSize >= CertList->SignatureListSize)) {
     Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) CertList + sizeof (EFI_SIGNATURE_LIST) + CertList->SignatureHeaderSize);
     CertCount  = (CertList->SignatureListSize - sizeof (EFI_SIGNATURE_LIST) - CertList->SignatureHeaderSize) / CertList->SignatureSize;
@@ -506,17 +508,21 @@ TlsConfigCertificate (
                                                  Cert->SignatureData,
                                                  CertList->SignatureSize - sizeof (Cert->SignatureOwner)
                                                  );
-      if (EFI_ERROR (Status)) {
-        goto FreeCACert;
-      }
+      if (!EFI_ERROR (Status)) {
+          CertValidFlag = 1;
+        }
+      else
+          break;
 
       Cert = (EFI_SIGNATURE_DATA *) ((UINT8 *) Cert + CertList->SignatureSize);
     }
 
     ItemDataSize -= CertList->SignatureListSize;
     CertList = (EFI_SIGNATURE_LIST *) ((UINT8 *) CertList + CertList->SignatureListSize);
-  }
-
+    
+    }
+  if(CertValidFlag == 1)
+      Status = EFI_SUCCESS;
 FreeCACert:
   FreePool (CACert);
   return Status;
diff --git a/edk2.diff.order b/edk2.diff.order
new file mode 100644
index 000000000000..1d578ac28cca
--- /dev/null
+++ b/edk2.diff.order
@@ -0,0 +1,8 @@
+*.dec
+*.dsc.inc
+*.dsc
+*.fdf
+*.inf
+*.h
+*.vfr
+*.c
diff --git a/tianocore.template b/tianocore.template
new file mode 100644
index 000000000000..cfc4bdddc4cc
--- /dev/null
+++ b/tianocore.template
@@ -0,0 +1,3 @@
+[empty line]
+[empty line]
+Signed-off-by: Sivaraman <sivaramann@ami.com>
-- 
2.28.0.windows.1


             reply	other threads:[~2020-12-11 12:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 12:09 INDIA\sivaramann [this message]
2020-12-11 19:52 ` [edk2-devel] [PATCH v1 1/1] Adding changes for issue with Certificate Validation Bug 2433 - HTTPS Certificate Enrollment Issue Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211120927.1478-1-sivaramann@ami.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox