[PATCH v1 0/1] sbsa-wdt interrupt id update

[PATCH v1 0/1] sbsa-wdt interrupt id update

[Shashi Mallela]

This patch contains an update to interrupt id value of
sbsa wdt,since the previous value of interrupt id used
was causing conflict with a different device of 
sbsa-ref platform.This was preventing the watchdog
interrupt from getting identified.

Shashi Mallela (1):
  Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update

 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.27.0

[PATCH v1 1/1] Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update

[Shashi Mallela]

The previous value of interrupt id used was causing
conflict with a different device of sbsa-ref platform.
This was preventing the watchdog interrupt from getting
identified.Updated SBSA-wdt interrupt id in Gtdt table
to rectify the issue.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
---
 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
index a010b908c434..14733a37183d 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
@@ -36,7 +36,7 @@
 
 #define SBSAQEMU_WDT_REFRESH_FRAME_BASE      0x50010000
 #define SBSAQEMU_WDT_CONTROL_FRAME_BASE      0x50011000
-#define SBSAQEMU_WDT_IRQ                     44
+#define SBSAQEMU_WDT_IRQ                     48
 
 #define GTDT_WDTIMER_EDGE_TRIGGERED   EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE
 #define GTDT_WDTIMER_LEVEL_TRIGGERED  0
-- 
2.27.0

Re: [PATCH v1 1/1] Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update

[Leif Lindholm]

This is a repost of as far as I can tell the same code as the previous
submission, also called v1.

On Fri, Dec 11, 2020 at 12:03:10 -0500, Shashi Mallela wrote:
> The previous value of interrupt id used was causing
> conflict with a different device of sbsa-ref platform.
> This was preventing the watchdog interrupt from getting
> identified.Updated SBSA-wdt interrupt id in Gtdt table
> to rectify the issue.

This reads like changing this value in GTDT affects the interrupt
routing in the sbsa-ref mode. That is not the case.

This patch rectifies that the interrupt used in the first submission
of the QEMU patch was changed due to a conflict before merging, but
the EDK2 patch was not updated in sync, and this was missed on review.

That is what this message should say.

"preventing the watchdog timer from being identified" lacks an agent.
Please add one.

/
    Leif

> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> ---
>  Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> index a010b908c434..14733a37183d 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> @@ -36,7 +36,7 @@
>  
>  #define SBSAQEMU_WDT_REFRESH_FRAME_BASE      0x50010000
>  #define SBSAQEMU_WDT_CONTROL_FRAME_BASE      0x50011000
> -#define SBSAQEMU_WDT_IRQ                     44
> +#define SBSAQEMU_WDT_IRQ                     48
>  
>  #define GTDT_WDTIMER_EDGE_TRIGGERED   EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE
>  #define GTDT_WDTIMER_LEVEL_TRIGGERED  0
> -- 
> 2.27.0
> 

[PATCH v1 0/1] sbsa-wdt interrupt id update

[Shashi Mallela]

The previous value of interrupt id used was not in sync
with the interrupt id being used in qemu sbsa-ref platform
due to a conflict before merging and was missed in last review.
This was preventing the watchdog interrupt from getting
identified.Updated SBSA-wdt interrupt id in Gtdt table
to rectify the issue.

Shashi Mallela (1):
  Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update

 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.27.0

[PATCH v1 0/1] sbsa-wdt interrupt id update

[Shashi Mallela]

Updated SBSA-wdt interrupt id in Gtdt table since
the previous value was being used by a different
source in qemu sbsa-ref platform.

Shashi Mallela (1):
  Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update

 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.27.0