From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.28362.1607910240423938282 for ; Sun, 13 Dec 2020 17:44:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: heng.luo@intel.com) IronPort-SDR: h3MWtKsA43DjdONiKW445FXID7pJAhp0VyiV1n6p4R21gBSORdxDYNp8rrc9lb1crScUsbcDOd Y2Oy02aVhejA== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="236230099" X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="236230099" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2020 17:43:57 -0800 IronPort-SDR: odATo7pzNobrTx2Y/iD0Et99IOdpzkNNOdl96VQzIzXGOChcXh/nnhcYoVskUyZh7F/F8dMBTg njPZWZFx863Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="331624901" Received: from hengluo-dev.ccr.corp.intel.com ([10.239.153.154]) by fmsmga008.fm.intel.com with ESMTP; 13 Dec 2020 17:43:56 -0800 From: "Heng Luo" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport Date: Mon, 14 Dec 2020 09:43:52 +0800 Message-Id: <20201214014352.1087-1-heng.luo@intel.com> X-Mailer: git-send-email 2.24.0.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 Add gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable for USB DCI debug feature, feature is enabled if PcdDciEnable is TRUE, it allows to debug BIOS via DCI cable. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Heng Luo --- Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec = | 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPchPolicyUpdatePreMem.c | 8 +++++++- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf | 4 ++++ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc = | 2 ++ Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc= | 2 ++ 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec b/Plat= form/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec index fbb9549e44..196460e170 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec @@ -554,6 +554,7 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdNCT6776FHWMON= | [PcdsDynamicEx]=0D =0D [PcdsDynamic, PcdsDynamicEx]=0D +gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable |FALSE|BOOLE= AN|0x20000001=0D =0D [PcdsPatchableInModule]=0D =0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPchPolicyUpdatePreMem.c b/Platform/Intel/WhiskeylakeOpenBoard= Pkg/Policy/Library/PeiPolicyUpdateLib/PeiPchPolicyUpdatePreMem.c index 2d48b09175..bb34f89fb5 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c @@ -83,7 +83,13 @@ UpdatePeiPchPolicyPreMem ( Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, &gIshPreMemConfigGui= d, (VOID *) &IshPreMemConfig);=0D ASSERT_EFI_ERROR (Status);=0D =0D - DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2;=0D + if (PcdGetBool (PcdDciEnable)) {=0D + DciPreMemConfig->PlatformDebugConsent =3D 3;=0D + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 1;=0D + } else {=0D + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2;=0D + }=0D +=0D PchTraceHubPreMemConfig->MemReg0Size =3D 3;=0D PchTraceHubPreMemConfig->MemReg1Size =3D 3;=0D //=0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPolicyUpdateLib.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/= Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf index 478e2d0512..252f92f487 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPolicyUpdateLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPolicyUpdateLib.inf @@ -230,6 +230,9 @@ =0D gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdEcPresent=0D =0D + # Enable/Disable USB DCI Debug=0D + gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable = ## CONSUMES=0D +=0D gIntelSiliconPkgTokenSpaceGuid.PcdIntelGraphicsVbtFileGuid = ## CONSUMES=0D gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSmbusAlertEnable = ## CONSUMES=0D gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSataLedEnable = ## CONSUMES=0D @@ -243,6 +246,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdSystemFmpCapsuleImageTypeIdGuid ## C= ONSUMES=0D gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## C= ONSUMES=0D =0D +=0D [FixedPcd]=0D gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize ## CO= NSUMES=0D gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize ## CO= NSUMES=0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPc= d.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc index e161bf06f4..84d4ec1331 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc @@ -399,6 +399,8 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1=0D gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1=0D =0D + gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE=0D +=0D [PcdsDynamicHii.X64.DEFAULT]=0D ######################################=0D # Edk2 Configuration=0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoa= rdPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkgPcd.dsc index 83ada3c95c..4a7ba4d5f0 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc @@ -389,6 +389,8 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1=0D gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1=0D =0D + gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE=0D +=0D [PcdsDynamicHii.X64.DEFAULT]=0D ######################################=0D # Edk2 Configuration=0D --=20 2.24.0.windows.2