From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web08.33082.1607944886142276196 for ; Mon, 14 Dec 2020 03:21:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Z8ItUCkl; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id x22so13368039wmc.5 for ; Mon, 14 Dec 2020 03:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MwzLgHX4moDY4t5457qlkRWPJDHzpDA0YOfjUvPL9js=; b=Z8ItUCklWK7rwFBi07Tknt19E3XHJlrfLaPO6W6PjhgvbTJf3YLXgAwRdS5Gt5tZc/ mimW6+flCM9+JrMJdQqqDLAjwcNcjJz9ynzFvUiT9zMLtao7pemgynE1w9qXmUJ32Z7K 7MkBy1wxEfdzcBMVwSH8IztOllZFwjRQZC7+3MbXZoMkOGf7COvEoCYcH+3EqNRJTGJK xbrnOmOmadppHcDy6T5nAs4JjEQjT3XNBDqJwEDgvKFTaaUSVCnRNh8rNY0TLqU6Guin D/Wj+WOOe+oKgwE2WBMQfmBkjl4dk+PtSj8VBGjjDCn0oEHBGHdU/DY+yv6Gp2ZStFtN CMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MwzLgHX4moDY4t5457qlkRWPJDHzpDA0YOfjUvPL9js=; b=ftV4vGziRutVz0K37ZGPA44RrwcDBa+TeDCOFcH42w/8KLsp2mNTDdL7VqhoIVh/9G w7TLTp/Tj1I2uMPX4iX9+6pFR+dkq0XOlO9sNI5HZP6SMqr7akCGJik/Z73w1cL6td6A 8quHzqcMiw471Q/KOZKyg/rA99FygeUmwKmYKgTZRxleOhL3XzCR+OmxCvynw7XurvRB SgPZ6jK3z0VRW1DnuABXUcXylAqCl/okjR9DDj1nQ1mbcEPUWawveRojtNPcsiSQGXHG 7LXX5LvE+rz+wsR6AW3rUl82tfcXYc4F5aA5wc4tWQA0771AjMR6KeT66ZnwHU4lRKIm +WTw== X-Gm-Message-State: AOAM532covpN0TCyM6GKKs3pmApe9zBQjewjiDnSBBOQtbuzjJD576Rv Q2inBJsXBMLm1cZRSV6yitdCvg== X-Google-Smtp-Source: ABdhPJzYI2yxbfHFpH3cv9MdXWzx6Fep3/Rj89fyX7HKNHnX/vlygUXnJkHylLG5hD1MAgSPrnkIgA== X-Received: by 2002:a1c:b082:: with SMTP id z124mr26743429wme.129.1607944884316; Mon, 14 Dec 2020 03:21:24 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id t10sm30338975wrp.39.2020.12.14.03.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 03:21:23 -0800 (PST) Date: Mon, 14 Dec 2020 11:21:21 +0000 From: "Leif Lindholm" To: Shashi Mallela Cc: ard.biesheuvel@arm.com, graeme@nuviainc.com, devel@edk2.groups.io Subject: Re: [PATCH v1 1/1] Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update Message-ID: <20201214112121.GU1664@vanye> References: <20201211170310.9766-1-shashi.mallela@linaro.org> <20201211170310.9766-2-shashi.mallela@linaro.org> MIME-Version: 1.0 In-Reply-To: <20201211170310.9766-2-shashi.mallela@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This is a repost of as far as I can tell the same code as the previous submission, also called v1. On Fri, Dec 11, 2020 at 12:03:10 -0500, Shashi Mallela wrote: > The previous value of interrupt id used was causing > conflict with a different device of sbsa-ref platform. > This was preventing the watchdog interrupt from getting > identified.Updated SBSA-wdt interrupt id in Gtdt table > to rectify the issue. This reads like changing this value in GTDT affects the interrupt routing in the sbsa-ref mode. That is not the case. This patch rectifies that the interrupt used in the first submission of the QEMU patch was changed due to a conflict before merging, but the EDK2 patch was not updated in sync, and this was missed on review. That is what this message should say. "preventing the watchdog timer from being identified" lacks an agent. Please add one. / Leif > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Graeme Gregory > Signed-off-by: Shashi Mallela > --- > Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > index a010b908c434..14733a37183d 100644 > --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > @@ -36,7 +36,7 @@ > > #define SBSAQEMU_WDT_REFRESH_FRAME_BASE 0x50010000 > #define SBSAQEMU_WDT_CONTROL_FRAME_BASE 0x50011000 > -#define SBSAQEMU_WDT_IRQ 44 > +#define SBSAQEMU_WDT_IRQ 48 > > #define GTDT_WDTIMER_EDGE_TRIGGERED EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE > #define GTDT_WDTIMER_LEVEL_TRIGGERED 0 > -- > 2.27.0 >