* [PATCH v1-resend 0/1] sbsa-wdt interrupt id update
@ 2020-12-14 17:45 Shashi Mallela
2020-12-14 17:45 ` [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: " Shashi Mallela
0 siblings, 1 reply; 3+ messages in thread
From: Shashi Mallela @ 2020-12-14 17:45 UTC (permalink / raw)
To: leif, ard.biesheuvel, graeme; +Cc: devel
The previous value of interrupt id used was not in sync
with the interrupt id being used in qemu sbsa-ref platform
due to a conflict before merging and was missed in last review.
This was preventing the watchdog interrupt from getting
identified.Updated SBSA-wdt interrupt id in Gtdt table
to rectify the issue.
Shashi Mallela (1):
Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update
Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update
2020-12-14 17:45 [PATCH v1-resend 0/1] sbsa-wdt interrupt id update Shashi Mallela
@ 2020-12-14 17:45 ` Shashi Mallela
2020-12-15 11:57 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Shashi Mallela @ 2020-12-14 17:45 UTC (permalink / raw)
To: leif, ard.biesheuvel, graeme; +Cc: devel
The previous value of interrupt id used was not in sync
with the interrupt id being used in qemu sbsa-ref platform
due to a conflict before merging and was missed in last review.
This was preventing the watchdog interrupt from getting
identified.Updated SBSA-wdt interrupt id in Gtdt table
to rectify the issue.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
---
Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
index a010b908c434..14733a37183d 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
@@ -36,7 +36,7 @@
#define SBSAQEMU_WDT_REFRESH_FRAME_BASE 0x50010000
#define SBSAQEMU_WDT_CONTROL_FRAME_BASE 0x50011000
-#define SBSAQEMU_WDT_IRQ 44
+#define SBSAQEMU_WDT_IRQ 48
#define GTDT_WDTIMER_EDGE_TRIGGERED EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE
#define GTDT_WDTIMER_LEVEL_TRIGGERED 0
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update
2020-12-14 17:45 ` [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: " Shashi Mallela
@ 2020-12-15 11:57 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2020-12-15 11:57 UTC (permalink / raw)
To: Shashi Mallela; +Cc: ard.biesheuvel, graeme, devel
On Mon, Dec 14, 2020 at 12:45:12 -0500, Shashi Mallela wrote:
> The previous value of interrupt id used was not in sync
> with the interrupt id being used in qemu sbsa-ref platform
> due to a conflict before merging and was missed in last review.
> This was preventing the watchdog interrupt from getting
> identified.Updated SBSA-wdt interrupt id in Gtdt table
> to rectify the issue.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 406d37e36414.
Thanks!
/
Leif
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> index a010b908c434..14733a37183d 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> @@ -36,7 +36,7 @@
>
> #define SBSAQEMU_WDT_REFRESH_FRAME_BASE 0x50010000
> #define SBSAQEMU_WDT_CONTROL_FRAME_BASE 0x50011000
> -#define SBSAQEMU_WDT_IRQ 44
> +#define SBSAQEMU_WDT_IRQ 48
>
> #define GTDT_WDTIMER_EDGE_TRIGGERED EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE
> #define GTDT_WDTIMER_LEVEL_TRIGGERED 0
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-15 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-14 17:45 [PATCH v1-resend 0/1] sbsa-wdt interrupt id update Shashi Mallela
2020-12-14 17:45 ` [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: " Shashi Mallela
2020-12-15 11:57 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox